[INFO] updating cached repository bddap/chaincad [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bddap/chaincad [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/chaincad" "work/ex/clippy-test-run/sources/stable/gh/bddap/chaincad"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bddap/chaincad'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/chaincad" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/chaincad"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/chaincad'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 141df341f4df4635c8b76e73b06c8feb8e2521a7 [INFO] sha for GitHub repo bddap/chaincad: 141df341f4df4635c8b76e73b06c8feb8e2521a7 [INFO] validating manifest of bddap/chaincad on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bddap/chaincad on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bddap/chaincad [INFO] finished frobbing bddap/chaincad [INFO] frobbed toml for bddap/chaincad written to work/ex/clippy-test-run/sources/stable/gh/bddap/chaincad/Cargo.toml [INFO] started frobbing bddap/chaincad [INFO] finished frobbing bddap/chaincad [INFO] frobbed toml for bddap/chaincad written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/chaincad/Cargo.toml [INFO] crate bddap/chaincad has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bddap/chaincad against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/chaincad:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa5b2aee699e61e8bee2955820bd5765e9bd66bbfb5857a8a56fa89c8569751a [INFO] running `"docker" "start" "-a" "aa5b2aee699e61e8bee2955820bd5765e9bd66bbfb5857a8a56fa89c8569751a"` [INFO] [stderr] Checking chaincad v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/clip.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok((Clip::Child(source), &[])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Clip::Child(source), &[]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Parent` [INFO] [stderr] --> src/eval.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Parent(Vec>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Child` [INFO] [stderr] --> src/eval.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Child(&'a [char]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `desugar` [INFO] [stderr] --> src/eval.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | fn desugar<'b>(src: &'b Clip) -> DeSugaredClip<'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `desugar_parent` [INFO] [stderr] --> src/eval.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | fn desugar_parent<'b>(parent: &'b [Clip]) -> DeSugaredClip<'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/clip.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_slice<'b>(source: &'b [char]) -> Result, ()> { [INFO] [stderr] 12 | | let (ret, rest) = Self::parse_clip(source)?; [INFO] [stderr] 13 | | if rest.iter().filter(|c| !c.is_whitespace()).next() == None { [INFO] [stderr] 14 | | Ok(ret) [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/clip.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if rest.iter().filter(|c| !c.is_whitespace()).next() == None { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|c| !c.is_whitespace()).next()` with `find(|c| !c.is_whitespace())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/clip.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Ok((Clip::Child(source), &[])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Clip::Child(source), &[]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/clip.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn from_slice<'b>(source: &'b [char]) -> Result, ()> { [INFO] [stderr] 12 | | let (ret, rest) = Self::parse_clip(source)?; [INFO] [stderr] 13 | | if rest.iter().filter(|c| !c.is_whitespace()).next() == None { [INFO] [stderr] 14 | | Ok(ret) [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/clip.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if rest.iter().filter(|c| !c.is_whitespace()).next() == None { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|c| !c.is_whitespace()).next()` with `find(|c| !c.is_whitespace())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "aa5b2aee699e61e8bee2955820bd5765e9bd66bbfb5857a8a56fa89c8569751a"` [INFO] running `"docker" "rm" "-f" "aa5b2aee699e61e8bee2955820bd5765e9bd66bbfb5857a8a56fa89c8569751a"` [INFO] [stdout] aa5b2aee699e61e8bee2955820bd5765e9bd66bbfb5857a8a56fa89c8569751a