[INFO] updating cached repository bazhenov/fast-estimate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bazhenov/fast-estimate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bazhenov/fast-estimate" "work/ex/clippy-test-run/sources/stable/gh/bazhenov/fast-estimate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bazhenov/fast-estimate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bazhenov/fast-estimate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bazhenov/fast-estimate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bazhenov/fast-estimate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8adcbe489475d9e624ea87694ad805e17ba13f3 [INFO] sha for GitHub repo bazhenov/fast-estimate: f8adcbe489475d9e624ea87694ad805e17ba13f3 [INFO] validating manifest of bazhenov/fast-estimate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bazhenov/fast-estimate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bazhenov/fast-estimate [INFO] finished frobbing bazhenov/fast-estimate [INFO] frobbed toml for bazhenov/fast-estimate written to work/ex/clippy-test-run/sources/stable/gh/bazhenov/fast-estimate/Cargo.toml [INFO] started frobbing bazhenov/fast-estimate [INFO] finished frobbing bazhenov/fast-estimate [INFO] frobbed toml for bazhenov/fast-estimate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bazhenov/fast-estimate/Cargo.toml [INFO] crate bazhenov/fast-estimate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bazhenov/fast-estimate against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bazhenov/fast-estimate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fb5462de366f730e943137165566dd0c975aa6475e4b360d4090b91f26be6a9 [INFO] running `"docker" "start" "-a" "4fb5462de366f730e943137165566dd0c975aa6475e4b360d4090b91f26be6a9"` [INFO] [stderr] Checking md5 v0.3.8 [INFO] [stderr] Checking est v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return (l * (l / nf).ln()).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(l * (l / nf).ln()).round() as u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return num % (self.buffer.len() * 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num % (self.buffer.len() * 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | let mut i: u32 = i - ((i >> 1) & 0x55555555); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5555_5555` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | i = (i & 0x33333333) + ((i >> 2) & 0x33333333); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3333_3333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | i = (i & 0x33333333) + ((i >> 2) & 0x33333333); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3333_3333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0F0F_0F0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:73:54 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:97:39 [INFO] [stderr] | [INFO] [stderr] 97 | let mut lc = LinearCounter::new(1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(pop_count(0x00000000), 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(pop_count(0xFFFFFFFF), 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(pop_count(0xFF0F0F00), 16); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF0F_0F00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return (l * (l / nf).ln()).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(l * (l / nf).ln()).round() as u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return num % (self.buffer.len() * 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num % (self.buffer.len() * 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linear_counter.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | let mut i: u32 = i - ((i >> 1) & 0x55555555); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5555_5555` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | i = (i & 0x33333333) + ((i >> 2) & 0x33333333); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3333_3333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | i = (i & 0x33333333) + ((i >> 2) & 0x33333333); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3333_3333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0F0F_0F0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/linear_counter.rs:73:54 [INFO] [stderr] | [INFO] [stderr] 73 | return (((i + (i >> 4)) & 0x0F0F0F0F).wrapping_mul(0x01010101)) >> 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/linear_counter.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let nf: f64 = l - self.population_count() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.population_count())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/linear_counter.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | if i <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using i == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if n <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `est`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/linear_counter.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | let nf: f64 = l - self.population_count() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.population_count())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/linear_counter.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | if i <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using i == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if n <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `est`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4fb5462de366f730e943137165566dd0c975aa6475e4b360d4090b91f26be6a9"` [INFO] running `"docker" "rm" "-f" "4fb5462de366f730e943137165566dd0c975aa6475e4b360d4090b91f26be6a9"` [INFO] [stdout] 4fb5462de366f730e943137165566dd0c975aa6475e4b360d4090b91f26be6a9