[INFO] updating cached repository bahelms/rustactoe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bahelms/rustactoe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bahelms/rustactoe" "work/ex/clippy-test-run/sources/stable/gh/bahelms/rustactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bahelms/rustactoe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bahelms/rustactoe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahelms/rustactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahelms/rustactoe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89629978bf1ee407505f0b9cb4b6b38b91390d25 [INFO] sha for GitHub repo bahelms/rustactoe: 89629978bf1ee407505f0b9cb4b6b38b91390d25 [INFO] validating manifest of bahelms/rustactoe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bahelms/rustactoe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bahelms/rustactoe [INFO] finished frobbing bahelms/rustactoe [INFO] frobbed toml for bahelms/rustactoe written to work/ex/clippy-test-run/sources/stable/gh/bahelms/rustactoe/Cargo.toml [INFO] started frobbing bahelms/rustactoe [INFO] finished frobbing bahelms/rustactoe [INFO] frobbed toml for bahelms/rustactoe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahelms/rustactoe/Cargo.toml [INFO] crate bahelms/rustactoe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bahelms/rustactoe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahelms/rustactoe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a874ee01e5084318e3d47ec3f0a4348e60ad0c226cef10f54ebb9e1b4b47f86e [INFO] running `"docker" "start" "-a" "a874ee01e5084318e3d47ec3f0a4348e60ad0c226cef10f54ebb9e1b4b47f86e"` [INFO] [stderr] Checking rand v0.5.1 [INFO] [stderr] Checking rustactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match can_win_in_next_move(&open_cells, &state.active_player.faction, &state) { [INFO] [stderr] 7 | | Some(cell) => return cell, [INFO] [stderr] 8 | | None => () [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(cell) = can_win_in_next_move(&open_cells, &state.active_player.faction, &state) { return cell }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match can_win_in_next_move(&open_cells, opposing_faction, &state) { [INFO] [stderr] 13 | | Some(cell) => return cell, [INFO] [stderr] 14 | | None => () [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(cell) = can_win_in_next_move(&open_cells, opposing_faction, &state) { return cell }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/ai.rs:50:32 [INFO] [stderr] | [INFO] [stderr] 50 | fn can_win_in_next_move(cells: &Vec, faction: &str, state: &GameState) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match check_game_state(&test_state) { [INFO] [stderr] 55 | | Some(_) => return Some(cell), [INFO] [stderr] 56 | | None => () [INFO] [stderr] 57 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = check_game_state(&test_state) { return Some(cell) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game/mod.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn init_state<'a>(player: &'a Player) -> GameState<'a> { [INFO] [stderr] 24 | | GameState { [INFO] [stderr] 25 | | board: [" "; 9], [INFO] [stderr] 26 | | active_player: player, [INFO] [stderr] 27 | | win_states: init_win_states(), [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / match check_game_state(&state) { [INFO] [stderr] 63 | | Some(name) => { [INFO] [stderr] 64 | | draw_board(&state.board); [INFO] [stderr] 65 | | println!("{} has won the game!", name); [INFO] [stderr] ... | [INFO] [stderr] 68 | | _ => () [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(name) = check_game_state(&state) { [INFO] [stderr] 63 | draw_board(&state.board); [INFO] [stderr] 64 | println!("{} has won the game!", name); [INFO] [stderr] 65 | break; [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / match check_game_state(&state) { [INFO] [stderr] 77 | | Some(name) => { [INFO] [stderr] 78 | | draw_board(&state.board); [INFO] [stderr] 79 | | println!("{} has won the game!", name); [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(name) = check_game_state(&state) { [INFO] [stderr] 77 | draw_board(&state.board); [INFO] [stderr] 78 | println!("{} has won the game!", name); [INFO] [stderr] 79 | break; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/mod.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | fn matches_win_state(win_states: &Vec<[usize; 2]>, state: &GameState) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[usize; 2]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / match can_win_in_next_move(&open_cells, &state.active_player.faction, &state) { [INFO] [stderr] 7 | | Some(cell) => return cell, [INFO] [stderr] 8 | | None => () [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(cell) = can_win_in_next_move(&open_cells, &state.active_player.faction, &state) { return cell }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match can_win_in_next_move(&open_cells, opposing_faction, &state) { [INFO] [stderr] 13 | | Some(cell) => return cell, [INFO] [stderr] 14 | | None => () [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(cell) = can_win_in_next_move(&open_cells, opposing_faction, &state) { return cell }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/ai.rs:50:32 [INFO] [stderr] | [INFO] [stderr] 50 | fn can_win_in_next_move(cells: &Vec, faction: &str, state: &GameState) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/ai.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match check_game_state(&test_state) { [INFO] [stderr] 55 | | Some(_) => return Some(cell), [INFO] [stderr] 56 | | None => () [INFO] [stderr] 57 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = check_game_state(&test_state) { return Some(cell) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game/mod.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn init_state<'a>(player: &'a Player) -> GameState<'a> { [INFO] [stderr] 24 | | GameState { [INFO] [stderr] 25 | | board: [" "; 9], [INFO] [stderr] 26 | | active_player: player, [INFO] [stderr] 27 | | win_states: init_win_states(), [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / match check_game_state(&state) { [INFO] [stderr] 63 | | Some(name) => { [INFO] [stderr] 64 | | draw_board(&state.board); [INFO] [stderr] 65 | | println!("{} has won the game!", name); [INFO] [stderr] ... | [INFO] [stderr] 68 | | _ => () [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(name) = check_game_state(&state) { [INFO] [stderr] 63 | draw_board(&state.board); [INFO] [stderr] 64 | println!("{} has won the game!", name); [INFO] [stderr] 65 | break; [INFO] [stderr] 66 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / match check_game_state(&state) { [INFO] [stderr] 77 | | Some(name) => { [INFO] [stderr] 78 | | draw_board(&state.board); [INFO] [stderr] 79 | | println!("{} has won the game!", name); [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(name) = check_game_state(&state) { [INFO] [stderr] 77 | draw_board(&state.board); [INFO] [stderr] 78 | println!("{} has won the game!", name); [INFO] [stderr] 79 | break; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game/mod.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | fn matches_win_state(win_states: &Vec<[usize; 2]>, state: &GameState) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[usize; 2]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.28s [INFO] running `"docker" "inspect" "a874ee01e5084318e3d47ec3f0a4348e60ad0c226cef10f54ebb9e1b4b47f86e"` [INFO] running `"docker" "rm" "-f" "a874ee01e5084318e3d47ec3f0a4348e60ad0c226cef10f54ebb9e1b4b47f86e"` [INFO] [stdout] a874ee01e5084318e3d47ec3f0a4348e60ad0c226cef10f54ebb9e1b4b47f86e