[INFO] updating cached repository badboy/flat-json
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/badboy/flat-json
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/badboy/flat-json" "work/ex/clippy-test-run/sources/stable/gh/badboy/flat-json"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/badboy/flat-json'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/badboy/flat-json" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/flat-json"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/flat-json'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c4470ec3f767b1eb4fcb3920c7abce67f5d92392
[INFO] sha for GitHub repo badboy/flat-json: c4470ec3f767b1eb4fcb3920c7abce67f5d92392
[INFO] validating manifest of badboy/flat-json on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of badboy/flat-json on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing badboy/flat-json
[INFO] finished frobbing badboy/flat-json
[INFO] frobbed toml for badboy/flat-json written to work/ex/clippy-test-run/sources/stable/gh/badboy/flat-json/Cargo.toml
[INFO] started frobbing badboy/flat-json
[INFO] finished frobbing badboy/flat-json
[INFO] frobbed toml for badboy/flat-json written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/flat-json/Cargo.toml
[INFO] crate badboy/flat-json has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting badboy/flat-json against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/flat-json:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dd3701b55a3ebe8840e0c53aaca21258ddd7ad0359b7ba1f2be9e93e8021bae2
[INFO] running `"docker" "start" "-a" "dd3701b55a3ebe8840e0c53aaca21258ddd7ad0359b7ba1f2be9e93e8021bae2"`
[INFO] [stderr]     Checking serde_json v1.0.13
[INFO] [stderr]     Checking flat-json v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     match value {
[INFO] [stderr] 21 | |         &Value::Null => scalar("<null>", prefix),
[INFO] [stderr] 22 | |         &Value::Bool(ref b) => scalar(b, prefix),
[INFO] [stderr] 23 | |         &Value::Number(ref i) => scalar(i, prefix),
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |         }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 20 |     match *value {
[INFO] [stderr] 21 |         Value::Null => scalar("<null>", prefix),
[INFO] [stderr] 22 |         Value::Bool(ref b) => scalar(b, prefix),
[INFO] [stderr] 23 |         Value::Number(ref i) => scalar(i, prefix),
[INFO] [stderr] 24 |         Value::String(ref s) => scalar(format!("{:?}", s), prefix),
[INFO] [stderr] 25 |         Value::Array(ref v) => {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/main.rs:43:16
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let args = env::args().skip(1).next();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let arg = args.unwrap_or("".to_string());
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     match value {
[INFO] [stderr] 21 | |         &Value::Null => scalar("<null>", prefix),
[INFO] [stderr] 22 | |         &Value::Bool(ref b) => scalar(b, prefix),
[INFO] [stderr] 23 | |         &Value::Number(ref i) => scalar(i, prefix),
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |         }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 20 |     match *value {
[INFO] [stderr] 21 |         Value::Null => scalar("<null>", prefix),
[INFO] [stderr] 22 |         Value::Bool(ref b) => scalar(b, prefix),
[INFO] [stderr] 23 |         Value::Number(ref i) => scalar(i, prefix),
[INFO] [stderr] 24 |         Value::String(ref s) => scalar(format!("{:?}", s), prefix),
[INFO] [stderr] 25 |         Value::Array(ref v) => {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/main.rs:43:16
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let args = env::args().skip(1).next();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let arg = args.unwrap_or("".to_string());
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.19s
[INFO] running `"docker" "inspect" "dd3701b55a3ebe8840e0c53aaca21258ddd7ad0359b7ba1f2be9e93e8021bae2"`
[INFO] running `"docker" "rm" "-f" "dd3701b55a3ebe8840e0c53aaca21258ddd7ad0359b7ba1f2be9e93e8021bae2"`
[INFO] [stdout] dd3701b55a3ebe8840e0c53aaca21258ddd7ad0359b7ba1f2be9e93e8021bae2