[INFO] updating cached repository azengard/hello-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/azengard/hello-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/azengard/hello-rust" "work/ex/clippy-test-run/sources/stable/gh/azengard/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/azengard/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/azengard/hello-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azengard/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azengard/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5586f5c58001275e8b445ca5a89a4cea6b755863 [INFO] sha for GitHub repo azengard/hello-rust: 5586f5c58001275e8b445ca5a89a4cea6b755863 [INFO] validating manifest of azengard/hello-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of azengard/hello-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing azengard/hello-rust [INFO] finished frobbing azengard/hello-rust [INFO] frobbed toml for azengard/hello-rust written to work/ex/clippy-test-run/sources/stable/gh/azengard/hello-rust/Cargo.toml [INFO] started frobbing azengard/hello-rust [INFO] finished frobbing azengard/hello-rust [INFO] frobbed toml for azengard/hello-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azengard/hello-rust/Cargo.toml [INFO] crate azengard/hello-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting azengard/hello-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azengard/hello-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 58c462a16a38160614cf9f64dc2363432400dee3653074de13fd1a51a03925e8 [INFO] running `"docker" "start" "-a" "58c462a16a38160614cf9f64dc2363432400dee3653074de13fd1a51a03925e8"` [INFO] [stderr] Checking hello-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `Nil` [INFO] [stderr] --> src/main.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | struct Nil; // unit struct [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pair` [INFO] [stderr] --> src/main.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | struct Pair(i32, f32); //tuple struct [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | fn print(s:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Nil` [INFO] [stderr] --> src/main.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | struct Nil; // unit struct [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Pair` [INFO] [stderr] --> src/main.rs:82:1 [INFO] [stderr] | [INFO] [stderr] 82 | struct Pair(i32, f32); //tuple struct [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | fn print(s:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "58c462a16a38160614cf9f64dc2363432400dee3653074de13fd1a51a03925e8"` [INFO] running `"docker" "rm" "-f" "58c462a16a38160614cf9f64dc2363432400dee3653074de13fd1a51a03925e8"` [INFO] [stdout] 58c462a16a38160614cf9f64dc2363432400dee3653074de13fd1a51a03925e8