[INFO] updating cached repository aytee17/c-minus
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/aytee17/c-minus
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/aytee17/c-minus" "work/ex/clippy-test-run/sources/stable/gh/aytee17/c-minus"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aytee17/c-minus'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/aytee17/c-minus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aytee17/c-minus"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aytee17/c-minus'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b60a8ac20ec9d5928309cb8ed8081bd25441a1a7
[INFO] sha for GitHub repo aytee17/c-minus: b60a8ac20ec9d5928309cb8ed8081bd25441a1a7
[INFO] validating manifest of aytee17/c-minus on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of aytee17/c-minus on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing aytee17/c-minus
[INFO] finished frobbing aytee17/c-minus
[INFO] frobbed toml for aytee17/c-minus written to work/ex/clippy-test-run/sources/stable/gh/aytee17/c-minus/Cargo.toml
[INFO] started frobbing aytee17/c-minus
[INFO] finished frobbing aytee17/c-minus
[INFO] frobbed toml for aytee17/c-minus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aytee17/c-minus/Cargo.toml
[INFO] crate aytee17/c-minus has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting aytee17/c-minus against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aytee17/c-minus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7d4534e98396bca3aaaab5c565a59567246032466a0d7b5ab3e065d3b9ee50ed
[INFO] running `"docker" "start" "-a" "7d4534e98396bca3aaaab5c565a59567246032466a0d7b5ab3e065d3b9ee50ed"`
[INFO] [stderr]     Checking c-minus v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scan/mod.rs:67:9
[INFO] [stderr]     |
[INFO] [stderr] 67  | /         return match state {
[INFO] [stderr] 68  | |             Start => match next_char {
[INFO] [stderr] 69  | |                 '+' => Done(PLUS),
[INFO] [stderr] 70  | |                 '-' => Done(MINUS),
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |             Done(x) => Done(x),
[INFO] [stderr] 167 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 67  |         match state {
[INFO] [stderr] 68  |             Start => match next_char {
[INFO] [stderr] 69  |                 '+' => Done(PLUS),
[INFO] [stderr] 70  |                 '-' => Done(MINUS),
[INFO] [stderr] 71  |                 '*' => Done(MULTIPLY),
[INFO] [stderr] 72  |                 '/' => InSlash,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scan/mod.rs:67:9
[INFO] [stderr]     |
[INFO] [stderr] 67  | /         return match state {
[INFO] [stderr] 68  | |             Start => match next_char {
[INFO] [stderr] 69  | |                 '+' => Done(PLUS),
[INFO] [stderr] 70  | |                 '-' => Done(MINUS),
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | |             Done(x) => Done(x),
[INFO] [stderr] 167 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 67  |         match state {
[INFO] [stderr] 68  |             Start => match next_char {
[INFO] [stderr] 69  |                 '+' => Done(PLUS),
[INFO] [stderr] 70  |                 '-' => Done(MINUS),
[INFO] [stderr] 71  |                 '*' => Done(MULTIPLY),
[INFO] [stderr] 72  |                 '/' => InSlash,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/scan/mod.rs:38:16
[INFO] [stderr]    |
[INFO] [stderr] 38 |             if self.load_char() == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.load_char()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/scan/mod.rs:51:22
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn new(path: &String) -> Result<Self> {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 47
[INFO] [stderr]    --> src/scan/mod.rs:65:5
[INFO] [stderr]     |
[INFO] [stderr] 65  | /     fn transition(&mut self, state: State) -> State {
[INFO] [stderr] 66  | |         let next_char = self.get_char();
[INFO] [stderr] 67  | |         return match state {
[INFO] [stderr] 68  | |             Start => match next_char {
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |         };
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/scan/mod.rs:189:17
[INFO] [stderr]     |
[INFO] [stderr] 189 | /                 if size == 1 {
[INFO] [stderr] 190 | |                     true
[INFO] [stderr] 191 | |                 } else {
[INFO] [stderr] 192 | |                     false
[INFO] [stderr] 193 | |                 }
[INFO] [stderr]     | |_________________^ help: you can reduce it to: `size == 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/scan/mod.rs:38:16
[INFO] [stderr]    |
[INFO] [stderr] 38 |             if self.load_char() == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.load_char()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/scan/mod.rs:51:22
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn new(path: &String) -> Result<Self> {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 47
[INFO] [stderr]    --> src/scan/mod.rs:65:5
[INFO] [stderr]     |
[INFO] [stderr] 65  | /     fn transition(&mut self, state: State) -> State {
[INFO] [stderr] 66  | |         let next_char = self.get_char();
[INFO] [stderr] 67  | |         return match state {
[INFO] [stderr] 68  | |             Start => match next_char {
[INFO] [stderr] ...   |
[INFO] [stderr] 167 | |         };
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/scan/mod.rs:189:17
[INFO] [stderr]     |
[INFO] [stderr] 189 | /                 if size == 1 {
[INFO] [stderr] 190 | |                     true
[INFO] [stderr] 191 | |                 } else {
[INFO] [stderr] 192 | |                     false
[INFO] [stderr] 193 | |                 }
[INFO] [stderr]     | |_________________^ help: you can reduce it to: `size == 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.86s
[INFO] running `"docker" "inspect" "7d4534e98396bca3aaaab5c565a59567246032466a0d7b5ab3e065d3b9ee50ed"`
[INFO] running `"docker" "rm" "-f" "7d4534e98396bca3aaaab5c565a59567246032466a0d7b5ab3e065d3b9ee50ed"`
[INFO] [stdout] 7d4534e98396bca3aaaab5c565a59567246032466a0d7b5ab3e065d3b9ee50ed