[INFO] updating cached repository atsushi130/EnigmaMachine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atsushi130/EnigmaMachine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/EnigmaMachine" "work/ex/clippy-test-run/sources/stable/gh/atsushi130/EnigmaMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atsushi130/EnigmaMachine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/EnigmaMachine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/EnigmaMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/EnigmaMachine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9dc47b94283b1b446b8a288d5ca6635326cad158 [INFO] sha for GitHub repo atsushi130/EnigmaMachine: 9dc47b94283b1b446b8a288d5ca6635326cad158 [INFO] validating manifest of atsushi130/EnigmaMachine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atsushi130/EnigmaMachine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atsushi130/EnigmaMachine [INFO] finished frobbing atsushi130/EnigmaMachine [INFO] frobbed toml for atsushi130/EnigmaMachine written to work/ex/clippy-test-run/sources/stable/gh/atsushi130/EnigmaMachine/Cargo.toml [INFO] started frobbing atsushi130/EnigmaMachine [INFO] finished frobbing atsushi130/EnigmaMachine [INFO] frobbed toml for atsushi130/EnigmaMachine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/EnigmaMachine/Cargo.toml [INFO] crate atsushi130/EnigmaMachine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atsushi130/EnigmaMachine against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/EnigmaMachine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44fe95ee1d338e251eee38f2f3f35c972c0ef1197ff0d6ff2b9412af5956dcd5 [INFO] running `"docker" "start" "-a" "44fe95ee1d338e251eee38f2f3f35c972c0ef1197ff0d6ff2b9412af5956dcd5"` [INFO] [stderr] Checking enigma_machine v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/enigma.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/substitution_table.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/enigma.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/substitution_table.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/enigma.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/plugboard.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn encrypt(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/enigma_machine/router.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/enigma_machine/router.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 78 | | true => Digit::Up, [INFO] [stderr] 79 | | false => Digit::NoChange [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn encrypt_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn encrypt_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/reflector.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/enigma.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/plugboard.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn encrypt(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/enigma_machine/router.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/enigma_machine/router.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 78 | | true => Digit::Up, [INFO] [stderr] 79 | | false => Digit::NoChange [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn encrypt_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn encrypt_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/reflector.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/enigma.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/substitution_table.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/enigma.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enigma_machine/substitution_table.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/enigma.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/plugboard.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/enigma.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/router_manager.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/enigma_machine/plugboard.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn encrypt(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/enigma_machine/router.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/enigma_machine/router.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 78 | | true => Digit::Up, [INFO] [stderr] 79 | | false => Digit::NoChange [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn encrypt_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn encrypt_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/reflector.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | fn encrypt(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/enigma_machine/router.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/enigma_machine/router.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 78 | | true => Digit::Up, [INFO] [stderr] 79 | | false => Digit::NoChange [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:11:51 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn encrypt_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/router_manager.rs:21:53 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn encrypt_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/reflector.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enigma_machine/plugboard.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "44fe95ee1d338e251eee38f2f3f35c972c0ef1197ff0d6ff2b9412af5956dcd5"` [INFO] running `"docker" "rm" "-f" "44fe95ee1d338e251eee38f2f3f35c972c0ef1197ff0d6ff2b9412af5956dcd5"` [INFO] [stdout] 44fe95ee1d338e251eee38f2f3f35c972c0ef1197ff0d6ff2b9412af5956dcd5