[INFO] updating cached repository atsushi130/Cryptor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atsushi130/Cryptor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/Cryptor" "work/ex/clippy-test-run/sources/stable/gh/atsushi130/Cryptor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atsushi130/Cryptor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/Cryptor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/Cryptor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/Cryptor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24504c3a8404df77e21006e254fe77b15660201b [INFO] sha for GitHub repo atsushi130/Cryptor: 24504c3a8404df77e21006e254fe77b15660201b [INFO] validating manifest of atsushi130/Cryptor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atsushi130/Cryptor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atsushi130/Cryptor [INFO] finished frobbing atsushi130/Cryptor [INFO] frobbed toml for atsushi130/Cryptor written to work/ex/clippy-test-run/sources/stable/gh/atsushi130/Cryptor/Cargo.toml [INFO] started frobbing atsushi130/Cryptor [INFO] finished frobbing atsushi130/Cryptor [INFO] frobbed toml for atsushi130/Cryptor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/Cryptor/Cargo.toml [INFO] crate atsushi130/Cryptor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atsushi130/Cryptor against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/Cryptor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8dd39493f8fcc045e13d8081a54a673943ef9085991b6653b1d17327da4a7315 [INFO] running `"docker" "start" "-a" "8dd39493f8fcc045e13d8081a54a673943ef9085991b6653b1d17327da4a7315"` [INFO] [stderr] Checking cryptor v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/substitution_table.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/substitution_table.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod cryptor; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod algorithm; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/enigma/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod enigma; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/base64/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod base64; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod cryptor; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod algorithm; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/enigma/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod enigma; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/base64/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod base64; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | fn crypto(&mut self, character: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | fn crypto(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 89 | | true => Digit::Up, [INFO] [stderr] 90 | | false => Digit::NoChange [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn crypto_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn crypto_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/reflector.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | fn crypto(&mut self, character: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | fn crypto(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 89 | | true => Digit::Up, [INFO] [stderr] 90 | | false => Digit::NoChange [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn crypto_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn crypto_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/reflector.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/substitution_table.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | routers: routers [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `routers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cryptor/algorithm/enigma/substitution_table.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | characters: characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod cryptor; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod algorithm; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/enigma/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod enigma; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/base64/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod base64; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod cryptor; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod algorithm; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/enigma/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod enigma; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return digit [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | IndexResult::Exist(index) => return self.substitution_table.characters[(index + self.position) % length], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[(index + self.position) % length]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return encrypt [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encrypt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | IndexResult::Exist(index) => return self.substitution_table.characters[index], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.substitution_table.characters[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cryptor/algorithm/base64/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod base64; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utility/extension/vec_extension.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> tests/cryptor_tests/algorithm/enigma/mod.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub mod enigma; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> tests/cryptor_tests/algorithm/base64/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod base64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | fn crypto(&mut self, character: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | fn crypto(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 89 | | true => Digit::Up, [INFO] [stderr] 90 | | false => Digit::NoChange [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn crypto_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn crypto_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/reflector.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `expects` [INFO] [stderr] --> tests/cryptor_tests/algorithm/enigma/router_manager.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in expects.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `expects` [INFO] [stderr] --> tests/cryptor_tests/algorithm/enigma/router_manager.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (i, ) in expects.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/enigma.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | fn crypto(&mut self, character: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | fn crypto(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | fn reverse(&self, character: &char) -> char; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.position = self.position % self.get_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position %= self.get_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn set_position(&mut self, position: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cryptor/algorithm/enigma/router.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self.position == self.substitution_table.characters.len() { [INFO] [stderr] 89 | | true => Digit::Up, [INFO] [stderr] 90 | | false => Digit::NoChange [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.position == self.substitution_table.characters.len() { Digit::Up } else { Digit::NoChange }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn crypto_to_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/router_manager.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn crypto_from_reflector(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/reflector.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn reflect(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn input(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cryptor/algorithm/enigma/plugboard.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn output(&self, character: &char) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "8dd39493f8fcc045e13d8081a54a673943ef9085991b6653b1d17327da4a7315"` [INFO] running `"docker" "rm" "-f" "8dd39493f8fcc045e13d8081a54a673943ef9085991b6653b1d17327da4a7315"` [INFO] [stdout] 8dd39493f8fcc045e13d8081a54a673943ef9085991b6653b1d17327da4a7315