[INFO] updating cached repository atsiporu/braces [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atsiporu/braces [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atsiporu/braces" "work/ex/clippy-test-run/sources/stable/gh/atsiporu/braces"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atsiporu/braces'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atsiporu/braces" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsiporu/braces"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsiporu/braces'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 266de26eb11a95383e4d4482c87ae2c736c6b586 [INFO] sha for GitHub repo atsiporu/braces: 266de26eb11a95383e4d4482c87ae2c736c6b586 [INFO] validating manifest of atsiporu/braces on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atsiporu/braces on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atsiporu/braces [INFO] finished frobbing atsiporu/braces [INFO] frobbed toml for atsiporu/braces written to work/ex/clippy-test-run/sources/stable/gh/atsiporu/braces/Cargo.toml [INFO] started frobbing atsiporu/braces [INFO] finished frobbing atsiporu/braces [INFO] frobbed toml for atsiporu/braces written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsiporu/braces/Cargo.toml [INFO] crate atsiporu/braces has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atsiporu/braces against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsiporu/braces:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fc348552e33248869cf4fd9dfaab0f2219744299d8c4b724ff71cecb84e60dc [INFO] running `"docker" "start" "-a" "2fc348552e33248869cf4fd9dfaab0f2219744299d8c4b724ff71cecb84e60dc"` [INFO] [stderr] Checking braces v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / return find( [INFO] [stderr] 32 | | State::Pair(0, 0), [INFO] [stderr] 33 | | v, 0, [INFO] [stderr] 34 | | 0, [INFO] [stderr] 35 | | ).1; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | find( [INFO] [stderr] 32 | State::Pair(0, 0), [INFO] [stderr] 33 | v, 0, [INFO] [stderr] 34 | 0, [INFO] [stderr] 35 | ).1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | (State::Pair(oi, idx), std::cmp::max((idx-oi+1), largest)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / return find( [INFO] [stderr] 32 | | State::Pair(0, 0), [INFO] [stderr] 33 | | v, 0, [INFO] [stderr] 34 | | 0, [INFO] [stderr] 35 | | ).1; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | find( [INFO] [stderr] 32 | State::Pair(0, 0), [INFO] [stderr] 33 | v, 0, [INFO] [stderr] 34 | 0, [INFO] [stderr] 35 | ).1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | (State::Pair(oi, idx), std::cmp::max((idx-oi+1), largest)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "2fc348552e33248869cf4fd9dfaab0f2219744299d8c4b724ff71cecb84e60dc"` [INFO] running `"docker" "rm" "-f" "2fc348552e33248869cf4fd9dfaab0f2219744299d8c4b724ff71cecb84e60dc"` [INFO] [stdout] 2fc348552e33248869cf4fd9dfaab0f2219744299d8c4b724ff71cecb84e60dc