[INFO] updating cached repository atidix/rust-cflow
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/atidix/rust-cflow
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/atidix/rust-cflow" "work/ex/clippy-test-run/sources/stable/gh/atidix/rust-cflow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atidix/rust-cflow'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/atidix/rust-cflow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atidix/rust-cflow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atidix/rust-cflow'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9700916613058cae2c244af31c9d9ea5f4b2f4d8
[INFO] sha for GitHub repo atidix/rust-cflow: 9700916613058cae2c244af31c9d9ea5f4b2f4d8
[INFO] validating manifest of atidix/rust-cflow on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of atidix/rust-cflow on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing atidix/rust-cflow
[INFO] finished frobbing atidix/rust-cflow
[INFO] frobbed toml for atidix/rust-cflow written to work/ex/clippy-test-run/sources/stable/gh/atidix/rust-cflow/Cargo.toml
[INFO] started frobbing atidix/rust-cflow
[INFO] finished frobbing atidix/rust-cflow
[INFO] frobbed toml for atidix/rust-cflow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atidix/rust-cflow/Cargo.toml
[INFO] crate atidix/rust-cflow has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting atidix/rust-cflow against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atidix/rust-cflow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8de68dfb5260950285b3de8ba254b0e91c6acdc0b5ac2a8968abb5516bcd97cf
[INFO] running `"docker" "start" "-a" "8de68dfb5260950285b3de8ba254b0e91c6acdc0b5ac2a8968abb5516bcd97cf"`
[INFO] [stderr]     Checking control_flow v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/carol.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/carol.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fib.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     return match i {
[INFO] [stderr] 14 | |         0 => i,
[INFO] [stderr] 15 | |         1 => i,
[INFO] [stderr] 16 | |         _ => fib(i-1) + fib(i-2),
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |     match i {
[INFO] [stderr] 14 |         0 => i,
[INFO] [stderr] 15 |         1 => i,
[INFO] [stderr] 16 |         _ => fib(i-1) + fib(i-2),
[INFO] [stderr] 17 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fib.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     return match i {
[INFO] [stderr] 14 | |         0 => i,
[INFO] [stderr] 15 | |         1 => i,
[INFO] [stderr] 16 | |         _ => fib(i-1) + fib(i-2),
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 13 |     match i {
[INFO] [stderr] 14 |         0 => i,
[INFO] [stderr] 15 |         1 => i,
[INFO] [stderr] 16 |         _ => fib(i-1) + fib(i-2),
[INFO] [stderr] 17 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/carol.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             j = j - 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `j -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     match MAX_CHOICE.cmp(&choice) {
[INFO] [stderr] 40 | |         Ordering::Less => continue,
[INFO] [stderr] 41 | |         _ => {},
[INFO] [stderr] 42 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Ordering::Less = MAX_CHOICE.cmp(&choice) { continue }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/carol.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             j = j - 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `j -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     match MAX_CHOICE.cmp(&choice) {
[INFO] [stderr] 40 | |         Ordering::Less => continue,
[INFO] [stderr] 41 | |         _ => {},
[INFO] [stderr] 42 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Ordering::Less = MAX_CHOICE.cmp(&choice) { continue }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.58s
[INFO] running `"docker" "inspect" "8de68dfb5260950285b3de8ba254b0e91c6acdc0b5ac2a8968abb5516bcd97cf"`
[INFO] running `"docker" "rm" "-f" "8de68dfb5260950285b3de8ba254b0e91c6acdc0b5ac2a8968abb5516bcd97cf"`
[INFO] [stdout] 8de68dfb5260950285b3de8ba254b0e91c6acdc0b5ac2a8968abb5516bcd97cf