[INFO] updating cached repository asmoaesl/ox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asmoaesl/ox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asmoaesl/ox" "work/ex/clippy-test-run/sources/stable/gh/asmoaesl/ox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asmoaesl/ox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asmoaesl/ox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/ox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/ox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 15c26b0eac8c3991421bded6e853e90fd06a9640 [INFO] sha for GitHub repo asmoaesl/ox: 15c26b0eac8c3991421bded6e853e90fd06a9640 [INFO] validating manifest of asmoaesl/ox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asmoaesl/ox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asmoaesl/ox [INFO] finished frobbing asmoaesl/ox [INFO] frobbed toml for asmoaesl/ox written to work/ex/clippy-test-run/sources/stable/gh/asmoaesl/ox/Cargo.toml [INFO] started frobbing asmoaesl/ox [INFO] finished frobbing asmoaesl/ox [INFO] frobbed toml for asmoaesl/ox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/ox/Cargo.toml [INFO] crate asmoaesl/ox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asmoaesl/ox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/ox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88a3b8b89ced77843227a4622e9c11e93d43c662eb8418f323aab1f249de2dfc [INFO] running `"docker" "start" "-a" "88a3b8b89ced77843227a4622e9c11e93d43c662eb8418f323aab1f249de2dfc"` [INFO] [stderr] Checking smallvec v0.6.4 [INFO] [stderr] Checking peek-nth v0.2.0 [INFO] [stderr] Checking oxc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:64:109 [INFO] [stderr] | [INFO] [stderr] 64 | return Program::Func(id.to_owned(), statements); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Program::Func(id.to_owned(), statements)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:135:51 [INFO] [stderr] | [INFO] [stderr] 135 | Some(Token::Symbol(Symbol::Semicolon)) => return statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:305:56 [INFO] [stderr] | [INFO] [stderr] 305 | Some(Token::Symbol(Symbol::RParen)) => return expr, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | return Expr::UnaryOp(*op, Box::new(factor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::UnaryOp(*op, Box::new(factor))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:313:38 [INFO] [stderr] | [INFO] [stderr] 313 | Some(Token::Integer(num)) => return Expr::Const(*num), // factor = int [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::Const(*num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:314:32 [INFO] [stderr] | [INFO] [stderr] 314 | Some(Token::Id(id)) => return Expr::Var(id.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::Var(id.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | return generated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return generated_expr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generated_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:64:109 [INFO] [stderr] | [INFO] [stderr] 64 | return Program::Func(id.to_owned(), statements); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Program::Func(id.to_owned(), statements)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:135:51 [INFO] [stderr] | [INFO] [stderr] 135 | Some(Token::Symbol(Symbol::Semicolon)) => return statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:305:56 [INFO] [stderr] | [INFO] [stderr] 305 | Some(Token::Symbol(Symbol::RParen)) => return expr, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | return Expr::UnaryOp(*op, Box::new(factor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::UnaryOp(*op, Box::new(factor))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:313:38 [INFO] [stderr] | [INFO] [stderr] 313 | Some(Token::Integer(num)) => return Expr::Const(*num), // factor = int [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::Const(*num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:314:32 [INFO] [stderr] | [INFO] [stderr] 314 | Some(Token::Id(id)) => return Expr::Var(id.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expr::Var(id.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | return generated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | return generated_expr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `generated_expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn is_unary(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn is_bitwise(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn is_assignment(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/scanner.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn lex(source: &str) -> Vec { [INFO] [stderr] 105 | | let mut tokens = Vec::::new(); [INFO] [stderr] 106 | | [INFO] [stderr] 107 | | let chars: Vec = source.chars().collect(); [INFO] [stderr] ... | [INFO] [stderr] 252 | | tokens [INFO] [stderr] 253 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn is_unary(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn is_bitwise(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/scanner.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn is_assignment(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/scanner.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn lex(source: &str) -> Vec { [INFO] [stderr] 105 | | let mut tokens = Vec::::new(); [INFO] [stderr] 106 | | [INFO] [stderr] 107 | | let chars: Vec = source.chars().collect(); [INFO] [stderr] ... | [INFO] [stderr] 252 | | tokens [INFO] [stderr] 253 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.92s [INFO] running `"docker" "inspect" "88a3b8b89ced77843227a4622e9c11e93d43c662eb8418f323aab1f249de2dfc"` [INFO] running `"docker" "rm" "-f" "88a3b8b89ced77843227a4622e9c11e93d43c662eb8418f323aab1f249de2dfc"` [INFO] [stdout] 88a3b8b89ced77843227a4622e9c11e93d43c662eb8418f323aab1f249de2dfc