[INFO] updating cached repository aslpavel/ukanren-rs-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aslpavel/ukanren-rs-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aslpavel/ukanren-rs-example" "work/ex/clippy-test-run/sources/stable/gh/aslpavel/ukanren-rs-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aslpavel/ukanren-rs-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aslpavel/ukanren-rs-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslpavel/ukanren-rs-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslpavel/ukanren-rs-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ea4ce91bfc625d5d13dccc2baec3e1c0f501869 [INFO] sha for GitHub repo aslpavel/ukanren-rs-example: 5ea4ce91bfc625d5d13dccc2baec3e1c0f501869 [INFO] validating manifest of aslpavel/ukanren-rs-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aslpavel/ukanren-rs-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aslpavel/ukanren-rs-example [INFO] finished frobbing aslpavel/ukanren-rs-example [INFO] frobbed toml for aslpavel/ukanren-rs-example written to work/ex/clippy-test-run/sources/stable/gh/aslpavel/ukanren-rs-example/Cargo.toml [INFO] started frobbing aslpavel/ukanren-rs-example [INFO] finished frobbing aslpavel/ukanren-rs-example [INFO] frobbed toml for aslpavel/ukanren-rs-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslpavel/ukanren-rs-example/Cargo.toml [INFO] crate aslpavel/ukanren-rs-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aslpavel/ukanren-rs-example against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslpavel/ukanren-rs-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f08957cbe29b4f81e1b6fcb07043426b3890ce47fe13e72c7be5e1c1c0acd18f [INFO] running `"docker" "start" "-a" "f08957cbe29b4f81e1b6fcb07043426b3890ce47fe13e72c7be5e1c1c0acd18f"` [INFO] [stderr] Checking uknaren v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.as_ref() { [INFO] [stderr] 33 | | &ValInner::Int(int) => write!(f, "{}", int), [INFO] [stderr] 34 | | &ValInner::Str(ref string) => write!(f, "\"{}\"", string), [INFO] [stderr] 35 | | &ValInner::Var(index) => write!(f, "_{}", index.0), [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.as_ref() { [INFO] [stderr] 33 | ValInner::Int(int) => write!(f, "{}", int), [INFO] [stderr] 34 | ValInner::Str(ref string) => write!(f, "\"{}\"", string), [INFO] [stderr] 35 | ValInner::Var(index) => write!(f, "_{}", index.0), [INFO] [stderr] 36 | ValInner::Nil => write!(f, "Nil"), [INFO] [stderr] 37 | ValInner::Pair(..) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:65 [INFO] [stderr] | [INFO] [stderr] 41 | while let &ValInner::Pair(ref head, ref tail) = rest.clone().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | while let ValInner::Pair(ref head, ref tail) = *rest.clone().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / match rest.as_ref() { [INFO] [stderr] 51 | | &ValInner::Nil => (), [INFO] [stderr] 52 | | _ => { [INFO] [stderr] 53 | | write!(f, " . ")?; [INFO] [stderr] 54 | | rest.fmt(f)?; [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *rest.as_ref() { [INFO] [stderr] 51 | ValInner::Nil => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | Rc::new(|state| Stream::unit(state)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Stream::unit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.as_ref() { [INFO] [stderr] 33 | | &ValInner::Int(int) => write!(f, "{}", int), [INFO] [stderr] 34 | | &ValInner::Str(ref string) => write!(f, "\"{}\"", string), [INFO] [stderr] 35 | | &ValInner::Var(index) => write!(f, "_{}", index.0), [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.as_ref() { [INFO] [stderr] 33 | ValInner::Int(int) => write!(f, "{}", int), [INFO] [stderr] 34 | ValInner::Str(ref string) => write!(f, "\"{}\"", string), [INFO] [stderr] 35 | ValInner::Var(index) => write!(f, "_{}", index.0), [INFO] [stderr] 36 | ValInner::Nil => write!(f, "Nil"), [INFO] [stderr] 37 | ValInner::Pair(..) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:65 [INFO] [stderr] | [INFO] [stderr] 41 | while let &ValInner::Pair(ref head, ref tail) = rest.clone().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | while let ValInner::Pair(ref head, ref tail) = *rest.clone().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / match rest.as_ref() { [INFO] [stderr] 51 | | &ValInner::Nil => (), [INFO] [stderr] 52 | | _ => { [INFO] [stderr] 53 | | write!(f, " . ")?; [INFO] [stderr] 54 | | rest.fmt(f)?; [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *rest.as_ref() { [INFO] [stderr] 51 | ValInner::Nil => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | Rc::new(|state| Stream::unit(state)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Stream::unit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:560:24 [INFO] [stderr] | [INFO] [stderr] 560 | let mut iter = run(einstein_problem).into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `run(einstein_problem)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "f08957cbe29b4f81e1b6fcb07043426b3890ce47fe13e72c7be5e1c1c0acd18f"` [INFO] running `"docker" "rm" "-f" "f08957cbe29b4f81e1b6fcb07043426b3890ce47fe13e72c7be5e1c1c0acd18f"` [INFO] [stdout] f08957cbe29b4f81e1b6fcb07043426b3890ce47fe13e72c7be5e1c1c0acd18f