[INFO] updating cached repository ashtneoi/shtoml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ashtneoi/shtoml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ashtneoi/shtoml" "work/ex/clippy-test-run/sources/stable/gh/ashtneoi/shtoml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ashtneoi/shtoml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ashtneoi/shtoml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/shtoml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/shtoml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d03168cfeaa667eee458cd8ff21e0c47da0569c3 [INFO] sha for GitHub repo ashtneoi/shtoml: d03168cfeaa667eee458cd8ff21e0c47da0569c3 [INFO] validating manifest of ashtneoi/shtoml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ashtneoi/shtoml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ashtneoi/shtoml [INFO] finished frobbing ashtneoi/shtoml [INFO] frobbed toml for ashtneoi/shtoml written to work/ex/clippy-test-run/sources/stable/gh/ashtneoi/shtoml/Cargo.toml [INFO] started frobbing ashtneoi/shtoml [INFO] finished frobbing ashtneoi/shtoml [INFO] frobbed toml for ashtneoi/shtoml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/shtoml/Cargo.toml [INFO] crate ashtneoi/shtoml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ashtneoi/shtoml against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/shtoml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1e60fff03cdeac196af449170e32fe9c1bfff8604f410dd5671a8c1fe9d4d79 [INFO] running `"docker" "start" "-a" "b1e60fff03cdeac196af449170e32fe9c1bfff8604f410dd5671a8c1fe9d4d79"` [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking shtoml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | let t = match v { [INFO] [stderr] | _________________^ [INFO] [stderr] 78 | | &Value::Table(ref x) => x, [INFO] [stderr] 79 | | _ => { [INFO] [stderr] 80 | | eprintln!("error: value is not a table"); // TODO: better error [INFO] [stderr] 81 | | exit(1); [INFO] [stderr] 82 | | }, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let t = match *v { [INFO] [stderr] 78 | Value::Table(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | let t = match v { [INFO] [stderr] | _________________^ [INFO] [stderr] 78 | | &Value::Table(ref x) => x, [INFO] [stderr] 79 | | _ => { [INFO] [stderr] 80 | | eprintln!("error: value is not a table"); // TODO: better error [INFO] [stderr] 81 | | exit(1); [INFO] [stderr] 82 | | }, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let t = match *v { [INFO] [stderr] 78 | Value::Table(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.44s [INFO] running `"docker" "inspect" "b1e60fff03cdeac196af449170e32fe9c1bfff8604f410dd5671a8c1fe9d4d79"` [INFO] running `"docker" "rm" "-f" "b1e60fff03cdeac196af449170e32fe9c1bfff8604f410dd5671a8c1fe9d4d79"` [INFO] [stdout] b1e60fff03cdeac196af449170e32fe9c1bfff8604f410dd5671a8c1fe9d4d79