[INFO] updating cached repository ashtneoi/mint [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ashtneoi/mint [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ashtneoi/mint" "work/ex/clippy-test-run/sources/stable/gh/ashtneoi/mint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ashtneoi/mint'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ashtneoi/mint" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/mint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/mint'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffdc686d24f332897a8ba1b65920d6426f77491a [INFO] sha for GitHub repo ashtneoi/mint: ffdc686d24f332897a8ba1b65920d6426f77491a [INFO] validating manifest of ashtneoi/mint on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ashtneoi/mint on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ashtneoi/mint [INFO] finished frobbing ashtneoi/mint [INFO] frobbed toml for ashtneoi/mint written to work/ex/clippy-test-run/sources/stable/gh/ashtneoi/mint/Cargo.toml [INFO] started frobbing ashtneoi/mint [INFO] finished frobbing ashtneoi/mint [INFO] frobbed toml for ashtneoi/mint written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/mint/Cargo.toml [INFO] crate ashtneoi/mint has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ashtneoi/mint against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashtneoi/mint:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe7f8e917672f447c2b588e5e87fec8bbce9d01131656833ec8c3138395e663e [INFO] running `"docker" "start" "-a" "fe7f8e917672f447c2b588e5e87fec8bbce9d01131656833ec8c3138395e663e"` [INFO] [stderr] Checking mint v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn do_file(tmpl_name: &str, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 52 | pub fn do_file(tmpl_name: &str, environ: &HashMap<&str, &str, S>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:52:43 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn do_file(tmpl_name: &str, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 52 | pub fn do_file(tmpl_name: &str, environ: &HashMap<&str, &str, S>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:63:48 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str, S>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:63:48 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str, S>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or( [INFO] [stderr] | ______________________^ [INFO] [stderr] 83 | | format!("{}: Missing \"{}\"", row, CLOSE_PAT) [INFO] [stderr] 84 | | )?; [INFO] [stderr] | |_____________________^ help: try this: `ok_or_else(|| format!("{}: Missing \"{}\"", row, CLOSE_PAT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or( [INFO] [stderr] | ______________________^ [INFO] [stderr] 83 | | format!("{}: Missing \"{}\"", row, CLOSE_PAT) [INFO] [stderr] 84 | | )?; [INFO] [stderr] | |_____________________^ help: try this: `ok_or_else(|| format!("{}: Missing \"{}\"", row, CLOSE_PAT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | if name.starts_with("!") || name.contains("}}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | if name.starts_with("!") || name.contains("}}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or( [INFO] [stderr] | ______________________^ [INFO] [stderr] 83 | | format!("{}: Missing \"{}\"", row, CLOSE_PAT) [INFO] [stderr] 84 | | )?; [INFO] [stderr] | |_____________________^ help: try this: `ok_or_else(|| format!("{}: Missing \"{}\"", row, CLOSE_PAT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn do_lines(lines: &Vec, environ: &HashMap<&str, &str>) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | if name.starts_with("!") || name.contains("}}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or( [INFO] [stderr] | ______________________^ [INFO] [stderr] 83 | | format!("{}: Missing \"{}\"", row, CLOSE_PAT) [INFO] [stderr] 84 | | )?; [INFO] [stderr] | |_____________________^ help: try this: `ok_or_else(|| format!("{}: Missing \"{}\"", row, CLOSE_PAT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | if name.starts_with("!") || name.contains("}}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "fe7f8e917672f447c2b588e5e87fec8bbce9d01131656833ec8c3138395e663e"` [INFO] running `"docker" "rm" "-f" "fe7f8e917672f447c2b588e5e87fec8bbce9d01131656833ec8c3138395e663e"` [INFO] [stdout] fe7f8e917672f447c2b588e5e87fec8bbce9d01131656833ec8c3138395e663e