[INFO] updating cached repository ashfordneil/2048-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ashfordneil/2048-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ashfordneil/2048-rust" "work/ex/clippy-test-run/sources/stable/gh/ashfordneil/2048-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ashfordneil/2048-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ashfordneil/2048-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/2048-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/2048-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4346ff7de1ea7d8622510199de6e8d4992d3350f
[INFO] sha for GitHub repo ashfordneil/2048-rust: 4346ff7de1ea7d8622510199de6e8d4992d3350f
[INFO] validating manifest of ashfordneil/2048-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ashfordneil/2048-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ashfordneil/2048-rust
[INFO] finished frobbing ashfordneil/2048-rust
[INFO] frobbed toml for ashfordneil/2048-rust written to work/ex/clippy-test-run/sources/stable/gh/ashfordneil/2048-rust/Cargo.toml
[INFO] started frobbing ashfordneil/2048-rust
[INFO] finished frobbing ashfordneil/2048-rust
[INFO] frobbed toml for ashfordneil/2048-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/2048-rust/Cargo.toml
[INFO] crate ashfordneil/2048-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ashfordneil/2048-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/2048-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 435eeaa876734f2c3eb575a68bfc092e39510205d16ae03bb05aa115fe0329a5
[INFO] running `"docker" "start" "-a" "435eeaa876734f2c3eb575a68bfc092e39510205d16ae03bb05aa115fe0329a5"`
[INFO] [stderr]     Checking either v1.0.2
[INFO] [stderr]     Checking termion v1.1.4
[INFO] [stderr]     Checking itertools v0.5.8
[INFO] [stderr]     Checking 2048 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     Digit(Some(((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr] 71 |                                   2) as u8)));
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     Digit(Some(((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr] 71 |                                   2) as u8)));
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/board.rs:70:32
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       Digit(Some((((index / BOARD_WIDTH as usize / BOARD_WIDTH as usize %
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 71 | |                                   2) as u8))));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/board.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                 if let &Digit(None) = element {
[INFO] [stderr] 82 | |                     return true;
[INFO] [stderr] 83 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |                 if let Digit(None) = *element {
[INFO] [stderr]    |                        ^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/board.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         match x == y {
[INFO] [stderr] 105 | |             true => {
[INFO] [stderr] 106 | |                 let _ = iter.next();
[INFO] [stderr] 107 | |                 Some(Digit(Some(x + 1)))
[INFO] [stderr] 108 | |             }
[INFO] [stderr] 109 | |             false => Some(Digit(Some(x))),
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if x == y {
[INFO] [stderr] 105 |     let _ = iter.next();
[INFO] [stderr] 106 |     Some(Digit(Some(x + 1)))
[INFO] [stderr] 107 | } else { Some(Digit(Some(x))) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `row`.
[INFO] [stderr]    --> src/board.rs:132:22
[INFO] [stderr]     |
[INFO] [stderr] 132 |             for i in 0..(BOARD_WIDTH as usize) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 132 |             for <item> in row.iter_mut().take((BOARD_WIDTH as usize)) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/board.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                 if let &Digit(None) = element {
[INFO] [stderr] 82 | |                     return true;
[INFO] [stderr] 83 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |                 if let Digit(None) = *element {
[INFO] [stderr]    |                        ^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/board.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         match x == y {
[INFO] [stderr] 105 | |             true => {
[INFO] [stderr] 106 | |                 let _ = iter.next();
[INFO] [stderr] 107 | |                 Some(Digit(Some(x + 1)))
[INFO] [stderr] 108 | |             }
[INFO] [stderr] 109 | |             false => Some(Digit(Some(x))),
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if x == y {
[INFO] [stderr] 105 |     let _ = iter.next();
[INFO] [stderr] 106 |     Some(Digit(Some(x + 1)))
[INFO] [stderr] 107 | } else { Some(Digit(Some(x))) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `row`.
[INFO] [stderr]    --> src/board.rs:132:22
[INFO] [stderr]     |
[INFO] [stderr] 132 |             for i in 0..(BOARD_WIDTH as usize) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 132 |             for <item> in row.iter_mut().take((BOARD_WIDTH as usize)) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.69s
[INFO] running `"docker" "inspect" "435eeaa876734f2c3eb575a68bfc092e39510205d16ae03bb05aa115fe0329a5"`
[INFO] running `"docker" "rm" "-f" "435eeaa876734f2c3eb575a68bfc092e39510205d16ae03bb05aa115fe0329a5"`
[INFO] [stdout] 435eeaa876734f2c3eb575a68bfc092e39510205d16ae03bb05aa115fe0329a5