[INFO] updating cached repository asakasa/ext [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asakasa/ext [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asakasa/ext" "work/ex/clippy-test-run/sources/stable/gh/asakasa/ext"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asakasa/ext'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asakasa/ext" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asakasa/ext"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asakasa/ext'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2970e1c509364749d87611baeeb006acc8eab2d8 [INFO] sha for GitHub repo asakasa/ext: 2970e1c509364749d87611baeeb006acc8eab2d8 [INFO] validating manifest of asakasa/ext on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asakasa/ext on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asakasa/ext [INFO] finished frobbing asakasa/ext [INFO] frobbed toml for asakasa/ext written to work/ex/clippy-test-run/sources/stable/gh/asakasa/ext/Cargo.toml [INFO] started frobbing asakasa/ext [INFO] finished frobbing asakasa/ext [INFO] frobbed toml for asakasa/ext written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asakasa/ext/Cargo.toml [INFO] crate asakasa/ext has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asakasa/ext against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asakasa/ext:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5372a8307c555a380ee221a944a175c822bf061694a0574308305362bb025c49 [INFO] running `"docker" "start" "-a" "5372a8307c555a380ee221a944a175c822bf061694a0574308305362bb025c49"` [INFO] [stderr] Checking ext v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 65 | | if matches.is_present("delete") { [INFO] [stderr] 66 | | (Ope::Delete, "".to_string()) [INFO] [stderr] 67 | | } else { [INFO] [stderr] 68 | | (Ope::Nothing, "".to_string()) [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if matches.is_present("delete") { [INFO] [stderr] 65 | (Ope::Delete, "".to_string()) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | (Ope::Nothing, "".to_string()) [INFO] [stderr] 68 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 65 | | if matches.is_present("delete") { [INFO] [stderr] 66 | | (Ope::Delete, "".to_string()) [INFO] [stderr] 67 | | } else { [INFO] [stderr] 68 | | (Ope::Nothing, "".to_string()) [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if matches.is_present("delete") { [INFO] [stderr] 65 | (Ope::Delete, "".to_string()) [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | (Ope::Nothing, "".to_string()) [INFO] [stderr] 68 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | format!("{}", args.ext) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args.ext.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:127:20 [INFO] [stderr] | [INFO] [stderr] 127 | let dst_name = match &args.ope { [INFO] [stderr] | ____________________^ [INFO] [stderr] 128 | | &Ope::Add => add(&args), [INFO] [stderr] 129 | | &Ope::Edit => edit(&args), [INFO] [stderr] 130 | | &Ope::Delete => delete(&args), [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | let dst_name = match args.ope { [INFO] [stderr] 128 | Ope::Add => add(&args), [INFO] [stderr] 129 | Ope::Edit => edit(&args), [INFO] [stderr] 130 | Ope::Delete => delete(&args), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(OsStr::new("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | format!("{}", args.ext) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args.ext.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:127:20 [INFO] [stderr] | [INFO] [stderr] 127 | let dst_name = match &args.ope { [INFO] [stderr] | ____________________^ [INFO] [stderr] 128 | | &Ope::Add => add(&args), [INFO] [stderr] 129 | | &Ope::Edit => edit(&args), [INFO] [stderr] 130 | | &Ope::Delete => delete(&args), [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | let dst_name = match args.ope { [INFO] [stderr] 128 | Ope::Add => add(&args), [INFO] [stderr] 129 | Ope::Edit => edit(&args), [INFO] [stderr] 130 | Ope::Delete => delete(&args), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `"docker" "inspect" "5372a8307c555a380ee221a944a175c822bf061694a0574308305362bb025c49"` [INFO] running `"docker" "rm" "-f" "5372a8307c555a380ee221a944a175c822bf061694a0574308305362bb025c49"` [INFO] [stdout] 5372a8307c555a380ee221a944a175c822bf061694a0574308305362bb025c49