[INFO] updating cached repository arthurmco/nececity [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/arthurmco/nececity [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/arthurmco/nececity" "work/ex/clippy-test-run/sources/stable/gh/arthurmco/nececity"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/arthurmco/nececity'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/arthurmco/nececity" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmco/nececity"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmco/nececity'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d856ad90a99b25e8192947d8392b9d7e1a774335 [INFO] sha for GitHub repo arthurmco/nececity: d856ad90a99b25e8192947d8392b9d7e1a774335 [INFO] validating manifest of arthurmco/nececity on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arthurmco/nececity on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arthurmco/nececity [INFO] finished frobbing arthurmco/nececity [INFO] frobbed toml for arthurmco/nececity written to work/ex/clippy-test-run/sources/stable/gh/arthurmco/nececity/Cargo.toml [INFO] started frobbing arthurmco/nececity [INFO] finished frobbing arthurmco/nececity [INFO] frobbed toml for arthurmco/nececity written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmco/nececity/Cargo.toml [INFO] crate arthurmco/nececity has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arthurmco/nececity against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/arthurmco/nececity:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee2cacddc2e4b7ea7c061da51e127e0e836c6f0e001acef4c8906e5e3b8cd2bf [INFO] running `"docker" "start" "-a" "ee2cacddc2e4b7ea7c061da51e127e0e836c6f0e001acef4c8906e5e3b8cd2bf"` [INFO] [stderr] Checking nececity v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `Health` [INFO] [stderr] --> src/logic/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Health, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Technology` [INFO] [stderr] --> src/logic/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Technology, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Construction` [INFO] [stderr] --> src/logic/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Construction, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Driving` [INFO] [stderr] --> src/logic/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Driving, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Homecare` [INFO] [stderr] --> src/logic/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Homecare, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `None` [INFO] [stderr] --> src/logic/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | None, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Basic` [INFO] [stderr] --> src/logic/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | Basic, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Technical` [INFO] [stderr] --> src/logic/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Technical, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Advanced` [INFO] [stderr] --> src/logic/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | Advanced, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Experience` [INFO] [stderr] --> src/logic/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | Experience(WorkingArea, i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Male` [INFO] [stderr] --> src/logic/person.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Male, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Female` [INFO] [stderr] --> src/logic/person.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Female, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PersonAttributes` [INFO] [stderr] --> src/logic/person.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | struct PersonAttributes { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Person` [INFO] [stderr] --> src/logic/person.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | pub struct Person { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/logic/person.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / fn new( [INFO] [stderr] 61 | | name: &str, [INFO] [stderr] 62 | | gender: Gender, [INFO] [stderr] 63 | | wished_area: WorkingArea, [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_with_age` [INFO] [stderr] --> src/logic/person.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / fn new_with_age( [INFO] [stderr] 80 | | name: &str, [INFO] [stderr] 81 | | gender: Gender, [INFO] [stderr] 82 | | wished_area: WorkingArea, [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_alive` [INFO] [stderr] --> src/logic/person.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | fn is_alive(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iterate` [INFO] [stderr] --> src/logic/person.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | fn iterate(&mut self, tick: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_LIFE_YEARS` [INFO] [stderr] --> src/logic/person.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | const MAX_LIFE_YEARS: u64 = 110; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tick_to_day_number` [INFO] [stderr] --> src/logic/person.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | fn tick_to_day_number(tick: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day_to_tick_number` [INFO] [stderr] --> src/logic/person.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | fn day_to_tick_number(day: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/logic/person.rs:124:30 [INFO] [stderr] | [INFO] [stderr] 124 | >= (50.0 + (((health as f64) / 255.0) * (MAX_LIFE_YEARS - 50) as f64)) as u64 * 365 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(health)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Health` [INFO] [stderr] --> src/logic/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Health, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Technology` [INFO] [stderr] --> src/logic/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Technology, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Driving` [INFO] [stderr] --> src/logic/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Driving, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Homecare` [INFO] [stderr] --> src/logic/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Homecare, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Basic` [INFO] [stderr] --> src/logic/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | Basic, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Technical` [INFO] [stderr] --> src/logic/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Technical, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Experience` [INFO] [stderr] --> src/logic/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | Experience(WorkingArea, i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `intelligence` [INFO] [stderr] --> src/logic/person.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | intelligence: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `beauty` [INFO] [stderr] --> src/logic/person.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | beauty: u8, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `speak` [INFO] [stderr] --> src/logic/person.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | speak: u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/logic/person.rs:124:30 [INFO] [stderr] | [INFO] [stderr] 124 | >= (50.0 + (((health as f64) / 255.0) * (MAX_LIFE_YEARS - 50) as f64)) as u64 * 365 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(health)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | for i in 0..(day_to_tick_number(1) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:231:18 [INFO] [stderr] | [INFO] [stderr] 231 | for i in 0..(day_to_tick_number(30) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(30)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:253:18 [INFO] [stderr] | [INFO] [stderr] 253 | for i in 0..(day_to_tick_number(365) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:274:18 [INFO] [stderr] | [INFO] [stderr] 274 | for i in 0..(day_to_tick_number(365 * 110) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 110)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:295:18 [INFO] [stderr] | [INFO] [stderr] 295 | for i in 0..(day_to_tick_number(365 * 50) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 50)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:317:18 [INFO] [stderr] | [INFO] [stderr] 317 | for i in 0..(day_to_tick_number(365 * 55) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 55)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:339:18 [INFO] [stderr] | [INFO] [stderr] 339 | for i in 0..(day_to_tick_number(365 * 70) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 70)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:361:18 [INFO] [stderr] | [INFO] [stderr] 361 | for i in 0..(day_to_tick_number(365 * 95) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 95)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/logic/person.rs:383:18 [INFO] [stderr] | [INFO] [stderr] 383 | for i in 0..(day_to_tick_number(365 * 95) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=day_to_tick_number(365 * 95)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "ee2cacddc2e4b7ea7c061da51e127e0e836c6f0e001acef4c8906e5e3b8cd2bf"` [INFO] running `"docker" "rm" "-f" "ee2cacddc2e4b7ea7c061da51e127e0e836c6f0e001acef4c8906e5e3b8cd2bf"` [INFO] [stdout] ee2cacddc2e4b7ea7c061da51e127e0e836c6f0e001acef4c8906e5e3b8cd2bf