[INFO] updating cached repository archer884/robco [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/archer884/robco [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/archer884/robco" "work/ex/clippy-test-run/sources/stable/gh/archer884/robco"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/archer884/robco'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/archer884/robco" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/robco"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/robco'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2a1e28ad3fe867bcac50b6b1dc920cbcee2b0845 [INFO] sha for GitHub repo archer884/robco: 2a1e28ad3fe867bcac50b6b1dc920cbcee2b0845 [INFO] validating manifest of archer884/robco on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of archer884/robco on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing archer884/robco [INFO] finished frobbing archer884/robco [INFO] frobbed toml for archer884/robco written to work/ex/clippy-test-run/sources/stable/gh/archer884/robco/Cargo.toml [INFO] started frobbing archer884/robco [INFO] finished frobbing archer884/robco [INFO] frobbed toml for archer884/robco written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/robco/Cargo.toml [INFO] crate archer884/robco has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting archer884/robco against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/robco:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b64daaf9a1c32f5a03a8d37c93231b9239dcd991dfb6353c2d7c6d3719115242 [INFO] running `"docker" "start" "-a" "b64daaf9a1c32f5a03a8d37c93231b9239dcd991dfb6353c2d7c6d3719115242"` [INFO] [stderr] Checking robco v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return handle.lock().lines() [INFO] [stderr] 62 | | .map(|line| line [INFO] [stderr] 63 | | .map_err(|_| Failure::Input) [INFO] [stderr] 64 | | .and_then(|line| line.parse().map_err(|_| Failure::Validation)) [INFO] [stderr] 65 | | ).collect(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | handle.lock().lines() [INFO] [stderr] 62 | .map(|line| line [INFO] [stderr] 63 | .map_err(|_| Failure::Input) [INFO] [stderr] 64 | .and_then(|line| line.parse().map_err(|_| Failure::Validation)) [INFO] [stderr] 65 | ).collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/password.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Password::Candidate(ref word) [INFO] [stderr] 20 | | | &Password::Witness(ref word, _) => word [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Password::Candidate(ref word) [INFO] [stderr] 20 | | Password::Witness(ref word, _) => word [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/password.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Password::Candidate(_) => None, [INFO] [stderr] 27 | | &Password::Witness(_, distance) => Some(distance), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Password::Candidate(_) => None, [INFO] [stderr] 27 | Password::Witness(_, distance) => Some(distance), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return handle.lock().lines() [INFO] [stderr] 62 | | .map(|line| line [INFO] [stderr] 63 | | .map_err(|_| Failure::Input) [INFO] [stderr] 64 | | .and_then(|line| line.parse().map_err(|_| Failure::Validation)) [INFO] [stderr] 65 | | ).collect(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | handle.lock().lines() [INFO] [stderr] 62 | .map(|line| line [INFO] [stderr] 63 | .map_err(|_| Failure::Input) [INFO] [stderr] 64 | .and_then(|line| line.parse().map_err(|_| Failure::Validation)) [INFO] [stderr] 65 | ).collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/password.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Password::Candidate(ref word) [INFO] [stderr] 20 | | | &Password::Witness(ref word, _) => word [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Password::Candidate(ref word) [INFO] [stderr] 20 | | Password::Witness(ref word, _) => word [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/password.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Password::Candidate(_) => None, [INFO] [stderr] 27 | | &Password::Witness(_, distance) => Some(distance), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Password::Candidate(_) => None, [INFO] [stderr] 27 | Password::Witness(_, distance) => Some(distance), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.45s [INFO] running `"docker" "inspect" "b64daaf9a1c32f5a03a8d37c93231b9239dcd991dfb6353c2d7c6d3719115242"` [INFO] running `"docker" "rm" "-f" "b64daaf9a1c32f5a03a8d37c93231b9239dcd991dfb6353c2d7c6d3719115242"` [INFO] [stdout] b64daaf9a1c32f5a03a8d37c93231b9239dcd991dfb6353c2d7c6d3719115242