[INFO] updating cached repository archer884/pack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/archer884/pack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/archer884/pack" "work/ex/clippy-test-run/sources/stable/gh/archer884/pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/archer884/pack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/archer884/pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/pack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2b0829cb7530963dbb3af7ad5c2f46321674566 [INFO] sha for GitHub repo archer884/pack: a2b0829cb7530963dbb3af7ad5c2f46321674566 [INFO] validating manifest of archer884/pack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of archer884/pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing archer884/pack [INFO] finished frobbing archer884/pack [INFO] frobbed toml for archer884/pack written to work/ex/clippy-test-run/sources/stable/gh/archer884/pack/Cargo.toml [INFO] started frobbing archer884/pack [INFO] finished frobbing archer884/pack [INFO] frobbed toml for archer884/pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/pack/Cargo.toml [INFO] crate archer884/pack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting archer884/pack against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/archer884/pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b11a4f4d9c7dfec9e4bbc4f507db75fa50b5290fff72cf865834b1b906b547f [INFO] running `"docker" "start" "-a" "2b11a4f4d9c7dfec9e4bbc4f507db75fa50b5290fff72cf865834b1b906b547f"` [INFO] [stderr] Checking pack v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | chunk.iter().take(width).map(|&c| c).collect::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().take(width).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | chunk.iter().rev().take(width).map(|&c| c).collect::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().rev().take(width).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match root == root.floor() { [INFO] [stderr] 61 | | true => (root as usize, root as usize), [INFO] [stderr] 62 | | false => (2..n) [INFO] [stderr] 63 | | .filter(|&f| n % f == 0) [INFO] [stderr] ... | [INFO] [stderr] 66 | | .fold((1, n), |a,b| if diff(a) > diff(b) { b } else { a }) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if root == root.floor() { (root as usize, root as usize) } else { (2..n) [INFO] [stderr] 61 | .filter(|&f| n % f == 0) [INFO] [stderr] 62 | .map(|f| (f, n / f)) [INFO] [stderr] 63 | .take_while(|&(a,b)| a < b) [INFO] [stderr] 64 | .fold((1, n), |a,b| if diff(a) > diff(b) { b } else { a }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | match root == root.floor() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(root - root.floor()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | match root == root.floor() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | chunk.iter().take(width).map(|&c| c).collect::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().take(width).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | chunk.iter().rev().take(width).map(|&c| c).collect::() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunk.iter().rev().take(width).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / match root == root.floor() { [INFO] [stderr] 61 | | true => (root as usize, root as usize), [INFO] [stderr] 62 | | false => (2..n) [INFO] [stderr] 63 | | .filter(|&f| n % f == 0) [INFO] [stderr] ... | [INFO] [stderr] 66 | | .fold((1, n), |a,b| if diff(a) > diff(b) { b } else { a }) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if root == root.floor() { (root as usize, root as usize) } else { (2..n) [INFO] [stderr] 61 | .filter(|&f| n % f == 0) [INFO] [stderr] 62 | .map(|f| (f, n / f)) [INFO] [stderr] 63 | .take_while(|&(a,b)| a < b) [INFO] [stderr] 64 | .fold((1, n), |a,b| if diff(a) > diff(b) { b } else { a }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | match root == root.floor() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(root - root.floor()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | match root == root.floor() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2b11a4f4d9c7dfec9e4bbc4f507db75fa50b5290fff72cf865834b1b906b547f"` [INFO] running `"docker" "rm" "-f" "2b11a4f4d9c7dfec9e4bbc4f507db75fa50b5290fff72cf865834b1b906b547f"` [INFO] [stdout] 2b11a4f4d9c7dfec9e4bbc4f507db75fa50b5290fff72cf865834b1b906b547f