[INFO] updating cached repository aqulu/mode-recognizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aqulu/mode-recognizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aqulu/mode-recognizer" "work/ex/clippy-test-run/sources/stable/gh/aqulu/mode-recognizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aqulu/mode-recognizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aqulu/mode-recognizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aqulu/mode-recognizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aqulu/mode-recognizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ab8ac6838281a57e6a7d8dbd73cf2937393184f [INFO] sha for GitHub repo aqulu/mode-recognizer: 3ab8ac6838281a57e6a7d8dbd73cf2937393184f [INFO] validating manifest of aqulu/mode-recognizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aqulu/mode-recognizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aqulu/mode-recognizer [INFO] finished frobbing aqulu/mode-recognizer [INFO] frobbed toml for aqulu/mode-recognizer written to work/ex/clippy-test-run/sources/stable/gh/aqulu/mode-recognizer/Cargo.toml [INFO] started frobbing aqulu/mode-recognizer [INFO] finished frobbing aqulu/mode-recognizer [INFO] frobbed toml for aqulu/mode-recognizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aqulu/mode-recognizer/Cargo.toml [INFO] crate aqulu/mode-recognizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aqulu/mode-recognizer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aqulu/mode-recognizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 797c04711ae4fe5eacce01842b559c234b722021a52e8f7e8cee12e2d4067289 [INFO] running `"docker" "start" "-a" "797c04711ae4fe5eacce01842b559c234b722021a52e8f7e8cee12e2d4067289"` [INFO] [stderr] Checking mode_recognizer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/mode/mod.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | let mut note_iterator = note::NOTE_SCALE.into_iter().cycle().skip(position); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mode/mod.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let note = match interval { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 23 | | &Interval::WHOLE => { [INFO] [stderr] 24 | | note_iterator.next(); [INFO] [stderr] 25 | | note_iterator.next() [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | _ => note_iterator.next(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let note = match *interval { [INFO] [stderr] 23 | Interval::WHOLE => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | scale.1.iter().fold(true, |carry, note| match note { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 24 | | &Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] 25 | | _ => carry [INFO] [stderr] 26 | | }) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | scale.1.iter().fold(true, |carry, note| match *note { [INFO] [stderr] 24 | Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:24:28 [INFO] [stderr] | [INFO] [stderr] 24 | &Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(| input | x.equals(input)).is_some()` with `any(| input | x.equals(input))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:34:81 [INFO] [stderr] | [INFO] [stderr] 34 | let notes = scale.1.iter().fold(String::from(""), |carry, note: &Option| match note { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 35 | | &Some(x) => format!("{0} {1}", carry, x), [INFO] [stderr] 36 | | _ => carry [INFO] [stderr] 37 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | let notes = scale.1.iter().fold(String::from(""), |carry, note: &Option| match *note { [INFO] [stderr] 35 | Some(x) => format!("{0} {1}", carry, x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mode_recognizer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/mode/mod.rs:18:46 [INFO] [stderr] | [INFO] [stderr] 18 | let mut note_iterator = note::NOTE_SCALE.into_iter().cycle().skip(position); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mode/mod.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let note = match interval { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 23 | | &Interval::WHOLE => { [INFO] [stderr] 24 | | note_iterator.next(); [INFO] [stderr] 25 | | note_iterator.next() [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | _ => note_iterator.next(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let note = match *interval { [INFO] [stderr] 23 | Interval::WHOLE => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | scale.1.iter().fold(true, |carry, note| match note { [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 24 | | &Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] 25 | | _ => carry [INFO] [stderr] 26 | | }) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | scale.1.iter().fold(true, |carry, note| match *note { [INFO] [stderr] 24 | Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:24:28 [INFO] [stderr] | [INFO] [stderr] 24 | &Some(x) => carry && inputs.iter().find(| input | x.equals(input)).is_some(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(| input | x.equals(input)).is_some()` with `any(| input | x.equals(input))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:34:81 [INFO] [stderr] | [INFO] [stderr] 34 | let notes = scale.1.iter().fold(String::from(""), |carry, note: &Option| match note { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 35 | | &Some(x) => format!("{0} {1}", carry, x), [INFO] [stderr] 36 | | _ => carry [INFO] [stderr] 37 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | let notes = scale.1.iter().fold(String::from(""), |carry, note: &Option| match *note { [INFO] [stderr] 35 | Some(x) => format!("{0} {1}", carry, x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mode_recognizer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "797c04711ae4fe5eacce01842b559c234b722021a52e8f7e8cee12e2d4067289"` [INFO] running `"docker" "rm" "-f" "797c04711ae4fe5eacce01842b559c234b722021a52e8f7e8cee12e2d4067289"` [INFO] [stdout] 797c04711ae4fe5eacce01842b559c234b722021a52e8f7e8cee12e2d4067289