[INFO] updating cached repository apiraino/game-of-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/apiraino/game-of-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/apiraino/game-of-life" "work/ex/clippy-test-run/sources/stable/gh/apiraino/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/apiraino/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/apiraino/game-of-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/apiraino/game-of-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/apiraino/game-of-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd122d63d8c58721014758419da19311cb1e26a3 [INFO] sha for GitHub repo apiraino/game-of-life: bd122d63d8c58721014758419da19311cb1e26a3 [INFO] validating manifest of apiraino/game-of-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of apiraino/game-of-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing apiraino/game-of-life [INFO] finished frobbing apiraino/game-of-life [INFO] frobbed toml for apiraino/game-of-life written to work/ex/clippy-test-run/sources/stable/gh/apiraino/game-of-life/Cargo.toml [INFO] started frobbing apiraino/game-of-life [INFO] finished frobbing apiraino/game-of-life [INFO] frobbed toml for apiraino/game-of-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/apiraino/game-of-life/Cargo.toml [INFO] crate apiraino/game-of-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting apiraino/game-of-life against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/apiraino/game-of-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d82b4612763d20cb021f8fc93f39a682be139f7885eccbf6a1e9a1a50c3a237a [INFO] running `"docker" "start" "-a" "d82b4612763d20cb021f8fc93f39a682be139f7885eccbf6a1e9a1a50c3a237a"` [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if alive_neighbours == 3 { [INFO] [stderr] 43 | | cell_val = 1; [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if alive_neighbours == 3 { [INFO] [stderr] 42 | cell_val = 1; [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if alive_neighbours == 3 { [INFO] [stderr] 43 | | cell_val = 1; [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if alive_neighbours == 3 { [INFO] [stderr] 42 | cell_val = 1; [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `coord_y` is used to index `new_grid` [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | for coord_y in 0..MAX_Y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] warning: the loop variable `coord_y` is used to index `new_grid` [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | for coord_y in 0..MAX_Y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for (coord_y, ) in new_grid.iter_mut().enumerate().take(MAX_Y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `coord_y` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | for coord_y in 0..MAX_Y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for (coord_y, ) in new_grid.iter_mut().enumerate().take(MAX_Y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 124 | for in grid.iter().take(MAX_Y) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `coord_y` is only used to index `grid`. [INFO] [stderr] --> src/main.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | for coord_y in 0..MAX_Y { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 124 | for in grid.iter().take(MAX_Y) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "d82b4612763d20cb021f8fc93f39a682be139f7885eccbf6a1e9a1a50c3a237a"` [INFO] running `"docker" "rm" "-f" "d82b4612763d20cb021f8fc93f39a682be139f7885eccbf6a1e9a1a50c3a237a"` [INFO] [stdout] d82b4612763d20cb021f8fc93f39a682be139f7885eccbf6a1e9a1a50c3a237a