[INFO] updating cached repository aochagavia/rush-solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aochagavia/rush-solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aochagavia/rush-solver" "work/ex/clippy-test-run/sources/stable/gh/aochagavia/rush-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aochagavia/rush-solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aochagavia/rush-solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aochagavia/rush-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aochagavia/rush-solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f570c764ab4b3e2625364625a7b18dc506322466 [INFO] sha for GitHub repo aochagavia/rush-solver: f570c764ab4b3e2625364625a7b18dc506322466 [INFO] validating manifest of aochagavia/rush-solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aochagavia/rush-solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aochagavia/rush-solver [INFO] finished frobbing aochagavia/rush-solver [INFO] frobbed toml for aochagavia/rush-solver written to work/ex/clippy-test-run/sources/stable/gh/aochagavia/rush-solver/Cargo.toml [INFO] started frobbing aochagavia/rush-solver [INFO] finished frobbing aochagavia/rush-solver [INFO] frobbed toml for aochagavia/rush-solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aochagavia/rush-solver/Cargo.toml [INFO] crate aochagavia/rush-solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aochagavia/rush-solver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aochagavia/rush-solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2697e719e3f63de33a767fc4c413e1548f8bfe5892791f1e113d21e7e2d2154f [INFO] running `"docker" "start" "-a" "2697e719e3f63de33a767fc4c413e1548f8bfe5892791f1e113d21e7e2d2154f"` [INFO] [stderr] Checking rush v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/linked_list.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn into_iter(&self) -> impl DoubleEndedIterator { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | car.position.x == self.width - (car.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(car.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:103:43 [INFO] [stderr] | [INFO] [stderr] 103 | map[i as usize + (offset as u32 * self.width) as usize] = v + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:192:67 [INFO] [stderr] | [INFO] [stderr] 192 | Direction::Forward => self.position.translate(self.size as i32, 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:199:70 [INFO] [stderr] | [INFO] [stderr] 199 | Direction::Forward => self.position.translate(0, self.size as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:211:79 [INFO] [stderr] | [INFO] [stderr] 211 | && (self.position.x <= point.x && point.x < self.position.x + self.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:215:79 [INFO] [stderr] | [INFO] [stderr] 215 | && (self.position.y <= point.y && point.y < self.position.y + self.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/linked_list.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn into_iter(&self) -> impl DoubleEndedIterator { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | car.position.x == self.width - (car.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(car.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:103:43 [INFO] [stderr] | [INFO] [stderr] 103 | map[i as usize + (offset as u32 * self.width) as usize] = v + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:192:67 [INFO] [stderr] | [INFO] [stderr] 192 | Direction::Forward => self.position.translate(self.size as i32, 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:199:70 [INFO] [stderr] | [INFO] [stderr] 199 | Direction::Forward => self.position.translate(0, self.size as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:211:79 [INFO] [stderr] | [INFO] [stderr] 211 | && (self.position.x <= point.x && point.x < self.position.x + self.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/stage.rs:215:79 [INFO] [stderr] | [INFO] [stderr] 215 | && (self.position.y <= point.y && point.y < self.position.y + self.size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "2697e719e3f63de33a767fc4c413e1548f8bfe5892791f1e113d21e7e2d2154f"` [INFO] running `"docker" "rm" "-f" "2697e719e3f63de33a767fc4c413e1548f8bfe5892791f1e113d21e7e2d2154f"` [INFO] [stdout] 2697e719e3f63de33a767fc4c413e1548f8bfe5892791f1e113d21e7e2d2154f