[INFO] updating cached repository angelini/dataframes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/angelini/dataframes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/angelini/dataframes" "work/ex/clippy-test-run/sources/stable/gh/angelini/dataframes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/angelini/dataframes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/angelini/dataframes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angelini/dataframes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angelini/dataframes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce7514cc3a1a58a7f739019c356ef327f9a54e06 [INFO] sha for GitHub repo angelini/dataframes: ce7514cc3a1a58a7f739019c356ef327f9a54e06 [INFO] validating manifest of angelini/dataframes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of angelini/dataframes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing angelini/dataframes [INFO] finished frobbing angelini/dataframes [INFO] frobbed toml for angelini/dataframes written to work/ex/clippy-test-run/sources/stable/gh/angelini/dataframes/Cargo.toml [INFO] started frobbing angelini/dataframes [INFO] finished frobbing angelini/dataframes [INFO] frobbed toml for angelini/dataframes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angelini/dataframes/Cargo.toml [INFO] crate angelini/dataframes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting angelini/dataframes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angelini/dataframes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00fa7561e8aea1d601ca0752a7acac95ff8b656a89459b39d030472acc16da19 [INFO] running `"docker" "start" "-a" "00fa7561e8aea1d601ca0752a7acac95ff8b656a89459b39d030472acc16da19"` [INFO] [stderr] Checking dataframes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | Step { actions: actions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | Col { actions: actions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | Query { steps: steps } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | Step { actions: actions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | Col { actions: actions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | Query { steps: steps } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match action { [INFO] [stderr] 33 | | &Action::Filter => { return Some(i) }, [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &Action::Filter = action { return Some(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match action { [INFO] [stderr] 33 | | &Action::Filter => { return Some(i) }, [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *action { [INFO] [stderr] 33 | Action::Filter => { return Some(i) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match action { [INFO] [stderr] 43 | | &Action::Group(_) => { return true }, [INFO] [stderr] 44 | | _ => {}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &Action::Group(_) = action { return true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match action { [INFO] [stderr] 43 | | &Action::Group(_) => { return true }, [INFO] [stderr] 44 | | _ => {}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *action { [INFO] [stderr] 43 | Action::Group(_) => { return true }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / match action { [INFO] [stderr] 68 | | &Action::Empty => { [INFO] [stderr] 69 | | if seen_name && !is_used { [INFO] [stderr] 70 | | is_empty = true [INFO] [stderr] ... | [INFO] [stderr] 76 | | _ => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *action { [INFO] [stderr] 68 | Action::Empty => { [INFO] [stderr] 69 | if seen_name && !is_used { [INFO] [stderr] 70 | is_empty = true [INFO] [stderr] 71 | } [INFO] [stderr] 72 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | let steps = step_vec.into_iter().map(|actions| Step::new(actions)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Step::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | filter_anchor = j; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let rows_to_move_up = (anchor + 2..index + 1).rev(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(anchor + 2..=index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match action { [INFO] [stderr] 33 | | &Action::Filter => { return Some(i) }, [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &Action::Filter = action { return Some(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match action { [INFO] [stderr] 33 | | &Action::Filter => { return Some(i) }, [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *action { [INFO] [stderr] 33 | Action::Filter => { return Some(i) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match action { [INFO] [stderr] 43 | | &Action::Group(_) => { return true }, [INFO] [stderr] 44 | | _ => {}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &Action::Group(_) = action { return true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match action { [INFO] [stderr] 43 | | &Action::Group(_) => { return true }, [INFO] [stderr] 44 | | _ => {}, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *action { [INFO] [stderr] 43 | Action::Group(_) => { return true }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / match action { [INFO] [stderr] 68 | | &Action::Empty => { [INFO] [stderr] 69 | | if seen_name && !is_used { [INFO] [stderr] 70 | | is_empty = true [INFO] [stderr] ... | [INFO] [stderr] 76 | | _ => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *action { [INFO] [stderr] 68 | Action::Empty => { [INFO] [stderr] 69 | if seen_name && !is_used { [INFO] [stderr] 70 | is_empty = true [INFO] [stderr] 71 | } [INFO] [stderr] 72 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | let steps = step_vec.into_iter().map(|actions| Step::new(actions)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Step::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | filter_anchor = j; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let rows_to_move_up = (anchor + 2..index + 1).rev(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(anchor + 2..=index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "00fa7561e8aea1d601ca0752a7acac95ff8b656a89459b39d030472acc16da19"` [INFO] running `"docker" "rm" "-f" "00fa7561e8aea1d601ca0752a7acac95ff8b656a89459b39d030472acc16da19"` [INFO] [stdout] 00fa7561e8aea1d601ca0752a7acac95ff8b656a89459b39d030472acc16da19