[INFO] updating cached repository angel-git/Advent2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/angel-git/Advent2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/angel-git/Advent2018" "work/ex/clippy-test-run/sources/stable/gh/angel-git/Advent2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/angel-git/Advent2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/angel-git/Advent2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angel-git/Advent2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angel-git/Advent2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c124bfc7e6eaaa31b066070d33ec106454a85f0d [INFO] sha for GitHub repo angel-git/Advent2018: c124bfc7e6eaaa31b066070d33ec106454a85f0d [INFO] validating manifest of angel-git/Advent2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of angel-git/Advent2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing angel-git/Advent2018 [INFO] finished frobbing angel-git/Advent2018 [INFO] frobbed toml for angel-git/Advent2018 written to work/ex/clippy-test-run/sources/stable/gh/angel-git/Advent2018/Cargo.toml [INFO] started frobbing angel-git/Advent2018 [INFO] finished frobbing angel-git/Advent2018 [INFO] frobbed toml for angel-git/Advent2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angel-git/Advent2018/Cargo.toml [INFO] crate angel-git/Advent2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting angel-git/Advent2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/angel-git/Advent2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 919e444eeb589f39f0339dc54c058131408284b6d0a7961af469650cac70b0f3 [INFO] running `"docker" "start" "-a" "919e444eeb589f39f0339dc54c058131408284b6d0a7961af469650cac70b0f3"` [INFO] [stderr] Checking advent-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_file` [INFO] [stderr] --> src/day_one.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn read_file() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `part1` [INFO] [stderr] --> src/day_one.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | fn part1() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `part2` [INFO] [stderr] --> src/day_one.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn part2() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_one.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | count = count + value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_one.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | count = count + value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_one.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | count = count + value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_one.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | count = count + value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `"docker" "inspect" "919e444eeb589f39f0339dc54c058131408284b6d0a7961af469650cac70b0f3"` [INFO] running `"docker" "rm" "-f" "919e444eeb589f39f0339dc54c058131408284b6d0a7961af469650cac70b0f3"` [INFO] [stdout] 919e444eeb589f39f0339dc54c058131408284b6d0a7961af469650cac70b0f3