[INFO] updating cached repository andysalerno/explain_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andysalerno/explain_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andysalerno/explain_rs" "work/ex/clippy-test-run/sources/stable/gh/andysalerno/explain_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andysalerno/explain_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andysalerno/explain_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andysalerno/explain_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andysalerno/explain_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 211aa5f0405032834f15a99ad837b620b173d1e5 [INFO] sha for GitHub repo andysalerno/explain_rs: 211aa5f0405032834f15a99ad837b620b173d1e5 [INFO] validating manifest of andysalerno/explain_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andysalerno/explain_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andysalerno/explain_rs [INFO] finished frobbing andysalerno/explain_rs [INFO] frobbed toml for andysalerno/explain_rs written to work/ex/clippy-test-run/sources/stable/gh/andysalerno/explain_rs/Cargo.toml [INFO] started frobbing andysalerno/explain_rs [INFO] finished frobbing andysalerno/explain_rs [INFO] frobbed toml for andysalerno/explain_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andysalerno/explain_rs/Cargo.toml [INFO] crate andysalerno/explain_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andysalerno/explain_rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andysalerno/explain_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 441746a800e336f7c66349799edc92cf22231152aa2b75b69b9ed683bbe66dc0 [INFO] running `"docker" "start" "-a" "441746a800e336f7c66349799edc92cf22231152aa2b75b69b9ed683bbe66dc0"` [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking explain_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | starts_line: starts_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `starts_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_parser/token.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | starts_line: starts_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `starts_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/arg_parse/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod arg_parse; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | special_tok [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | let special_tok = match *c { [INFO] [stderr] | _______________________^ [INFO] [stderr] 250 | | '\\' => Some(TroffToken::Backslash), [INFO] [stderr] 251 | | '"' => Some(TroffToken::DoubleQuote), [INFO] [stderr] 252 | | _ => None, [INFO] [stderr] 253 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/text_format/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod text_format; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/arg_parse/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod arg_parse; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | special_tok [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | let special_tok = match *c { [INFO] [stderr] | _______________________^ [INFO] [stderr] 250 | | '\\' => Some(TroffToken::Backslash), [INFO] [stderr] 251 | | '"' => Some(TroffToken::DoubleQuote), [INFO] [stderr] 252 | | _ => None, [INFO] [stderr] 253 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/text_format/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod text_format; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `difference` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | let difference = text_start_pos - count_whitespace; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_difference` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/man_parse/troff_parser.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | let mut pops = if let Some(tok) = decrease_arg { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `difference` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | let difference = text_start_pos - count_whitespace; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_difference` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/man_parse/troff_parser.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | let mut pops = if let Some(tok) = decrease_arg { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Underlined` [INFO] [stderr] --> src/man_parse/term_writer/font_style.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Underlined, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NonWhitespace` [INFO] [stderr] --> src/man_parse/term_writer/line_info.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | NonWhitespace, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `disable_debug` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn disable_debug(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `indent` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn indent(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default_indent` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn default_indent(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arg_parse/arg_parse.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | if !arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/arg_parse/arg_parse.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(arg) = args_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for arg in args_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/term_writer/line_info.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/man_parse/troff_parser.rs:214:36 [INFO] [stderr] | [INFO] [stderr] 214 | if !tok.starts_line && tok [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 215 | | .value [INFO] [stderr] 216 | | .chars() [INFO] [stderr] 217 | | .filter(|t| !t.is_whitespace()) [INFO] [stderr] 218 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| !t.is_whitespace()).next()` with `find(|t| !t.is_whitespace())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/man_parse/troff_parser.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | / match tok.value.as_str() { [INFO] [stderr] 559 | | "cq" => self.add_to_output("'"), [INFO] [stderr] 560 | | // also lq, rq, oq apparently, TODO [INFO] [stderr] 561 | | _ => {} [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "cq" = tok.value.as_str() { self.add_to_output("'") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_parser.rs:624:12 [INFO] [stderr] | [INFO] [stderr] 624 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_parser.rs:650:16 [INFO] [stderr] | [INFO] [stderr] 650 | if arg.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Underlined` [INFO] [stderr] --> src/man_parse/term_writer/font_style.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Underlined, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NonWhitespace` [INFO] [stderr] --> src/man_parse/term_writer/line_info.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | NonWhitespace, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `disable_debug` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn disable_debug(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `indent` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn indent(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default_indent` [INFO] [stderr] --> src/man_parse/term_writer/troff_term_writer.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn default_indent(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arg_parse/arg_parse.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | if !arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/arg_parse/arg_parse.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(arg) = args_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for arg in args_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/term_writer/line_info.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | fn try_match_special(c: &char) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simple_parser/split_whitespace.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | cur_idx = cur_idx + c.len_utf8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_idx += c.len_utf8()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/man_parse/troff_parser.rs:214:36 [INFO] [stderr] | [INFO] [stderr] 214 | if !tok.starts_line && tok [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 215 | | .value [INFO] [stderr] 216 | | .chars() [INFO] [stderr] 217 | | .filter(|t| !t.is_whitespace()) [INFO] [stderr] 218 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| !t.is_whitespace()).next()` with `find(|t| !t.is_whitespace())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simple_parser/tokenizer.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/simple_parser/tokenizer.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | while let Some((i, word)) = word_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for (i, word) in word_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/man_parse/troff_parser.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | / match tok.value.as_str() { [INFO] [stderr] 559 | | "cq" => self.add_to_output("'"), [INFO] [stderr] 560 | | // also lq, rq, oq apparently, TODO [INFO] [stderr] 561 | | _ => {} [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "cq" = tok.value.as_str() { self.add_to_output("'") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_parser.rs:624:12 [INFO] [stderr] | [INFO] [stderr] 624 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_parser.rs:650:16 [INFO] [stderr] | [INFO] [stderr] 650 | if arg.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | let mut file = File::open(file_path).expect(&format!("path not found: {}", &file_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("path not found: {}", &file_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/man_parse/troff_token_generator.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | fn try_match_special(c: &char) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simple_parser/split_whitespace.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | cur_idx = cur_idx + c.len_utf8(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_idx += c.len_utf8()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simple_parser/tokenizer.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/simple_parser/tokenizer.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | while let Some((i, word)) = word_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `for (i, word) in word_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | let mut file = File::open(file_path).expect(&format!("path not found: {}", &file_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("path not found: {}", &file_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.78s [INFO] running `"docker" "inspect" "441746a800e336f7c66349799edc92cf22231152aa2b75b69b9ed683bbe66dc0"` [INFO] running `"docker" "rm" "-f" "441746a800e336f7c66349799edc92cf22231152aa2b75b69b9ed683bbe66dc0"` [INFO] [stdout] 441746a800e336f7c66349799edc92cf22231152aa2b75b69b9ed683bbe66dc0