[INFO] updating cached repository andybalaam/pepper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/andybalaam/pepper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/andybalaam/pepper" "work/ex/clippy-test-run/sources/stable/gh/andybalaam/pepper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/andybalaam/pepper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/andybalaam/pepper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andybalaam/pepper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andybalaam/pepper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a6d738309bb05dfdc9a949d546ba43cbe5f694c8 [INFO] sha for GitHub repo andybalaam/pepper: a6d738309bb05dfdc9a949d546ba43cbe5f694c8 [INFO] validating manifest of andybalaam/pepper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andybalaam/pepper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andybalaam/pepper [INFO] finished frobbing andybalaam/pepper [INFO] frobbed toml for andybalaam/pepper written to work/ex/clippy-test-run/sources/stable/gh/andybalaam/pepper/Cargo.toml [INFO] started frobbing andybalaam/pepper [INFO] finished frobbing andybalaam/pepper [INFO] frobbed toml for andybalaam/pepper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andybalaam/pepper/Cargo.toml [INFO] crate andybalaam/pepper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andybalaam/pepper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/andybalaam/pepper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76b0215a05486d07761ed10f7a1a8f775221a347bed0ed8eb5c70aff8805148b [INFO] running `"docker" "start" "-a" "76b0215a05486d07761ed10f7a1a8f775221a347bed0ed8eb5c70aff8805148b"` [INFO] [stderr] Checking pepper3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexing/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexing/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexing/char_iter.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexing/lex_int.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 63 | | if !is_digit(ch) { [INFO] [stderr] 64 | | return Err(fix_underscores(&s)) [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if !is_digit(ch) { [INFO] [stderr] 63 | return Err(fix_underscores(&s)) [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexing/char_iter.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexing/lex_int.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 63 | | if !is_digit(ch) { [INFO] [stderr] 64 | | return Err(fix_underscores(&s)) [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 62 | } else if !is_digit(ch) { [INFO] [stderr] 63 | return Err(fix_underscores(&s)) [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / world.stderr.write(e.description().as_bytes()) [INFO] [stderr] 14 | | .expect("Failed to write an error to error stream."); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | stdout.write(b"tokens = import(language.lexing.tokens);\n[\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | stdout.write(b" tokens.int(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | stdout.write(i.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | stdout.write(b" tokens.symbol(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | stdout.write(s.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | stdout.write(b" tokens.operator(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | stdout.write(o.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | stdout.write(b"];\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmdline/command.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn identify(all_args: &Vec) -> (Command, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmdline/command.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn skip_2(all_args: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | world.stdout.write(b"3\n").expect("Failed to write 3."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / world.stderr.write(b"Shell mode not implemented yet.\n") [INFO] [stderr] 35 | | .expect("\ [INFO] [stderr] 36 | | Failed writing to stderr when complaining \ [INFO] [stderr] 37 | | that shell mode is not implemented yet.\ [INFO] [stderr] 38 | | "); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_int.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | fn validate_underscores(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `n` is used as a loop counter. Consider using `for (n, item) in s.chars().rev().enumerate()` or similar iterators [INFO] [stderr] --> src/lexing/lex_int.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | for ch in s.chars().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_int.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | fn fix_underscores(s: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexing/lex_int.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match ch { [INFO] [stderr] 76 | | '0' ... '9' => { [INFO] [stderr] 77 | | n += 1; [INFO] [stderr] 78 | | if n % 4 == 0 { [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {}, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let '0' ... '9' = ch { [INFO] [stderr] 76 | n += 1; [INFO] [stderr] 77 | if n % 4 == 0 { [INFO] [stderr] 78 | ret.push('_'); [INFO] [stderr] 79 | n += 1; [INFO] [stderr] 80 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_operator.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | fn known_name(name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pepper3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmdline/fakereadfile.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | / world.stderr.write(e.description().as_bytes()) [INFO] [stderr] 14 | | .expect("Failed to write an error to error stream."); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | stdout.write(b"tokens = import(language.lexing.tokens);\n[\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | stdout.write(b" tokens.int(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | stdout.write(i.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | stdout.write(b" tokens.symbol(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | stdout.write(s.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | stdout.write(b" tokens.operator(\"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | stdout.write(o.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | stdout.write(b"\"),\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/cmdlex.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | stdout.write(b"];\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmdline/cmdlex.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | fn assert_vec_eq(left: &Vec, right: &[u8]) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 87 | fn assert_vec_eq(left: &[u8], right: &[u8]) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `left.clone()` to [INFO] [stderr] | [INFO] [stderr] 89 | let sleft = String::from_utf8(left.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmdline/command.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn identify(all_args: &Vec) -> (Command, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmdline/command.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn skip_2(all_args: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | world.stdout.write(b"3\n").expect("Failed to write 3."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cmdline/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / world.stderr.write(b"Shell mode not implemented yet.\n") [INFO] [stderr] 35 | | .expect("\ [INFO] [stderr] 36 | | Failed writing to stderr when complaining \ [INFO] [stderr] 37 | | that shell mode is not implemented yet.\ [INFO] [stderr] 38 | | "); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_int.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | fn validate_underscores(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `n` is used as a loop counter. Consider using `for (n, item) in s.chars().rev().enumerate()` or similar iterators [INFO] [stderr] --> src/lexing/lex_int.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | for ch in s.chars().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_int.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | fn fix_underscores(s: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexing/lex_int.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match ch { [INFO] [stderr] 76 | | '0' ... '9' => { [INFO] [stderr] 77 | | n += 1; [INFO] [stderr] 78 | | if n % 4 == 0 { [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {}, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let '0' ... '9' = ch { [INFO] [stderr] 76 | n += 1; [INFO] [stderr] 77 | if n % 4 == 0 { [INFO] [stderr] 78 | ret.push('_'); [INFO] [stderr] 79 | n += 1; [INFO] [stderr] 80 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexing/lex_operator.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | fn known_name(name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pepper3`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "76b0215a05486d07761ed10f7a1a8f775221a347bed0ed8eb5c70aff8805148b"` [INFO] running `"docker" "rm" "-f" "76b0215a05486d07761ed10f7a1a8f775221a347bed0ed8eb5c70aff8805148b"` [INFO] [stdout] 76b0215a05486d07761ed10f7a1a8f775221a347bed0ed8eb5c70aff8805148b