[INFO] updating cached repository anderejd/rollcache
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/anderejd/rollcache
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/anderejd/rollcache" "work/ex/clippy-test-run/sources/stable/gh/anderejd/rollcache"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/anderejd/rollcache'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/anderejd/rollcache" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anderejd/rollcache"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anderejd/rollcache'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1707f8fdd8addcc313c9fcf8b9b71959a6ea57ed
[INFO] sha for GitHub repo anderejd/rollcache: 1707f8fdd8addcc313c9fcf8b9b71959a6ea57ed
[INFO] validating manifest of anderejd/rollcache on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of anderejd/rollcache on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing anderejd/rollcache
[INFO] finished frobbing anderejd/rollcache
[INFO] frobbed toml for anderejd/rollcache written to work/ex/clippy-test-run/sources/stable/gh/anderejd/rollcache/Cargo.toml
[INFO] started frobbing anderejd/rollcache
[INFO] finished frobbing anderejd/rollcache
[INFO] frobbed toml for anderejd/rollcache written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anderejd/rollcache/Cargo.toml
[INFO] crate anderejd/rollcache has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting anderejd/rollcache against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/anderejd/rollcache:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dc53229e77119209f1b1918d0b8d7f41815c31a2fd13883b868fc76ca47efbea
[INFO] running `"docker" "start" "-a" "dc53229e77119209f1b1918d0b8d7f41815c31a2fd13883b868fc76ca47efbea"`
[INFO] [stderr]     Checking rollcache v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/version_1/ringlist.rs:238:9
[INFO] [stderr]     |
[INFO] [stderr] 238 |         removed
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/version_1/ringlist.rs:236:23
[INFO] [stderr]     |
[INFO] [stderr] 236 |         let removed = self.remove(id);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/version_1/mod.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         opt
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/version_1/mod.rs:69:19
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let opt = self.get_internal_mut(k).map(|e| &mut e.data);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/version_2/ringlist.rs:235:9
[INFO] [stderr]     |
[INFO] [stderr] 235 |         removed
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/version_2/ringlist.rs:233:23
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let removed = self.remove(id);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Instant`
[INFO] [stderr]  --> src/version_2/mod.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::time::Instant;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/version_2/mod.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         opt
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/version_2/mod.rs:64:19
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let opt = self.get_internal_mut(k).map(|e| &mut e.data);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/version_1/ringlist.rs:238:9
[INFO] [stderr]     |
[INFO] [stderr] 238 |         removed
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/version_1/ringlist.rs:236:23
[INFO] [stderr]     |
[INFO] [stderr] 236 |         let removed = self.remove(id);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/version_1/mod.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         opt
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/version_1/mod.rs:69:19
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let opt = self.get_internal_mut(k).map(|e| &mut e.data);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/version_2/ringlist.rs:235:9
[INFO] [stderr]     |
[INFO] [stderr] 235 |         removed
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/version_2/ringlist.rs:233:23
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let removed = self.remove(id);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::time::Instant`
[INFO] [stderr]  --> src/version_2/mod.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::time::Instant;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/version_2/mod.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         opt
[INFO] [stderr]    |         ^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/version_2/mod.rs:64:19
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let opt = self.get_internal_mut(k).map(|e| &mut e.data);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `InsertionWithRelocation`
[INFO] [stderr]   --> src/version_2/ringlist.rs:34:1
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub struct InsertionWithRelocation {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get`
[INFO] [stderr]    --> src/version_2/ringlist.rs:222:5
[INFO] [stderr]     |
[INFO] [stderr] 222 |     pub fn get(&self, i: Id) -> Option<&T> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_1/ringlist.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn to_index(&self) -> Index {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_1/ringlist.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     fn to_id(&self) -> Id {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/version_1/ringlist.rs:111:16
[INFO] [stderr]     |
[INFO] [stderr] 111 |     fn is_free(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/version_1/ringlist.rs:300:14
[INFO] [stderr]     |
[INFO] [stderr] 300 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("RingList::push_front, out of free nodes."))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/version_1/ringlist.rs:300:22
[INFO] [stderr]     |
[INFO] [stderr] 300 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RingList::push_front, out of free nodes.".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_1/mod.rs:38:34
[INFO] [stderr]    |
[INFO] [stderr] 38 |               map.remove(&map_key).expect(&format!(
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 39 | |                 "LruCache, expected self.map to contain: {}",
[INFO] [stderr] 40 | |                 map_key
[INFO] [stderr] 41 | |             ));
[INFO] [stderr]    | |______________^ help: try this: `unwrap_or_else(|| panic!("LruCache, expected self.map to contain: {}", map_key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_1/mod.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 .expect(&format!("Failed to remove node with key {}.", k));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to remove node with key {}.", k))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_2/ringlist.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn to_index(&self) -> Index {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_2/ringlist.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |     fn to_id(&self) -> Id {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/version_2/ringlist.rs:108:16
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn is_free(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/version_2/ringlist.rs:297:14
[INFO] [stderr]     |
[INFO] [stderr] 297 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("RingList::push_front, out of free nodes."))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/version_2/ringlist.rs:297:22
[INFO] [stderr]     |
[INFO] [stderr] 297 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RingList::push_front, out of free nodes.".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_2/mod.rs:38:34
[INFO] [stderr]    |
[INFO] [stderr] 38 |               map.remove(&map_key).expect(&format!(
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 39 | |                 "LruCache, expected self.map to contain: {}",
[INFO] [stderr] 40 | |                 map_key
[INFO] [stderr] 41 | |             ));
[INFO] [stderr]    | |______________^ help: try this: `unwrap_or_else(|| panic!("LruCache, expected self.map to contain: {}", map_key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let`
[INFO] [stderr]   --> src/version_2/mod.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         let new_id = match insertion {
[INFO] [stderr] 46 | |             RingListInsertion::Simple(id) => id,
[INFO] [stderr] 47 | |         };
[INFO] [stderr]    | |__________^ help: try this: `let RingListInsertion::Simple(new_id) = insertion;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::infallible_destructuring_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_2/mod.rs:74:14
[INFO] [stderr]    |
[INFO] [stderr] 74 |             .expect(&format!("Failed to remove node with key {}.", k));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to remove node with key {}.", k))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let`
[INFO] [stderr]   --> src/version_2/mod.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         let new_id = match list.push_front(k.to_owned()) {
[INFO] [stderr] 77 | |             RingListInsertion::Simple(id) => id,
[INFO] [stderr] 78 | |         };
[INFO] [stderr]    | |__________^ help: try this: `let RingListInsertion::Simple(new_id) = list.push_front(k.to_owned());`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `InsertionWithRelocation`
[INFO] [stderr]   --> src/version_2/ringlist.rs:34:1
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub struct InsertionWithRelocation {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get`
[INFO] [stderr]    --> src/version_2/ringlist.rs:222:5
[INFO] [stderr]     |
[INFO] [stderr] 222 |     pub fn get(&self, i: Id) -> Option<&T> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_1/ringlist.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn to_index(&self) -> Index {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_1/ringlist.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     fn to_id(&self) -> Id {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/version_1/ringlist.rs:111:16
[INFO] [stderr]     |
[INFO] [stderr] 111 |     fn is_free(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/version_1/ringlist.rs:300:14
[INFO] [stderr]     |
[INFO] [stderr] 300 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("RingList::push_front, out of free nodes."))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/version_1/ringlist.rs:300:22
[INFO] [stderr]     |
[INFO] [stderr] 300 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RingList::push_front, out of free nodes.".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_1/mod.rs:38:34
[INFO] [stderr]    |
[INFO] [stderr] 38 |               map.remove(&map_key).expect(&format!(
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 39 | |                 "LruCache, expected self.map to contain: {}",
[INFO] [stderr] 40 | |                 map_key
[INFO] [stderr] 41 | |             ));
[INFO] [stderr]    | |______________^ help: try this: `unwrap_or_else(|| panic!("LruCache, expected self.map to contain: {}", map_key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_1/mod.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 .expect(&format!("Failed to remove node with key {}.", k));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to remove node with key {}.", k))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_2/ringlist.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn to_index(&self) -> Index {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/version_2/ringlist.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |     fn to_id(&self) -> Id {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/version_2/ringlist.rs:108:16
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn is_free(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/version_2/ringlist.rs:297:14
[INFO] [stderr]     |
[INFO] [stderr] 297 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("RingList::push_front, out of free nodes."))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/version_2/ringlist.rs:297:22
[INFO] [stderr]     |
[INFO] [stderr] 297 |             .expect(&format!("RingList::push_front, out of free nodes."));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"RingList::push_front, out of free nodes.".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_2/mod.rs:38:34
[INFO] [stderr]    |
[INFO] [stderr] 38 |               map.remove(&map_key).expect(&format!(
[INFO] [stderr]    |  __________________________________^
[INFO] [stderr] 39 | |                 "LruCache, expected self.map to contain: {}",
[INFO] [stderr] 40 | |                 map_key
[INFO] [stderr] 41 | |             ));
[INFO] [stderr]    | |______________^ help: try this: `unwrap_or_else(|| panic!("LruCache, expected self.map to contain: {}", map_key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let`
[INFO] [stderr]   --> src/version_2/mod.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         let new_id = match insertion {
[INFO] [stderr] 46 | |             RingListInsertion::Simple(id) => id,
[INFO] [stderr] 47 | |         };
[INFO] [stderr]    | |__________^ help: try this: `let RingListInsertion::Simple(new_id) = insertion;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::infallible_destructuring_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/version_2/mod.rs:74:14
[INFO] [stderr]    |
[INFO] [stderr] 74 |             .expect(&format!("Failed to remove node with key {}.", k));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to remove node with key {}.", k))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let`
[INFO] [stderr]   --> src/version_2/mod.rs:76:9
[INFO] [stderr]    |
[INFO] [stderr] 76 | /         let new_id = match list.push_front(k.to_owned()) {
[INFO] [stderr] 77 | |             RingListInsertion::Simple(id) => id,
[INFO] [stderr] 78 | |         };
[INFO] [stderr]    | |__________^ help: try this: `let RingListInsertion::Simple(new_id) = list.push_front(k.to_owned());`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/simple.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/simple.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> examples/simple.rs:86:26
[INFO] [stderr]    |
[INFO] [stderr] 86 |     d.as_secs() as f64 + d.subsec_nanos() as f64 * 1e-9
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.26s
[INFO] running `"docker" "inspect" "dc53229e77119209f1b1918d0b8d7f41815c31a2fd13883b868fc76ca47efbea"`
[INFO] running `"docker" "rm" "-f" "dc53229e77119209f1b1918d0b8d7f41815c31a2fd13883b868fc76ca47efbea"`
[INFO] [stdout] dc53229e77119209f1b1918d0b8d7f41815c31a2fd13883b868fc76ca47efbea