[INFO] updating cached repository amw-zero/qwerty_dvorak.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amw-zero/qwerty_dvorak.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amw-zero/qwerty_dvorak.rs" "work/ex/clippy-test-run/sources/stable/gh/amw-zero/qwerty_dvorak.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amw-zero/qwerty_dvorak.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amw-zero/qwerty_dvorak.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amw-zero/qwerty_dvorak.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amw-zero/qwerty_dvorak.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5aa0fcd971723035192a980ab33f2e6e5687fbe1 [INFO] sha for GitHub repo amw-zero/qwerty_dvorak.rs: 5aa0fcd971723035192a980ab33f2e6e5687fbe1 [INFO] validating manifest of amw-zero/qwerty_dvorak.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amw-zero/qwerty_dvorak.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amw-zero/qwerty_dvorak.rs [INFO] finished frobbing amw-zero/qwerty_dvorak.rs [INFO] frobbed toml for amw-zero/qwerty_dvorak.rs written to work/ex/clippy-test-run/sources/stable/gh/amw-zero/qwerty_dvorak.rs/Cargo.toml [INFO] started frobbing amw-zero/qwerty_dvorak.rs [INFO] finished frobbing amw-zero/qwerty_dvorak.rs [INFO] frobbed toml for amw-zero/qwerty_dvorak.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amw-zero/qwerty_dvorak.rs/Cargo.toml [INFO] crate amw-zero/qwerty_dvorak.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amw-zero/qwerty_dvorak.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amw-zero/qwerty_dvorak.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf37ba02154083ff062caa9d8235f8ef9a6fdec8e779da1a10e0e47dac5a9f14 [INFO] running `"docker" "start" "-a" "bf37ba02154083ff062caa9d8235f8ef9a6fdec8e779da1a10e0e47dac5a9f14"` [INFO] [stderr] Checking qwerty_dvorak v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | let file = match File::open(&path) { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | Err(why) => panic!("couldn't open {}: {}", display, [INFO] [stderr] 41 | | Error::description(&why)), [INFO] [stderr] 42 | | Ok(file) => file [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | words [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | let words = match dict_file.read_to_string(dict_contents) { [INFO] [stderr] | _________________^ [INFO] [stderr] 49 | | Ok(_) => { [INFO] [stderr] 50 | | dict_contents.lines().map(|line| line.trim_right()).collect::>() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | Err(_) => panic!("couldn't parse dict file") [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | file [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | let file = match File::open(&path) { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | Err(why) => panic!("couldn't open {}: {}", display, [INFO] [stderr] 41 | | Error::description(&why)), [INFO] [stderr] 42 | | Ok(file) => file [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | words [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | let words = match dict_file.read_to_string(dict_contents) { [INFO] [stderr] | _________________^ [INFO] [stderr] 49 | | Ok(_) => { [INFO] [stderr] 50 | | dict_contents.lines().map(|line| line.trim_right()).collect::>() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | Err(_) => panic!("couldn't parse dict file") [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | Err(_) => panic!("couldn't parse dict file") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | Err(_) => panic!("couldn't parse dict file") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match index.get(&converted) { [INFO] [stderr] 86 | | Some(_) => println!("{} -> {}", word, converted), [INFO] [stderr] 87 | | None => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = index.get(&converted) { println!("{} -> {}", word, converted) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match index.get(&converted) { [INFO] [stderr] 86 | | Some(_) => println!("{} -> {}", word, converted), [INFO] [stderr] 87 | | None => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = index.get(&converted) { println!("{} -> {}", word, converted) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `"docker" "inspect" "bf37ba02154083ff062caa9d8235f8ef9a6fdec8e779da1a10e0e47dac5a9f14"` [INFO] running `"docker" "rm" "-f" "bf37ba02154083ff062caa9d8235f8ef9a6fdec8e779da1a10e0e47dac5a9f14"` [INFO] [stdout] bf37ba02154083ff062caa9d8235f8ef9a6fdec8e779da1a10e0e47dac5a9f14