[INFO] updating cached repository amilajack/todo_list [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amilajack/todo_list [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amilajack/todo_list" "work/ex/clippy-test-run/sources/stable/gh/amilajack/todo_list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amilajack/todo_list'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amilajack/todo_list" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/todo_list"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/todo_list'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22d0d75306fdcff708dfeaaa67021d9c4e3cd6a9 [INFO] sha for GitHub repo amilajack/todo_list: 22d0d75306fdcff708dfeaaa67021d9c4e3cd6a9 [INFO] validating manifest of amilajack/todo_list on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amilajack/todo_list on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amilajack/todo_list [INFO] finished frobbing amilajack/todo_list [INFO] frobbed toml for amilajack/todo_list written to work/ex/clippy-test-run/sources/stable/gh/amilajack/todo_list/Cargo.toml [INFO] started frobbing amilajack/todo_list [INFO] finished frobbing amilajack/todo_list [INFO] frobbed toml for amilajack/todo_list written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/todo_list/Cargo.toml [INFO] crate amilajack/todo_list has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amilajack/todo_list against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/todo_list:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fc9cdff260fee7f7f407c3e8ef3d34cbde938e33dab22f63cb0f881312b60e5 [INFO] running `"docker" "start" "-a" "8fc9cdff260fee7f7f407c3e8ef3d34cbde938e33dab22f63cb0f881312b60e5"` [INFO] [stderr] Checking todo_list v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `todo_list::Database` [INFO] [stderr] --> src/todo_list.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Database { [INFO] [stderr] 14 | | tasks: vec![] [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/todo_list.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / &self.tasks.push(Task { [INFO] [stderr] 21 | | name: String::from(name), [INFO] [stderr] 22 | | id: (len as u32) + 1 [INFO] [stderr] 23 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 20 | self.tasks.push(Task { [INFO] [stderr] 21 | name: String::from(name), [INFO] [stderr] 22 | id: (len as u32) + 1 [INFO] [stderr] 23 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/todo_list.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | &self.tasks.get(id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tasks[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `todo_list::Database` [INFO] [stderr] --> src/todo_list.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Database { [INFO] [stderr] 14 | | tasks: vec![] [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/todo_list.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / &self.tasks.push(Task { [INFO] [stderr] 21 | | name: String::from(name), [INFO] [stderr] 22 | | id: (len as u32) + 1 [INFO] [stderr] 23 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 20 | self.tasks.push(Task { [INFO] [stderr] 21 | name: String::from(name), [INFO] [stderr] 22 | id: (len as u32) + 1 [INFO] [stderr] 23 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/todo_list.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | &self.tasks.get(id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tasks[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Task` [INFO] [stderr] --> src/todo_list.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub struct Task { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Database` [INFO] [stderr] --> src/todo_list.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct Database { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/todo_list.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/todo_list.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn add(&mut self, name: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_all` [INFO] [stderr] --> src/todo_list.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn get_all(&self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/todo_list.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn get(&self, id: usize) -> &Task { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `delete` [INFO] [stderr] --> src/todo_list.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn delete(&mut self, id: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/todo_list.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / &self.tasks.push(Task { [INFO] [stderr] 21 | | name: String::from(name), [INFO] [stderr] 22 | | id: (len as u32) + 1 [INFO] [stderr] 23 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 20 | self.tasks.push(Task { [INFO] [stderr] 21 | name: String::from(name), [INFO] [stderr] 22 | id: (len as u32) + 1 [INFO] [stderr] 23 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/todo_list.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | &self.tasks.get(id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tasks[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/todo_list.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / &self.tasks.push(Task { [INFO] [stderr] 21 | | name: String::from(name), [INFO] [stderr] 22 | | id: (len as u32) + 1 [INFO] [stderr] 23 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 20 | self.tasks.push(Task { [INFO] [stderr] 21 | name: String::from(name), [INFO] [stderr] 22 | id: (len as u32) + 1 [INFO] [stderr] 23 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/todo_list.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | &self.tasks.get(id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tasks[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "8fc9cdff260fee7f7f407c3e8ef3d34cbde938e33dab22f63cb0f881312b60e5"` [INFO] running `"docker" "rm" "-f" "8fc9cdff260fee7f7f407c3e8ef3d34cbde938e33dab22f63cb0f881312b60e5"` [INFO] [stdout] 8fc9cdff260fee7f7f407c3e8ef3d34cbde938e33dab22f63cb0f881312b60e5