[INFO] updating cached repository amilajack/rust-algos [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amilajack/rust-algos [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amilajack/rust-algos" "work/ex/clippy-test-run/sources/stable/gh/amilajack/rust-algos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amilajack/rust-algos'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amilajack/rust-algos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/rust-algos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/rust-algos'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ddc9195f0689b631bfdd97dd878adb04574f7b9 [INFO] sha for GitHub repo amilajack/rust-algos: 3ddc9195f0689b631bfdd97dd878adb04574f7b9 [INFO] validating manifest of amilajack/rust-algos on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amilajack/rust-algos on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amilajack/rust-algos [INFO] finished frobbing amilajack/rust-algos [INFO] frobbed toml for amilajack/rust-algos written to work/ex/clippy-test-run/sources/stable/gh/amilajack/rust-algos/Cargo.toml [INFO] started frobbing amilajack/rust-algos [INFO] finished frobbing amilajack/rust-algos [INFO] frobbed toml for amilajack/rust-algos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/rust-algos/Cargo.toml [INFO] crate amilajack/rust-algos has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amilajack/rust-algos against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amilajack/rust-algos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12510405daa84a02b878e65bf71ba0edc1056cbca3a5cdd44d1dcabfb307896f [INFO] running `"docker" "start" "-a" "12510405daa84a02b878e65bf71ba0edc1056cbca3a5cdd44d1dcabfb307896f"` [INFO] [stderr] Checking algos v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `is_prime` [INFO] [stderr] --> src/math.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn is_prime(a: u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/search.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if middle_value < &item { [INFO] [stderr] | ^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/math.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match euclidean_gcd(a, b) == 1 { [INFO] [stderr] 27 | | true => continue, [INFO] [stderr] 28 | | false => return false [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if euclidean_gcd(a, b) == 1 { continue } else { return false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/search.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if middle_value < &item { [INFO] [stderr] | ^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/math.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match euclidean_gcd(a, b) == 1 { [INFO] [stderr] 27 | | true => continue, [INFO] [stderr] 28 | | false => return false [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if euclidean_gcd(a, b) == 1 { continue } else { return false }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "12510405daa84a02b878e65bf71ba0edc1056cbca3a5cdd44d1dcabfb307896f"` [INFO] running `"docker" "rm" "-f" "12510405daa84a02b878e65bf71ba0edc1056cbca3a5cdd44d1dcabfb307896f"` [INFO] [stdout] 12510405daa84a02b878e65bf71ba0edc1056cbca3a5cdd44d1dcabfb307896f