[INFO] updating cached repository amerelo/Computor_v1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amerelo/Computor_v1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amerelo/Computor_v1" "work/ex/clippy-test-run/sources/stable/gh/amerelo/Computor_v1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amerelo/Computor_v1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amerelo/Computor_v1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amerelo/Computor_v1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amerelo/Computor_v1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 955472e3c6e14cc3afc1509855ba00f9fff13412 [INFO] sha for GitHub repo amerelo/Computor_v1: 955472e3c6e14cc3afc1509855ba00f9fff13412 [INFO] validating manifest of amerelo/Computor_v1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amerelo/Computor_v1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amerelo/Computor_v1 [INFO] finished frobbing amerelo/Computor_v1 [INFO] frobbed toml for amerelo/Computor_v1 written to work/ex/clippy-test-run/sources/stable/gh/amerelo/Computor_v1/Cargo.toml [INFO] started frobbing amerelo/Computor_v1 [INFO] finished frobbing amerelo/Computor_v1 [INFO] frobbed toml for amerelo/Computor_v1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amerelo/Computor_v1/Cargo.toml [INFO] crate amerelo/Computor_v1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amerelo/Computor_v1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amerelo/Computor_v1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c584f937f0710c188a9279b0f510b402c9af45851efe83829d64d33caed57c2 [INFO] running `"docker" "start" "-a" "2c584f937f0710c188a9279b0f510b402c9af45851efe83829d64d33caed57c2"` [INFO] [stderr] Checking computor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:54 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:54 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | self.lista.push(Elem {signe: signe, value: value * -1.0, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:60:60 [INFO] [stderr] | [INFO] [stderr] 60 | self.lista.push(Elem {signe: signe, value: value * -1.0, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:44:54 [INFO] [stderr] | [INFO] [stderr] 44 | self.lista.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:47:54 [INFO] [stderr] | [INFO] [stderr] 47 | self.listb.push(Elem {signe: signe, value: value, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | self.lista.push(Elem {signe: signe, value: value * -1.0, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_module/module.rs:60:60 [INFO] [stderr] | [INFO] [stderr] 60 | self.lista.push(Elem {signe: signe, value: value * -1.0, power: power}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return max_power; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 58 | | if degree == 2.0 { [INFO] [stderr] 59 | | Solver::solve2(&module); [INFO] [stderr] 60 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | } else if degree == 2.0 { [INFO] [stderr] 58 | Solver::solve2(&module); [INFO] [stderr] 59 | } [INFO] [stderr] 60 | else if degree == 1.0 { [INFO] [stderr] 61 | module.redu_1(); [INFO] [stderr] 62 | Solver::solve1(&mut module); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_module/module.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return max_power; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 58 | | if degree == 2.0 { [INFO] [stderr] 59 | | Solver::solve2(&module); [INFO] [stderr] 60 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | } else if degree == 2.0 { [INFO] [stderr] 58 | Solver::solve2(&module); [INFO] [stderr] 59 | } [INFO] [stderr] 60 | else if degree == 1.0 { [INFO] [stderr] 61 | module.redu_1(); [INFO] [stderr] 62 | Solver::solve1(&mut module); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | if self.state == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | if power == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(power - elem.power).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | if power == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | while self.listb.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.listb.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if self.lista[i].power == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.lista[i].power - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if self.lista[i].power == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | tmp.value = tmp.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | len = len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/list_module/module.rs:95:7 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | if !(!elem.value > 0.0 && !elem.value < 0.0 || elem.signe != false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 95 | if (elem.value > 0.0 || elem.value < 0.0) && elem.signe == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/list_module/module.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | if !(!elem.value > 0.0 && !elem.value < 0.0 || elem.signe != false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 103 | if (elem.value > 0.0 || elem.value < 0.0) && elem.signe == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:95:73 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | elem.value = elem.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:103:73 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | elem.value = elem.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | if i == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(i - elem.power).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | if i == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | tmp.value = tmp.value + elem.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp.value += elem.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:131:3 [INFO] [stderr] | [INFO] [stderr] 131 | i = i + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += 1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:143:4 [INFO] [stderr] | [INFO] [stderr] 143 | i = i + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += 1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/degree2_module/solver.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn get_value(list: &Vec, find: f32) -> f32 [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Elem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/degree2_module/solver.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | if elem.power == find { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(elem.power - find).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/degree2_module/solver.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | if elem.power == find { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/degree2_module/solver.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | if var1 == var2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(var1 - var2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/degree2_module/solver.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | if var1 == var2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/degree2_module/solver.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | elem.lista[0].value = elem.lista[0].value / elem.listb[0].value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.lista[0].value /= elem.listb[0].value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | fn execut(str: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | if let &Some(_m) = &cap[3].find('.') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(_m) = cap[3].find('.') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | if let &Some(_m) = &cap[3].find('-') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | if let Some(_m) = cap[3].find('-') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | signe = if &cap[1] == "+" {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `&cap[1] == "+"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | if flag == false || module.lista.is_empty() || module.listb.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if degree == 2.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(degree - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if degree == 2.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | else if degree == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(degree - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | else if degree == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `computor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | if self.state == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | if power == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(power - elem.power).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | if power == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | while self.listb.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.listb.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if self.lista[i].power == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.lista[i].power - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | if self.lista[i].power == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | tmp.value = tmp.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | len = len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/list_module/module.rs:95:7 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | if !(!elem.value > 0.0 && !elem.value < 0.0 || elem.signe != false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 95 | if (elem.value > 0.0 || elem.value < 0.0) && elem.signe == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/list_module/module.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | if !(!elem.value > 0.0 && !elem.value < 0.0 || elem.signe != false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 103 | if (elem.value > 0.0 || elem.value < 0.0) && elem.signe == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:95:73 [INFO] [stderr] | [INFO] [stderr] 95 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | elem.value = elem.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/list_module/module.rs:103:73 [INFO] [stderr] | [INFO] [stderr] 103 | if (elem.value > 0.0 && elem.signe == false) || (elem.value < 0.0 && elem.signe == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!elem.signe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | elem.value = elem.value * -1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.value *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/list_module/module.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | if i == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(i - elem.power).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/list_module/module.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | if i == elem.power { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | tmp.value = tmp.value + elem.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp.value += elem.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:131:3 [INFO] [stderr] | [INFO] [stderr] 131 | i = i + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += 1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list_module/module.rs:143:4 [INFO] [stderr] | [INFO] [stderr] 143 | i = i + 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += 1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/degree2_module/solver.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn get_value(list: &Vec, find: f32) -> f32 [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Elem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/degree2_module/solver.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | if elem.power == find { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(elem.power - find).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/degree2_module/solver.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | if elem.power == find { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/degree2_module/solver.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | if var1 == var2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(var1 - var2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/degree2_module/solver.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | if var1 == var2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/degree2_module/solver.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | elem.lista[0].value = elem.lista[0].value / elem.listb[0].value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem.lista[0].value /= elem.listb[0].value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | fn execut(str: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | if let &Some(_m) = &cap[3].find('.') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(_m) = cap[3].find('.') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | if let &Some(_m) = &cap[3].find('-') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | if let Some(_m) = cap[3].find('-') { println!("polynomial not valid"); process::exit(0x0f00); } [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | signe = if &cap[1] == "+" {true} else {false}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `&cap[1] == "+"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | if flag == false || module.lista.is_empty() || module.listb.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if degree == 2.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(degree - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | if degree == 2.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | else if degree == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(degree - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | else if degree == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `computor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2c584f937f0710c188a9279b0f510b402c9af45851efe83829d64d33caed57c2"` [INFO] running `"docker" "rm" "-f" "2c584f937f0710c188a9279b0f510b402c9af45851efe83829d64d33caed57c2"` [INFO] [stdout] 2c584f937f0710c188a9279b0f510b402c9af45851efe83829d64d33caed57c2