[INFO] updating cached repository ambadoom/aes
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ambadoom/aes
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ambadoom/aes" "work/ex/clippy-test-run/sources/stable/gh/ambadoom/aes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ambadoom/aes'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ambadoom/aes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ambadoom/aes"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ambadoom/aes'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b88a48b8e833213a7c153a620f275c8beaf1c1af
[INFO] sha for GitHub repo ambadoom/aes: b88a48b8e833213a7c153a620f275c8beaf1c1af
[INFO] validating manifest of ambadoom/aes on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ambadoom/aes on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ambadoom/aes
[INFO] finished frobbing ambadoom/aes
[INFO] frobbed toml for ambadoom/aes written to work/ex/clippy-test-run/sources/stable/gh/ambadoom/aes/Cargo.toml
[INFO] started frobbing ambadoom/aes
[INFO] finished frobbing ambadoom/aes
[INFO] frobbed toml for ambadoom/aes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ambadoom/aes/Cargo.toml
[INFO] crate ambadoom/aes has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ambadoom/aes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ambadoom/aes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb1a587b59c6590865eacaf6b745e1f4e32da07c62f74187afaa9ee1c4a99f2e
[INFO] running `"docker" "start" "-a" "cb1a587b59c6590865eacaf6b745e1f4e32da07c62f74187afaa9ee1c4a99f2e"`
[INFO] [stderr]     Checking aes v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:5
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return Some(&count) == last;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&count) == last`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:103:5
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return Some(&count) == last;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&count) == last`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tmp`.
[INFO] [stderr]    --> src/aes.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for i in 0..4 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for <item> in tmp.iter().take(4) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/aes.rs:174:14
[INFO] [stderr]     |
[INFO] [stderr] 174 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^ help: try replacing the loop by: `state[..16].clone_from_slice(&block[..16])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aes.rs:210:16
[INFO] [stderr]     |
[INFO] [stderr] 210 |     let copy = state.clone();
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: try dereferencing it: `*state`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `state`
[INFO] [stderr]    --> src/aes.rs:211:14
[INFO] [stderr]     |
[INFO] [stderr] 211 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 211 |     for (i, <item>) in state.iter_mut().enumerate().take(16) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:221:24
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let b0 = state[4*i+0];
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:225:15
[INFO] [stderr]     |
[INFO] [stderr] 225 |         state[4*i+0] = gf_multiply(2, b0) ^ gf_multiply(3, b1) ^ b2 ^ b3;
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/aes.rs:237:14
[INFO] [stderr]     |
[INFO] [stderr] 237 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^ help: try replacing the loop by: `state[..16].clone_from_slice(&block[..16])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aes.rs:267:16
[INFO] [stderr]     |
[INFO] [stderr] 267 |     let copy = state.clone();
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: try dereferencing it: `*state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `state`
[INFO] [stderr]    --> src/aes.rs:268:14
[INFO] [stderr]     |
[INFO] [stderr] 268 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 268 |     for (i, <item>) in state.iter_mut().enumerate().take(16) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:278:24
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let b0 = state[4*i+0];
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:282:15
[INFO] [stderr]     |
[INFO] [stderr] 282 |         state[4*i+0] = gf_multiply(14, b0) ^ gf_multiply(11, b1) ^ gf_multiply(13, b2) ^ gf_multiply(9, b3);
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/lib.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..16 { previous[i] = iv[i]; }
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `previous[..16].clone_from_slice(&iv[..16])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/lib.rs:55:14
[INFO] [stderr]    |
[INFO] [stderr] 55 |     for i in 0..16 { previous[i] = iv[i]; }
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `previous[..16].clone_from_slice(&iv[..16])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tmp`.
[INFO] [stderr]    --> src/aes.rs:135:18
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for i in 0..4 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for <item> in tmp.iter().take(4) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/aes.rs:174:14
[INFO] [stderr]     |
[INFO] [stderr] 174 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^ help: try replacing the loop by: `state[..16].clone_from_slice(&block[..16])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aes.rs:210:16
[INFO] [stderr]     |
[INFO] [stderr] 210 |     let copy = state.clone();
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: try dereferencing it: `*state`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `state`
[INFO] [stderr]    --> src/aes.rs:211:14
[INFO] [stderr]     |
[INFO] [stderr] 211 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 211 |     for (i, <item>) in state.iter_mut().enumerate().take(16) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:221:24
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let b0 = state[4*i+0];
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:225:15
[INFO] [stderr]     |
[INFO] [stderr] 225 |         state[4*i+0] = gf_multiply(2, b0) ^ gf_multiply(3, b1) ^ b2 ^ b3;
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/aes.rs:237:14
[INFO] [stderr]     |
[INFO] [stderr] 237 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^ help: try replacing the loop by: `state[..16].clone_from_slice(&block[..16])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aes.rs:267:16
[INFO] [stderr]     |
[INFO] [stderr] 267 |     let copy = state.clone();
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: try dereferencing it: `*state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `state`
[INFO] [stderr]    --> src/aes.rs:268:14
[INFO] [stderr]     |
[INFO] [stderr] 268 |     for i in 0..16 {
[INFO] [stderr]     |              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 268 |     for (i, <item>) in state.iter_mut().enumerate().take(16) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:278:24
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let b0 = state[4*i+0];
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i`
[INFO] [stderr]    --> src/aes.rs:282:15
[INFO] [stderr]     |
[INFO] [stderr] 282 |         state[4*i+0] = gf_multiply(14, b0) ^ gf_multiply(11, b1) ^ gf_multiply(13, b2) ^ gf_multiply(9, b3);
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/lib.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..16 { previous[i] = iv[i]; }
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `previous[..16].clone_from_slice(&iv[..16])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/lib.rs:55:14
[INFO] [stderr]    |
[INFO] [stderr] 55 |     for i in 0..16 { previous[i] = iv[i]; }
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `previous[..16].clone_from_slice(&iv[..16])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.91s
[INFO] running `"docker" "inspect" "cb1a587b59c6590865eacaf6b745e1f4e32da07c62f74187afaa9ee1c4a99f2e"`
[INFO] running `"docker" "rm" "-f" "cb1a587b59c6590865eacaf6b745e1f4e32da07c62f74187afaa9ee1c4a99f2e"`
[INFO] [stdout] cb1a587b59c6590865eacaf6b745e1f4e32da07c62f74187afaa9ee1c4a99f2e