[INFO] updating cached repository amarant/codecon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/amarant/codecon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/amarant/codecon" "work/ex/clippy-test-run/sources/stable/gh/amarant/codecon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/amarant/codecon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/amarant/codecon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amarant/codecon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amarant/codecon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89b6d56043f518b3b7d5b4cde3a7b670728f8875 [INFO] sha for GitHub repo amarant/codecon: 89b6d56043f518b3b7d5b4cde3a7b670728f8875 [INFO] validating manifest of amarant/codecon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amarant/codecon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amarant/codecon [INFO] finished frobbing amarant/codecon [INFO] frobbed toml for amarant/codecon written to work/ex/clippy-test-run/sources/stable/gh/amarant/codecon/Cargo.toml [INFO] started frobbing amarant/codecon [INFO] finished frobbing amarant/codecon [INFO] frobbed toml for amarant/codecon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amarant/codecon/Cargo.toml [INFO] crate amarant/codecon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amarant/codecon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/amarant/codecon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aeec7c9378bf9a7a9ca98da7500acfeb113a59ab9932d44d66a5d826a770f034 [INFO] running `"docker" "start" "-a" "aeec7c9378bf9a7a9ca98da7500acfeb113a59ab9932d44d66a5d826a770f034"` [INFO] [stderr] Checking codecon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/messed_up_rugby.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | HandEggScore { conversions:conversions, tries:tries, kicks:kicks } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conversions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/messed_up_rugby.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | HandEggScore { conversions:conversions, tries:tries, kicks:kicks } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `tries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/messed_up_rugby.rs:36:58 [INFO] [stderr] | [INFO] [stderr] 36 | HandEggScore { conversions:conversions, tries:tries, kicks:kicks } [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `kicks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/messed_up_rugby.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/messed_up_rugby.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/laundry_day.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/laundry_day.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/expecto_palindronum.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | if both.all(|(f, r)| {f == r}) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/messed_up_rugby.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Hash, Eq, Clone)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/messed_up_rugby.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | / impl PartialEq for HandEggScore { [INFO] [stderr] 45 | | fn eq(&self, other: &HandEggScore) -> bool { [INFO] [stderr] 46 | | self.conversions == other.conversions [INFO] [stderr] 47 | | && self.tries == other.tries [INFO] [stderr] 48 | | && self.kicks == other.kicks [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/messed_up_rugby.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | for conversion in 0..(target_score/7 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=target_score/7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/messed_up_rugby.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | for trie in 0..((target_score - conversion*7)/3 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=(target_score - conversion*7)/3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/messed_up_rugby.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | for kick in 0..((target_score - conversion*7 - trie*3)/2 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=(target_score - conversion*7 - trie*3)/2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `codecon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/base_arithmetic.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | fn find_min_base(num: &String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/base_arithmetic.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | fn find_min_base(num: &String) -> Option{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "aeec7c9378bf9a7a9ca98da7500acfeb113a59ab9932d44d66a5d826a770f034"` [INFO] running `"docker" "rm" "-f" "aeec7c9378bf9a7a9ca98da7500acfeb113a59ab9932d44d66a5d826a770f034"` [INFO] [stdout] aeec7c9378bf9a7a9ca98da7500acfeb113a59ab9932d44d66a5d826a770f034