[INFO] updating cached repository alienonolympus/FizzBuzzWoof [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alienonolympus/FizzBuzzWoof [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alienonolympus/FizzBuzzWoof" "work/ex/clippy-test-run/sources/stable/gh/alienonolympus/FizzBuzzWoof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alienonolympus/FizzBuzzWoof'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alienonolympus/FizzBuzzWoof" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alienonolympus/FizzBuzzWoof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alienonolympus/FizzBuzzWoof'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22bf4672e9ecf5edf66c8f5eb1031dc3c7327764 [INFO] sha for GitHub repo alienonolympus/FizzBuzzWoof: 22bf4672e9ecf5edf66c8f5eb1031dc3c7327764 [INFO] validating manifest of alienonolympus/FizzBuzzWoof on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alienonolympus/FizzBuzzWoof on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alienonolympus/FizzBuzzWoof [INFO] finished frobbing alienonolympus/FizzBuzzWoof [INFO] frobbed toml for alienonolympus/FizzBuzzWoof written to work/ex/clippy-test-run/sources/stable/gh/alienonolympus/FizzBuzzWoof/Cargo.toml [INFO] started frobbing alienonolympus/FizzBuzzWoof [INFO] finished frobbing alienonolympus/FizzBuzzWoof [INFO] frobbed toml for alienonolympus/FizzBuzzWoof written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alienonolympus/FizzBuzzWoof/Cargo.toml [INFO] crate alienonolympus/FizzBuzzWoof has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alienonolympus/FizzBuzzWoof against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alienonolympus/FizzBuzzWoof:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c77f45f2af5d575e95257b983de439d6adc1d8758f3bca546f6207632339f66b [INFO] running `"docker" "start" "-a" "c77f45f2af5d575e95257b983de439d6adc1d8758f3bca546f6207632339f66b"` [INFO] [stderr] Checking fizzbuzzwoof v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/interpreter/process.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/interpreter/process.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/process.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return printed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `printed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/process.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return printed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `printed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return self.start; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.end; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/process.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return printed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `printed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/process.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return printed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `printed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return self.start; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.end; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/input.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/interpreter/process.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut printed = false; [INFO] [stderr] 32 | | [INFO] [stderr] 33 | | //Multiple tests [INFO] [stderr] 34 | | if input % 3 == 0 { [INFO] [stderr] 35 | | print!("Fizz "); [INFO] [stderr] 36 | | printed = true; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let printed = if input % 3 == 0 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/process.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | let evaluate1 = test4repeat(input.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/process.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | let evaluate2 = test4multiple(input.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/interpreter/input.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / let mut end = start; [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | if input.len() > 1 { [INFO] [stderr] 83 | | end = input[1].to_string() [INFO] [stderr] 84 | | .parse::() [INFO] [stderr] 85 | | .unwrap_or(0); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 80 | let end = if input.len() > 1 { input[1].to_string() [INFO] [stderr] 81 | .parse::() [INFO] [stderr] 82 | .unwrap_or(0) } else { start }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/interpreter/input.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | if temp.to_lowercase() == "exit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"exit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/interpreter/mod.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | if result.extra == "Exit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"Exit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interpreter/mod.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | for count in result.start()..result.end() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `result.start()..=result.end()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/mod.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let input = count.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/interpreter/process.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / let mut printed = false; [INFO] [stderr] 32 | | [INFO] [stderr] 33 | | //Multiple tests [INFO] [stderr] 34 | | if input % 3 == 0 { [INFO] [stderr] 35 | | print!("Fizz "); [INFO] [stderr] 36 | | printed = true; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let printed = if input % 3 == 0 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/process.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | let evaluate1 = test4repeat(input.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/process.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | let evaluate2 = test4multiple(input.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/interpreter/input.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / let mut end = start; [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | if input.len() > 1 { [INFO] [stderr] 83 | | end = input[1].to_string() [INFO] [stderr] 84 | | .parse::() [INFO] [stderr] 85 | | .unwrap_or(0); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 80 | let end = if input.len() > 1 { input[1].to_string() [INFO] [stderr] 81 | .parse::() [INFO] [stderr] 82 | .unwrap_or(0) } else { start }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/interpreter/input.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | if temp.to_lowercase() == "exit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"exit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/interpreter/mod.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | if result.extra == "Exit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"Exit"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interpreter/mod.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | for count in result.start()..result.end() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `result.start()..=result.end()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter/mod.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let input = count.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "c77f45f2af5d575e95257b983de439d6adc1d8758f3bca546f6207632339f66b"` [INFO] running `"docker" "rm" "-f" "c77f45f2af5d575e95257b983de439d6adc1d8758f3bca546f6207632339f66b"` [INFO] [stdout] c77f45f2af5d575e95257b983de439d6adc1d8758f3bca546f6207632339f66b