[INFO] updating cached repository algesten/qstring
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/algesten/qstring
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/algesten/qstring" "work/ex/clippy-test-run/sources/stable/gh/algesten/qstring"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/algesten/qstring'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/algesten/qstring" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/algesten/qstring"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/algesten/qstring'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f869c715a066c846b283392975a4e05b2a376edc
[INFO] sha for GitHub repo algesten/qstring: f869c715a066c846b283392975a4e05b2a376edc
[INFO] validating manifest of algesten/qstring on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of algesten/qstring on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing algesten/qstring
[INFO] finished frobbing algesten/qstring
[INFO] frobbed toml for algesten/qstring written to work/ex/clippy-test-run/sources/stable/gh/algesten/qstring/Cargo.toml
[INFO] started frobbing algesten/qstring
[INFO] finished frobbing algesten/qstring
[INFO] frobbed toml for algesten/qstring written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/algesten/qstring/Cargo.toml
[INFO] crate algesten/qstring has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting algesten/qstring against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/algesten/qstring:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] edd3c160f68f5093f64e7ee121785c42529accb751bd92ea4ecd1771adc12849
[INFO] running `"docker" "start" "-a" "edd3c160f68f5093f64e7ee121785c42529accb751bd92ea4ecd1771adc12849"`
[INFO] [stderr]     Checking qstring v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/lib.rs:84:9
[INFO] [stderr]    |
[INFO] [stderr] 84 |         self.pairs.iter().find(|p| p.0 == name).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|p| p.0 == name).is_some()` with `any(|p| p.0 == name)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:222:8
[INFO] [stderr]     |
[INFO] [stderr] 222 |     if cur.len() > 0 && &cur[0..1] == "?" {
[INFO] [stderr]     |        ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:229:11
[INFO] [stderr]     |
[INFO] [stderr] 229 |     while cur.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:236:43
[INFO] [stderr]     |
[INFO] [stderr] 236 |         let (name, rest) = match cur.find("=") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:238:36
[INFO] [stderr]     |
[INFO] [stderr] 238 |             None => match cur.find("&") {
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:256:12
[INFO] [stderr]     |
[INFO] [stderr] 256 |         if name.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:261:47
[INFO] [stderr]     |
[INFO] [stderr] 261 |         let (value, newcur) = match rest.find("&") {
[INFO] [stderr]     |                                               ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/lib.rs:84:9
[INFO] [stderr]    |
[INFO] [stderr] 84 |         self.pairs.iter().find(|p| p.0 == name).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|p| p.0 == name).is_some()` with `any(|p| p.0 == name)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:222:8
[INFO] [stderr]     |
[INFO] [stderr] 222 |     if cur.len() > 0 && &cur[0..1] == "?" {
[INFO] [stderr]     |        ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:229:11
[INFO] [stderr]     |
[INFO] [stderr] 229 |     while cur.len() > 0 {
[INFO] [stderr]     |           ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cur.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:236:43
[INFO] [stderr]     |
[INFO] [stderr] 236 |         let (name, rest) = match cur.find("=") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:238:36
[INFO] [stderr]     |
[INFO] [stderr] 238 |             None => match cur.find("&") {
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:256:12
[INFO] [stderr]     |
[INFO] [stderr] 256 |         if name.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:261:47
[INFO] [stderr]     |
[INFO] [stderr] 261 |         let (value, newcur) = match rest.find("&") {
[INFO] [stderr]     |                                               ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "edd3c160f68f5093f64e7ee121785c42529accb751bd92ea4ecd1771adc12849"`
[INFO] running `"docker" "rm" "-f" "edd3c160f68f5093f64e7ee121785c42529accb751bd92ea4ecd1771adc12849"`
[INFO] [stdout] edd3c160f68f5093f64e7ee121785c42529accb751bd92ea4ecd1771adc12849