[INFO] updating cached repository alexmitic/preloy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexmitic/preloy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexmitic/preloy" "work/ex/clippy-test-run/sources/stable/gh/alexmitic/preloy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexmitic/preloy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexmitic/preloy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexmitic/preloy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexmitic/preloy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3e534a9cb862c2d53c51d4526ed64628d38ccfc3 [INFO] sha for GitHub repo alexmitic/preloy: 3e534a9cb862c2d53c51d4526ed64628d38ccfc3 [INFO] validating manifest of alexmitic/preloy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexmitic/preloy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexmitic/preloy [INFO] finished frobbing alexmitic/preloy [INFO] frobbed toml for alexmitic/preloy written to work/ex/clippy-test-run/sources/stable/gh/alexmitic/preloy/Cargo.toml [INFO] started frobbing alexmitic/preloy [INFO] finished frobbing alexmitic/preloy [INFO] frobbed toml for alexmitic/preloy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexmitic/preloy/Cargo.toml [INFO] crate alexmitic/preloy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexmitic/preloy against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexmitic/preloy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89c9c3c42c3bc935b0c9e637ea5d44bc89dc2342bc468cf8d492422a7cfc6e31 [INFO] running `"docker" "start" "-a" "89c9c3c42c3bc935b0c9e637ea5d44bc89dc2342bc468cf8d492422a7cfc6e31"` [INFO] [stderr] Checking preloy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | let mut home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | let mut home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:60 [INFO] [stderr] | [INFO] [stderr] 37 | fn move_folder(home: String, target: String, destinations: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | let to = target.as_str().to_owned() + dest.as_str() + &path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | fn find_target(target: &str, destinations: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | fn should_delete(target: &str, destinations: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | fn clear_target(target: &String, destinations: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:174:48 [INFO] [stderr] | [INFO] [stderr] 174 | fn clear_target(target: &String, destinations: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:60 [INFO] [stderr] | [INFO] [stderr] 37 | fn move_folder(home: String, target: String, destinations: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | let to = target.as_str().to_owned() + dest.as_str() + &path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | fn find_target(target: &str, destinations: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | fn should_delete(target: &str, destinations: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | fn clear_target(target: &String, destinations: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:174:48 [INFO] [stderr] | [INFO] [stderr] 174 | fn clear_target(target: &String, destinations: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dest]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "89c9c3c42c3bc935b0c9e637ea5d44bc89dc2342bc468cf8d492422a7cfc6e31"` [INFO] running `"docker" "rm" "-f" "89c9c3c42c3bc935b0c9e637ea5d44bc89dc2342bc468cf8d492422a7cfc6e31"` [INFO] [stdout] 89c9c3c42c3bc935b0c9e637ea5d44bc89dc2342bc468cf8d492422a7cfc6e31