[INFO] updating cached repository alexanderbez/rust-merge-sort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexanderbez/rust-merge-sort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexanderbez/rust-merge-sort" "work/ex/clippy-test-run/sources/stable/gh/alexanderbez/rust-merge-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexanderbez/rust-merge-sort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexanderbez/rust-merge-sort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderbez/rust-merge-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderbez/rust-merge-sort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 62b3042c972cc5b472e91df147a6991c7f93c138 [INFO] sha for GitHub repo alexanderbez/rust-merge-sort: 62b3042c972cc5b472e91df147a6991c7f93c138 [INFO] validating manifest of alexanderbez/rust-merge-sort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexanderbez/rust-merge-sort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexanderbez/rust-merge-sort [INFO] finished frobbing alexanderbez/rust-merge-sort [INFO] frobbed toml for alexanderbez/rust-merge-sort written to work/ex/clippy-test-run/sources/stable/gh/alexanderbez/rust-merge-sort/Cargo.toml [INFO] started frobbing alexanderbez/rust-merge-sort [INFO] finished frobbing alexanderbez/rust-merge-sort [INFO] frobbed toml for alexanderbez/rust-merge-sort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderbez/rust-merge-sort/Cargo.toml [INFO] crate alexanderbez/rust-merge-sort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexanderbez/rust-merge-sort against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderbez/rust-merge-sort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2386f68f57ea39ebd30080e727311521669a976dbd80e6939f573a947f33973c [INFO] running `"docker" "start" "-a" "2386f68f57ea39ebd30080e727311521669a976dbd80e6939f573a947f33973c"` [INFO] [stderr] Checking rust-merge-sort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:14 [INFO] [stderr] | [INFO] [stderr] 8 | fn merge(l1: &Vec, s: usize, m: usize, e: usize, l2: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `l2`. [INFO] [stderr] --> src/lib.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for i in s..e { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for in l2.iter_mut().take(e).skip(s) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | fn merge_copy(l1: &mut Vec, s: usize, e: usize, l2: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:8:14 [INFO] [stderr] | [INFO] [stderr] 8 | fn merge(l1: &Vec, s: usize, m: usize, e: usize, l2: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `l2`. [INFO] [stderr] --> src/lib.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for i in s..e { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for in l2.iter_mut().take(e).skip(s) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | fn merge_copy(l1: &mut Vec, s: usize, e: usize, l2: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/sort.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | let mut example_list: Vec = vec![234234, 9, 4, 5, 99, 1,-3, 0, -1]; [INFO] [stderr] | ^^^^^^ help: consider: `234_234` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "2386f68f57ea39ebd30080e727311521669a976dbd80e6939f573a947f33973c"` [INFO] running `"docker" "rm" "-f" "2386f68f57ea39ebd30080e727311521669a976dbd80e6939f573a947f33973c"` [INFO] [stdout] 2386f68f57ea39ebd30080e727311521669a976dbd80e6939f573a947f33973c