[INFO] updating cached repository alec-chan/RustSort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alec-chan/RustSort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alec-chan/RustSort" "work/ex/clippy-test-run/sources/stable/gh/alec-chan/RustSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alec-chan/RustSort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alec-chan/RustSort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alec-chan/RustSort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alec-chan/RustSort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d75364cb33ae2607b37789bdb8387b136e59d45c [INFO] sha for GitHub repo alec-chan/RustSort: d75364cb33ae2607b37789bdb8387b136e59d45c [INFO] validating manifest of alec-chan/RustSort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alec-chan/RustSort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alec-chan/RustSort [INFO] finished frobbing alec-chan/RustSort [INFO] frobbed toml for alec-chan/RustSort written to work/ex/clippy-test-run/sources/stable/gh/alec-chan/RustSort/Cargo.toml [INFO] started frobbing alec-chan/RustSort [INFO] finished frobbing alec-chan/RustSort [INFO] frobbed toml for alec-chan/RustSort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alec-chan/RustSort/Cargo.toml [INFO] crate alec-chan/RustSort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alec-chan/RustSort against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alec-chan/RustSort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ced7bd027d82d60e57e58a6b0e93777bb57ef0cb41726fb25f944be8df036be0 [INFO] running `"docker" "start" "-a" "ced7bd027d82d60e57e58a6b0e93777bb57ef0cb41726fb25f944be8df036be0"` [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | SortData { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | SortData { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | j=j-1; [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `input` manually [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | / let temp = input[j]; [INFO] [stderr] 61 | | input[j] = input[j+1]; [INFO] [stderr] 62 | | input[j+1] = temp; [INFO] [stderr] | |_____________________________________^ help: try: `input.swap(j, j+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | j=j-1; [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `input` manually [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | / let temp = input[j]; [INFO] [stderr] 61 | | input[j] = input[j+1]; [INFO] [stderr] 62 | | input[j+1] = temp; [INFO] [stderr] | |_____________________________________^ help: try: `input.swap(j, j+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "ced7bd027d82d60e57e58a6b0e93777bb57ef0cb41726fb25f944be8df036be0"` [INFO] running `"docker" "rm" "-f" "ced7bd027d82d60e57e58a6b0e93777bb57ef0cb41726fb25f944be8df036be0"` [INFO] [stdout] ced7bd027d82d60e57e58a6b0e93777bb57ef0cb41726fb25f944be8df036be0