[INFO] updating cached repository ak1t0/semu
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ak1t0/semu
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ak1t0/semu" "work/ex/clippy-test-run/sources/stable/gh/ak1t0/semu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ak1t0/semu'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ak1t0/semu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1t0/semu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1t0/semu'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 310f411b9e11f88889e4154924252434719cc3ad
[INFO] sha for GitHub repo ak1t0/semu: 310f411b9e11f88889e4154924252434719cc3ad
[INFO] validating manifest of ak1t0/semu on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ak1t0/semu on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ak1t0/semu
[INFO] finished frobbing ak1t0/semu
[INFO] frobbed toml for ak1t0/semu written to work/ex/clippy-test-run/sources/stable/gh/ak1t0/semu/Cargo.toml
[INFO] started frobbing ak1t0/semu
[INFO] finished frobbing ak1t0/semu
[INFO] frobbed toml for ak1t0/semu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1t0/semu/Cargo.toml
[INFO] crate ak1t0/semu has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ak1t0/semu against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1t0/semu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8210a4bab0f37d09095c1fe4c411f9f8fe9151ec258bfcefbbd020c673d52c7
[INFO] running `"docker" "start" "-a" "a8210a4bab0f37d09095c1fe4c411f9f8fe9151ec258bfcefbbd020c673d52c7"`
[INFO] [stderr]     Checking semu v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     println!("");
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:121:5
[INFO] [stderr]     |
[INFO] [stderr] 121 |     println!("");
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return emu
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `emu`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return (buffer, size)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(buffer, size)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return data
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:90:5
[INFO] [stderr]    |
[INFO] [stderr] 90 |     return data as i8;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data as i8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return (data1, data2)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(data1, data2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return data4 * (256 * 256 * 256) + data3 * (256 * 256) + data2 * 256 + data1
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data4 * (256 * 256 * 256) + data3 * (256 * 256) + data2 * 256 + data1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     return emu
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `emu`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return (buffer, size)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(buffer, size)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return data
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:90:5
[INFO] [stderr]    |
[INFO] [stderr] 90 |     return data as i8;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data as i8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return (data1, data2)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(data1, data2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return data4 * (256 * 256 * 256) + data3 * (256 * 256) + data2 * 256 + data1
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data4 * (256 * 256 * 256) + data3 * (256 * 256) + data2 * 256 + data1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `v`
[INFO] [stderr]   --> src/main.rs:17:14
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for i in 0..v.len() {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for (i, <item>) in v.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/main.rs:17:14
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for i in 0..v.len() {
[INFO] [stderr]    |              ^^^^^^^^^^ help: try replacing the loop by: `emu.memory[..v.len()].clone_from_slice(&v[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:77:20
[INFO] [stderr]    |
[INFO] [stderr] 77 |     let jmp_size = get_data_i8(emu, 1) as i32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(get_data_i8(emu, 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:102:17
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let data1 = emu.memory[pointer as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[pointer as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:103:17
[INFO] [stderr]     |
[INFO] [stderr] 103 |     let data2 = emu.memory[(pointer + 1) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 1) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:104:17
[INFO] [stderr]     |
[INFO] [stderr] 104 |     let data3 = emu.memory[(pointer + 2) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 2) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:105:17
[INFO] [stderr]     |
[INFO] [stderr] 105 |     let data4 = emu.memory[(pointer + 3) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 3) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `v`
[INFO] [stderr]   --> src/main.rs:17:14
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for i in 0..v.len() {
[INFO] [stderr]    |              ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for (i, <item>) in v.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/main.rs:17:14
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for i in 0..v.len() {
[INFO] [stderr]    |              ^^^^^^^^^^ help: try replacing the loop by: `emu.memory[..v.len()].clone_from_slice(&v[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:77:20
[INFO] [stderr]    |
[INFO] [stderr] 77 |     let jmp_size = get_data_i8(emu, 1) as i32;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(get_data_i8(emu, 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:102:17
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let data1 = emu.memory[pointer as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[pointer as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:103:17
[INFO] [stderr]     |
[INFO] [stderr] 103 |     let data2 = emu.memory[(pointer + 1) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 1) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:104:17
[INFO] [stderr]     |
[INFO] [stderr] 104 |     let data3 = emu.memory[(pointer + 2) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 2) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:105:17
[INFO] [stderr]     |
[INFO] [stderr] 105 |     let data4 = emu.memory[(pointer + 3) as usize] as i32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(emu.memory[(pointer + 3) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.88s
[INFO] running `"docker" "inspect" "a8210a4bab0f37d09095c1fe4c411f9f8fe9151ec258bfcefbbd020c673d52c7"`
[INFO] running `"docker" "rm" "-f" "a8210a4bab0f37d09095c1fe4c411f9f8fe9151ec258bfcefbbd020c673d52c7"`
[INFO] [stdout] a8210a4bab0f37d09095c1fe4c411f9f8fe9151ec258bfcefbbd020c673d52c7