[INFO] updating cached repository ajmwagar/calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajmwagar/calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajmwagar/calc" "work/ex/clippy-test-run/sources/stable/gh/ajmwagar/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajmwagar/calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajmwagar/calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmwagar/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmwagar/calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e2d1035d0a00c36c97a4a8fd3167ab5678f5a59 [INFO] sha for GitHub repo ajmwagar/calc: 5e2d1035d0a00c36c97a4a8fd3167ab5678f5a59 [INFO] validating manifest of ajmwagar/calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajmwagar/calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajmwagar/calc [INFO] finished frobbing ajmwagar/calc [INFO] frobbed toml for ajmwagar/calc written to work/ex/clippy-test-run/sources/stable/gh/ajmwagar/calc/Cargo.toml [INFO] started frobbing ajmwagar/calc [INFO] finished frobbing ajmwagar/calc [INFO] frobbed toml for ajmwagar/calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmwagar/calc/Cargo.toml [INFO] crate ajmwagar/calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajmwagar/calc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmwagar/calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d55052b9a2693a5475dcd9e06a81cc7d186c1665778809ab0bbc2d7a59acecca [INFO] running `"docker" "start" "-a" "d55052b9a2693a5475dcd9e06a81cc7d186c1665778809ab0bbc2d7a59acecca"` [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking calc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `rand::prelude::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if *&args.len() as i32 > 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | } else if *&args.len() as i32 > 2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let len: i32 = *&args.len() as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return calc(calc_arr, index + 1, val, false, ans); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calc(calc_arr, index + 1, val, false, ans)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | "quit" => return exit(0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `exit(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | "clear" => return clear(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clear()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | "help" => return "\n".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | _ => return parse(string.to_string(), ans) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse(string.to_string(), ans)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | "+" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | "-" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | "^" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | "*" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | "/" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | "%" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | "pi" => return PI, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | "ans" => return ans, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | _ => return string.parse::().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return res.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | return "Please enter a valid expression.".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Please enter a valid expression.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | return "Cleared!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Cleared!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return "Goodbye!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Goodbye!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 138 | "Cleared!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 140 | "Goodbye!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 142 | "Please enter a valid expression." => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::prelude::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if *&args.len() as i32 > 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | } else if *&args.len() as i32 > 2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let len: i32 = *&args.len() as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `args.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return calc(calc_arr, index + 1, val, false, ans); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calc(calc_arr, index + 1, val, false, ans)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | "quit" => return exit(0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `exit(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | "clear" => return clear(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `clear()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | "help" => return "\n".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | _ => return parse(string.to_string(), ans) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse(string.to_string(), ans)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | "+" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | "-" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | "^" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | "*" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | "/" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | "%" => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | "pi" => return PI, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | "ans" => return ans, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ans` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | _ => return string.parse::().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return res.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | return "Please enter a valid expression.".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Please enter a valid expression.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | return "Cleared!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Cleared!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return "Goodbye!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Goodbye!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return "Goodbye!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string_help` [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | let string_help = HELP.to_string(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_string_help` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `print` [INFO] [stderr] --> src/main.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | let print: bool; [INFO] [stderr] | ^^^^^ help: consider using `_print` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 138 | "Cleared!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 140 | "Goodbye!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 142 | "Please enter a valid expression." => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return "Goodbye!".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | fn parse(s: String, mut ans: f64) -> String { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string_help` [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | let string_help = HELP.to_string(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_string_help` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `print` [INFO] [stderr] --> src/main.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | let print: bool; [INFO] [stderr] | ^^^^^ help: consider using `_print` instead [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let mut command = ""; [INFO] [stderr] 23 | | // Check if the length of args has moret than one i.e argument passed [INFO] [stderr] 24 | | if *&args.len() as i32 > 1 { [INFO] [stderr] 25 | | command = &args[1]; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let command = if *&args.len() as i32 > 1 { &args[1] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | if calc_arr[index].contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | } else if calc_arr[index].contains("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | } else if calc_arr[index].contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | } else if calc_arr[index].contains("+") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | } else if calc_arr[index].contains("%") { [INFO] [stderr] | ^^^ help: try using a char instead: `'%'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | } else if calc_arr[index].contains("^") { [INFO] [stderr] | ^^^ help: try using a char instead: `'^'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | fn parse(s: String, mut ans: f64) -> String { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 138 | "Cleared!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 140 | "Goodbye!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 142 | "Please enter a valid expression." => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | calc_arr = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | calc_arr = com.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / let mut command = ""; [INFO] [stderr] 23 | | // Check if the length of args has moret than one i.e argument passed [INFO] [stderr] 24 | | if *&args.len() as i32 > 1 { [INFO] [stderr] 25 | | command = &args[1]; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let command = if *&args.len() as i32 > 1 { &args[1] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:37 [INFO] [stderr] | [INFO] [stderr] 73 | if calc_arr[index].contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | } else if calc_arr[index].contains("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | } else if calc_arr[index].contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | } else if calc_arr[index].contains("+") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | } else if calc_arr[index].contains("%") { [INFO] [stderr] | ^^^ help: try using a char instead: `'%'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | } else if calc_arr[index].contains("^") { [INFO] [stderr] | ^^^ help: try using a char instead: `'^'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 138 | "Cleared!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 140 | "Goodbye!" => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | loop { let _ = $xs; break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 142 | "Please enter a valid expression." => block!({ break; }), [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | calc_arr = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | calc_arr = com.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `calc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `calc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d55052b9a2693a5475dcd9e06a81cc7d186c1665778809ab0bbc2d7a59acecca"` [INFO] running `"docker" "rm" "-f" "d55052b9a2693a5475dcd9e06a81cc7d186c1665778809ab0bbc2d7a59acecca"` [INFO] [stdout] d55052b9a2693a5475dcd9e06a81cc7d186c1665778809ab0bbc2d7a59acecca