[INFO] updating cached repository aji/miau [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aji/miau [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aji/miau" "work/ex/clippy-test-run/sources/stable/gh/aji/miau"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aji/miau'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aji/miau" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aji/miau"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aji/miau'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3502b08fe59c63a891c712d52ad728bbe5c2033b [INFO] sha for GitHub repo aji/miau: 3502b08fe59c63a891c712d52ad728bbe5c2033b [INFO] validating manifest of aji/miau on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aji/miau on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aji/miau [INFO] finished frobbing aji/miau [INFO] frobbed toml for aji/miau written to work/ex/clippy-test-run/sources/stable/gh/aji/miau/Cargo.toml [INFO] started frobbing aji/miau [INFO] finished frobbing aji/miau [INFO] frobbed toml for aji/miau written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aji/miau/Cargo.toml [INFO] crate aji/miau has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aji/miau against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aji/miau:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26c76cbc6d7819e3e2c91ee42183ac203bcef93bd959a6e2cceba3451ad32423 [INFO] running `"docker" "start" "-a" "26c76cbc6d7819e3e2c91ee42183ac203bcef93bd959a6e2cceba3451ad32423"` [INFO] [stderr] Checking serde v0.9.13 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking bytes v0.4.2 [INFO] [stderr] Checking mio v0.6.6 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Checking miau v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bot.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bot.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | net: net, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `net` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | IrcContext { out: out, reply_to: m.args[0], reply_prefix: reply_prefix } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:115:57 [INFO] [stderr] | [INFO] [stderr] 115 | IrcContext { out: out, reply_to: m.args[0], reply_prefix: reply_prefix } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reply_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | IrcContext { out: out, reply_to: m.src.short_name(), reply_prefix: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | Scanner { s: s, c: s.char_indices().peekable() } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | src: src, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | verb: verb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `verb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | Network { env: env, state: State::Registering(reg) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bot.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bot.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | net: net, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `net` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | IrcContext { out: out, reply_to: m.args[0], reply_prefix: reply_prefix } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:115:57 [INFO] [stderr] | [INFO] [stderr] 115 | IrcContext { out: out, reply_to: m.args[0], reply_prefix: reply_prefix } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reply_prefix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | IrcContext { out: out, reply_to: m.src.short_name(), reply_prefix: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | Scanner { s: s, c: s.char_indices().peekable() } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | src: src, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | verb: verb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `verb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/irc.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | Network { env: env, state: State::Registering(reg) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | const CONFIG_ENV: &'static str = "MIAU_CONFIG"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | const OVERLAY_ENV: &'static str = "MIAU_OVERLAY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | const DEFAULT_CONFIG: &'static str = "config/miau-prod.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | const DEFAULT_OVERLAY: &'static str = "config/miau-dev.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/logging.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / if !record.location().module_path().starts_with("miau::") { [INFO] [stderr] 17 | | if record.level() > EXTERNAL_LOG_LEVEL { [INFO] [stderr] 18 | | return; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if !record.location().module_path().starts_with("miau::") && record.level() > EXTERNAL_LOG_LEVEL { [INFO] [stderr] 17 | return; [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | const CONFIG_ENV: &'static str = "MIAU_CONFIG"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | const OVERLAY_ENV: &'static str = "MIAU_OVERLAY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | const DEFAULT_CONFIG: &'static str = "config/miau-prod.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/environment.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | const DEFAULT_OVERLAY: &'static str = "config/miau-dev.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/logging.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / if !record.location().module_path().starts_with("miau::") { [INFO] [stderr] 17 | | if record.level() > EXTERNAL_LOG_LEVEL { [INFO] [stderr] 18 | | return; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if !record.location().module_path().starts_with("miau::") && record.level() > EXTERNAL_LOG_LEVEL { [INFO] [stderr] 17 | return; [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bot.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | self.parked.take().map(|t| t.unpark()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.parked.take() { t.unpark() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot.rs:267:16 [INFO] [stderr] | [INFO] [stderr] 267 | if line.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/commands.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / let mut start_at = None; [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | // if this is a private message, then the entire line is (probably) the command [INFO] [stderr] 58 | | if !m.args[0].starts_with("#") { [INFO] [stderr] 59 | | start_at = Some(0); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let start_at = if !m.args[0].starts_with("#") { Some(0) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | if !m.args[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | if text.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | if m.args[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/irc.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | self.c.peek().map(|x| x.0).unwrap_or(self.s.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/irc.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if spec.len() == 0 { return Missing } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/network.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match &self.state { [INFO] [stderr] 43 | | &State::Active(ref act) => Some(&act.nick[..]), [INFO] [stderr] 44 | | _ => None, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | match self.state { [INFO] [stderr] 43 | State::Active(ref act) => Some(&act.nick[..]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/network.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match m.verb { [INFO] [stderr] 136 | | "PRIVMSG" => commands::handle_irc(net, out, m), [INFO] [stderr] 137 | | _ => { } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ help: try this: `if let "PRIVMSG" = m.verb { commands::handle_irc(net, out, m) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bot.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | self.parked.take().map(|t| t.unpark()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.parked.take() { t.unpark() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot.rs:267:16 [INFO] [stderr] | [INFO] [stderr] 267 | if line.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/commands.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / let mut start_at = None; [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | // if this is a private message, then the entire line is (probably) the command [INFO] [stderr] 58 | | if !m.args[0].starts_with("#") { [INFO] [stderr] 59 | | start_at = Some(0); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let start_at = if !m.args[0].starts_with("#") { Some(0) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | if !m.args[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | if text.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | if m.args[0].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/irc.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | self.c.peek().map(|x| x.0).unwrap_or(self.s.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/irc.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if spec.len() == 0 { return Missing } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/network.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match &self.state { [INFO] [stderr] 43 | | &State::Active(ref act) => Some(&act.nick[..]), [INFO] [stderr] 44 | | _ => None, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | match self.state { [INFO] [stderr] 43 | State::Active(ref act) => Some(&act.nick[..]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/network.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match m.verb { [INFO] [stderr] 136 | | "PRIVMSG" => commands::handle_irc(net, out, m), [INFO] [stderr] 137 | | _ => { } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ help: try this: `if let "PRIVMSG" = m.verb { commands::handle_irc(net, out, m) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.40s [INFO] running `"docker" "inspect" "26c76cbc6d7819e3e2c91ee42183ac203bcef93bd959a6e2cceba3451ad32423"` [INFO] running `"docker" "rm" "-f" "26c76cbc6d7819e3e2c91ee42183ac203bcef93bd959a6e2cceba3451ad32423"` [INFO] [stdout] 26c76cbc6d7819e3e2c91ee42183ac203bcef93bd959a6e2cceba3451ad32423