[INFO] updating cached repository ajferrick/advent_of_code_2015 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajferrick/advent_of_code_2015 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajferrick/advent_of_code_2015" "work/ex/clippy-test-run/sources/stable/gh/ajferrick/advent_of_code_2015"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajferrick/advent_of_code_2015'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajferrick/advent_of_code_2015" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajferrick/advent_of_code_2015"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajferrick/advent_of_code_2015'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c9a8c23485b92e9d60a52857ea2073d2c8db055 [INFO] sha for GitHub repo ajferrick/advent_of_code_2015: 5c9a8c23485b92e9d60a52857ea2073d2c8db055 [INFO] validating manifest of ajferrick/advent_of_code_2015 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajferrick/advent_of_code_2015 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajferrick/advent_of_code_2015 [INFO] finished frobbing ajferrick/advent_of_code_2015 [INFO] frobbed toml for ajferrick/advent_of_code_2015 written to work/ex/clippy-test-run/sources/stable/gh/ajferrick/advent_of_code_2015/Cargo.toml [INFO] started frobbing ajferrick/advent_of_code_2015 [INFO] finished frobbing ajferrick/advent_of_code_2015 [INFO] frobbed toml for ajferrick/advent_of_code_2015 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajferrick/advent_of_code_2015/Cargo.toml [INFO] crate ajferrick/advent_of_code_2015 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajferrick/advent_of_code_2015 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajferrick/advent_of_code_2015:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 940d6baac5a2f659d781c0f1fd7c7d177f07fae9d55f0aa262f1f93b2409f969 [INFO] running `"docker" "start" "-a" "940d6baac5a2f659d781c0f1fd7c7d177f07fae9d55f0aa262f1f93b2409f969"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_2.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | GiftBox { l: l, w: w, h: h } [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_1.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_1.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_1.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn part_1(parens: &String) -> isize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day_1.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|char| match char { '(' => 1, ')' => -1, _ => 0 } ) [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 25 | | .fold(0, |acc, mv| acc + mv) [INFO] [stderr] | |____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_1.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn part_2(parens: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_2.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | let dim_string = line.split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/day_2.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|l| GiftBox::from_str(l)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GiftBox::from_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | '^' => { self.x = self.x - 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | 'v' => { self.x = self.x + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | '<' => { self.y = self.y - 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | '>' => { self.y = self.y + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_3.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn part_1(moves: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_3.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn part_2(moves: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day_3.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | let mut target_santa = match santa_toggle { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 62 | | true => &mut santa, [INFO] [stderr] 63 | | false => &mut robo_santa [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if santa_toggle { &mut santa } else { &mut robo_santa }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_1.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn part_1(parens: &String) -> isize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day_1.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|char| match char { '(' => 1, ')' => -1, _ => 0 } ) [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 25 | | .fold(0, |acc, mv| acc + mv) [INFO] [stderr] | |____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_1.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn part_2(parens: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_2.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | let dim_string = line.split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/day_2.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|l| GiftBox::from_str(l)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `GiftBox::from_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | '^' => { self.x = self.x - 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | 'v' => { self.x = self.x + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | '<' => { self.y = self.y - 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_3.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | '>' => { self.y = self.y + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_3.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | fn part_1(moves: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day_3.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn part_2(moves: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day_3.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | let mut target_santa = match santa_toggle { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 62 | | true => &mut santa, [INFO] [stderr] 63 | | false => &mut robo_santa [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if santa_toggle { &mut santa } else { &mut robo_santa }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "940d6baac5a2f659d781c0f1fd7c7d177f07fae9d55f0aa262f1f93b2409f969"` [INFO] running `"docker" "rm" "-f" "940d6baac5a2f659d781c0f1fd7c7d177f07fae9d55f0aa262f1f93b2409f969"` [INFO] [stdout] 940d6baac5a2f659d781c0f1fd7c7d177f07fae9d55f0aa262f1f93b2409f969