[INFO] updating cached repository aickin/rust_advent_2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aickin/rust_advent_2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aickin/rust_advent_2017" "work/ex/clippy-test-run/sources/stable/gh/aickin/rust_advent_2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aickin/rust_advent_2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aickin/rust_advent_2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aickin/rust_advent_2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aickin/rust_advent_2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5f650a628520f93877fafc9b06cf7eab1e7f97e0 [INFO] sha for GitHub repo aickin/rust_advent_2017: 5f650a628520f93877fafc9b06cf7eab1e7f97e0 [INFO] validating manifest of aickin/rust_advent_2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aickin/rust_advent_2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aickin/rust_advent_2017 [INFO] finished frobbing aickin/rust_advent_2017 [INFO] frobbed toml for aickin/rust_advent_2017 written to work/ex/clippy-test-run/sources/stable/gh/aickin/rust_advent_2017/Cargo.toml [INFO] started frobbing aickin/rust_advent_2017 [INFO] finished frobbing aickin/rust_advent_2017 [INFO] frobbed toml for aickin/rust_advent_2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aickin/rust_advent_2017/Cargo.toml [INFO] crate aickin/rust_advent_2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aickin/rust_advent_2017 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aickin/rust_advent_2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6945c296dd7299a6bf702981291f575eae28a565010521272866d6f2b8757ca6 [INFO] running `"docker" "start" "-a" "6945c296dd7299a6bf702981291f575eae28a565010521272866d6f2b8757ca6"` [INFO] [stderr] Checking rust_advent_2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day2.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | .fold(9999999, |value, num| { if num < value { num } else { value }}); [INFO] [stderr] | ^^^^^^^ help: consider: `9_999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::Iter` [INFO] [stderr] --> src/day3.rs:2:6 [INFO] [stderr] | [INFO] [stderr] 2 | use std::slice::Iter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/day3.rs:140:48 [INFO] [stderr] | [INFO] [stderr] 140 | fn set(&mut self, point: &Point, value: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | return point.unwrap().distance(&Point { x: 0, y: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `point.unwrap().distance(&Point { x: 0, y: 0 })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let destination = 347991; [INFO] [stderr] | ^^^^^^ help: consider: `347_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | while last_value < 347991 { [INFO] [stderr] | ^^^^^^ help: consider: `347_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day2.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | .fold(9999999, |value, num| { if num < value { num } else { value }}); [INFO] [stderr] | ^^^^^^^ help: consider: `9_999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice::Iter` [INFO] [stderr] --> src/day3.rs:2:6 [INFO] [stderr] | [INFO] [stderr] 2 | use std::slice::Iter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/day3.rs:140:48 [INFO] [stderr] | [INFO] [stderr] 140 | fn set(&mut self, point: &Point, value: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day3.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | return point.unwrap().distance(&Point { x: 0, y: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `point.unwrap().distance(&Point { x: 0, y: 0 })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let destination = 347991; [INFO] [stderr] | ^^^^^^ help: consider: `347_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day3.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | while last_value < 347991 { [INFO] [stderr] | ^^^^^^ help: consider: `347_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/day2.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/day2.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | 0 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | if char == chars.get(opposite_index).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `chars[opposite_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day1.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | total = total + digit.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += digit.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | if char == chars.get(opposite_index).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `chars[opposite_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day1.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | total = total + digit.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += digit.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | .map(|strValue| { strValue.parse::().unwrap() }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | .map(|strValue| { strValue.parse::().unwrap() }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | let vec : Vec = line.split_whitespace().map(|strValue| { strValue.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3.rs:107:7 [INFO] [stderr] | [INFO] [stderr] 107 | self.travelled_since_last_turn = self.travelled_since_last_turn + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.travelled_since_last_turn += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | self.side_length = self.side_length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.side_length += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day3.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | let inner_map = self.values.entry(point.x).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day4.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match has_repeat { [INFO] [stderr] 14 | | true => total, [INFO] [stderr] 15 | | false => total + 1, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if has_repeat { total } else { total + 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day4.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match has_repeat { [INFO] [stderr] 32 | | true => total, [INFO] [stderr] 33 | | false => total + 1, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if has_repeat { total } else { total + 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day5.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | let mut vec : Vec = DATA.split("\n").map(|n| { n.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | *value = *value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | steps = steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `steps += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day5.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | let mut vec : Vec = DATA.split("\n").map(|n| { n.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | *value = *value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | *value = *value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | steps = steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `steps += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | if char == chars.get(opposite_index).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `chars[opposite_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day1.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | total = total + digit.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += digit.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | if char == chars.get(opposite_index).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `chars[opposite_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day1.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | total = total + digit.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += digit.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | .map(|strValue| { strValue.parse::().unwrap() }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | .map(|strValue| { strValue.parse::().unwrap() }) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `strValue` should have a snake case name such as `str_value` [INFO] [stderr] --> src/day2.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | let vec : Vec = line.split_whitespace().map(|strValue| { strValue.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3.rs:107:7 [INFO] [stderr] | [INFO] [stderr] 107 | self.travelled_since_last_turn = self.travelled_since_last_turn + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.travelled_since_last_turn += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | self.side_length = self.side_length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.side_length += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/day3.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | let inner_map = self.values.entry(point.x).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day4.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match has_repeat { [INFO] [stderr] 14 | | true => total, [INFO] [stderr] 15 | | false => total + 1, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if has_repeat { total } else { total + 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | DATA.split("\n").fold(0, |total, line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/day4.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match has_repeat { [INFO] [stderr] 32 | | true => total, [INFO] [stderr] 33 | | false => total + 1, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if has_repeat { total } else { total + 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day5.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | let mut vec : Vec = DATA.split("\n").map(|n| { n.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | *value = *value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | steps = steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `steps += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day5.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | let mut vec : Vec = DATA.split("\n").map(|n| { n.parse::().unwrap() }).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | *value = *value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | *value = *value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day5.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | steps = steps + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `steps += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "6945c296dd7299a6bf702981291f575eae28a565010521272866d6f2b8757ca6"` [INFO] running `"docker" "rm" "-f" "6945c296dd7299a6bf702981291f575eae28a565010521272866d6f2b8757ca6"` [INFO] [stdout] 6945c296dd7299a6bf702981291f575eae28a565010521272866d6f2b8757ca6