[INFO] updating cached repository ahyaemon/console_meiro [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahyaemon/console_meiro [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahyaemon/console_meiro" "work/ex/clippy-test-run/sources/stable/gh/ahyaemon/console_meiro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahyaemon/console_meiro'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahyaemon/console_meiro" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahyaemon/console_meiro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahyaemon/console_meiro'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 616ae8e196cbf8530b233e3f9adab6d334c27349 [INFO] sha for GitHub repo ahyaemon/console_meiro: 616ae8e196cbf8530b233e3f9adab6d334c27349 [INFO] validating manifest of ahyaemon/console_meiro on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahyaemon/console_meiro on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahyaemon/console_meiro [INFO] finished frobbing ahyaemon/console_meiro [INFO] frobbed toml for ahyaemon/console_meiro written to work/ex/clippy-test-run/sources/stable/gh/ahyaemon/console_meiro/Cargo.toml [INFO] started frobbing ahyaemon/console_meiro [INFO] finished frobbing ahyaemon/console_meiro [INFO] frobbed toml for ahyaemon/console_meiro written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahyaemon/console_meiro/Cargo.toml [INFO] crate ahyaemon/console_meiro has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahyaemon/console_meiro against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahyaemon/console_meiro:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e92c03b24380c572ebf19002ce095c2ab6a1e38b7c8e626b624d195886ffac95 [INFO] running `"docker" "start" "-a" "e92c03b24380c572ebf19002ce095c2ab6a1e38b7c8e626b624d195886ffac95"` [INFO] [stderr] Checking meiro v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/screen.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/screen.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stage/map.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn out_of_range(&self, pos: &(i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stage/map.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | else if pos.0 >= self.nrow as i8 { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 37 | | true [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stage/map.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | if pos.0 < 0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 34 | | true [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/stage/map.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | else if pos.1 >= self.ncol as i8 { [INFO] [stderr] | ______________^ [INFO] [stderr] 43 | | true [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | else{ [INFO] [stderr] 46 | | false [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `pos.1 >= self.ncol as i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stage/map.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn empty_space(&self, pos: &(u8, u8)) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `(u8, u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/text.rs:13:41 [INFO] [stderr] | [INFO] [stderr] 13 | for (irow, row) in self.0.split("\n").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `meiro`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stage/map.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn out_of_range(&self, pos: &(i8, i8)) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `(i8, i8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/stage/map.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | else if pos.0 >= self.nrow as i8 { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 37 | | true [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/stage/map.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | if pos.0 < 0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 34 | | true [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/stage/map.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | else if pos.1 >= self.ncol as i8 { [INFO] [stderr] | ______________^ [INFO] [stderr] 43 | | true [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | else{ [INFO] [stderr] 46 | | false [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `pos.1 >= self.ncol as i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stage/map.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn empty_space(&self, pos: &(u8, u8)) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `(u8, u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/text.rs:13:41 [INFO] [stderr] | [INFO] [stderr] 13 | for (irow, row) in self.0.split("\n").enumerate() { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `meiro`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e92c03b24380c572ebf19002ce095c2ab6a1e38b7c8e626b624d195886ffac95"` [INFO] running `"docker" "rm" "-f" "e92c03b24380c572ebf19002ce095c2ab6a1e38b7c8e626b624d195886ffac95"` [INFO] [stdout] e92c03b24380c572ebf19002ce095c2ab6a1e38b7c8e626b624d195886ffac95