[INFO] updating cached repository ahmednooor/mr_huffy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahmednooor/mr_huffy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahmednooor/mr_huffy" "work/ex/clippy-test-run/sources/stable/gh/ahmednooor/mr_huffy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahmednooor/mr_huffy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahmednooor/mr_huffy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmednooor/mr_huffy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmednooor/mr_huffy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df72a715d6f8f9026d249a77ec701edb9fb26407 [INFO] sha for GitHub repo ahmednooor/mr_huffy: df72a715d6f8f9026d249a77ec701edb9fb26407 [INFO] validating manifest of ahmednooor/mr_huffy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahmednooor/mr_huffy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahmednooor/mr_huffy [INFO] finished frobbing ahmednooor/mr_huffy [INFO] frobbed toml for ahmednooor/mr_huffy written to work/ex/clippy-test-run/sources/stable/gh/ahmednooor/mr_huffy/Cargo.toml [INFO] started frobbing ahmednooor/mr_huffy [INFO] finished frobbing ahmednooor/mr_huffy [INFO] frobbed toml for ahmednooor/mr_huffy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmednooor/mr_huffy/Cargo.toml [INFO] crate ahmednooor/mr_huffy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahmednooor/mr_huffy against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmednooor/mr_huffy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2a4adc1dd0d3139bee62f71dbff63d51b3ab5ff59f662b47bc57a23b0a3e6fa [INFO] running `"docker" "start" "-a" "d2a4adc1dd0d3139bee62f71dbff63d51b3ab5ff59f662b47bc57a23b0a3e6fa"` [INFO] [stderr] Checking mr_huffy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/helpers.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | bitstring [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/helpers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / U8_BITSTR_ARR[integer as usize].1 [INFO] [stderr] 89 | | .clone().to_string(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | encoded_output_bytes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / comb_freq_and_encoded_bytes(&freq_bytes, [INFO] [stderr] 40 | | &encoded_bytes); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/mod.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | decoded_bytes [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/mod.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stderr] 92 | | &tree); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/helpers.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | bitstring [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/helpers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / U8_BITSTR_ARR[integer as usize].1 [INFO] [stderr] 89 | | .clone().to_string(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/mod.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | encoded_output_bytes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / comb_freq_and_encoded_bytes(&freq_bytes, [INFO] [stderr] 40 | | &encoded_bytes); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/mr_huffy/mod.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | decoded_bytes [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/mr_huffy/mod.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / decoded_bytes_from_bitstring_and_tree(&compressed_bitstring, [INFO] [stderr] 92 | | &tree); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | bitstring = String::from("1".to_owned() + &bitstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `"1".to_owned() + &bitstring` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | bitstring = String::from(offset_bits + &bitstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `offset_bits + &bitstring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | bitstring = String::from(bitstring[offset_index..].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[offset_index..].to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | bitstring = String::from(bitstring[..].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[..].to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let b1: u32 = ((u8_arr[0] as u32) << 24) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | let b2: u32 = ((u8_arr[1] as u32) << 16) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let b3: u32 = ((u8_arr[2] as u32) << 8) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/mr_huffy/helpers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / U8_BITSTR_ARR[integer as usize].1 [INFO] [stderr] 89 | | .clone().to_string(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 88 | &(*U8_BITSTR_ARR[integer as usize].1).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 88 | &str::clone(U8_BITSTR_ARR[integer as usize].1).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/get_freq_map.rs:3:38 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_freq_map.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | freq_map.push((byte.clone(), 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/make_tree.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn make_tree(freq_map: &Vec<(u8, u32)>) -> Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(u8, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | byte: Some(byte.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | freq: freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_1_node.freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_2_node.freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if !tree.left.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `tree.left.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if !tree.right.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.right.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | bits_map.insert(tree.byte.unwrap().clone(), bits.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:39:36 [INFO] [stderr] | [INFO] [stderr] 39 | comrpessed_bits_map.insert(tree.byte.unwrap().clone(), "1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/make_bitstring.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | input_bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/freq_map_to_bytes.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn freq_map_to_bytes(freq_map: &Vec<(u8, u32)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(u8, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn comb_freq_and_encoded_bytes(freq_bytes: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:6:51 [INFO] [stderr] | [INFO] [stderr] 6 | encoded_bytes: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mr_huffy/freq_bytes_to_freq_map.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | while freq_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!freq_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn encoded_bytes_to_bitstring(encoded_bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | &u8_to_bitstring(byte.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if bit == '0' && !current_node.left.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bit == '0' && current_node.left.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if bit == '1' && !current_node.right.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bit == '1' && current_node.right.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if !current_node.byte.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.byte.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/mr_huffy/mod.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if input_bytes.len() < 1 { return input_bytes.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | bitstring = String::from("1".to_owned() + &bitstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `"1".to_owned() + &bitstring` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/mr_huffy/mod.rs:79:8 [INFO] [stderr] | [INFO] [stderr] 79 | if encoded_input_bytes.len() < 1 { return encoded_input_bytes.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `encoded_input_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | bitstring = String::from(offset_bits + &bitstring); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `offset_bits + &bitstring` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | bitstring = String::from(bitstring[offset_index..].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[offset_index..].to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mr_huffy/helpers.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | bitstring = String::from(bitstring[..].to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `bitstring[..].to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | let b1: u32 = ((u8_arr[0] as u32) << 24) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | let b2: u32 = ((u8_arr[1] as u32) << 16) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let b3: u32 = ((u8_arr[2] as u32) << 8) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mr_huffy/helpers.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let b4: u32 = ((u8_arr[3] as u32)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8_arr[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/mr_huffy/helpers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / U8_BITSTR_ARR[integer as usize].1 [INFO] [stderr] 89 | | .clone().to_string(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 88 | &(*U8_BITSTR_ARR[integer as usize].1).clone().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 88 | &str::clone(U8_BITSTR_ARR[integer as usize].1).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/get_freq_map.rs:3:38 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn get_freq_map(input_bytes_vec: &Vec) -> Vec<(u8, u32)> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_freq_map.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | freq_map.push((byte.clone(), 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `byte` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/make_tree.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn make_tree(freq_map: &Vec<(u8, u32)>) -> Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(u8, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | byte: Some(byte.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | freq: freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: Could not compile `mr_huffy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_1_node.freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/make_tree.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | freq: min_1_node.freq.clone() + min_2_node.freq.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `min_2_node.freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if !tree.left.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `tree.left.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if !tree.right.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `tree.right.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | bits_map.insert(tree.byte.unwrap().clone(), bits.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/get_comrpessed_bits_map.rs:39:36 [INFO] [stderr] | [INFO] [stderr] 39 | comrpessed_bits_map.insert(tree.byte.unwrap().clone(), "1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tree.byte.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/make_bitstring.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | input_bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/freq_map_to_bytes.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn freq_map_to_bytes(freq_map: &Vec<(u8, u32)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(u8, u32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn comb_freq_and_encoded_bytes(freq_bytes: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/comb_freq_and_encoded_bytes.rs:6:51 [INFO] [stderr] | [INFO] [stderr] 6 | encoded_bytes: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mr_huffy/freq_bytes_to_freq_map.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | while freq_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!freq_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn encoded_bytes_to_bitstring(encoded_bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mr_huffy/encoded_bytes_to_bitstring.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | &u8_to_bitstring(byte.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:5:57 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn decoded_bytes_from_bitstring_and_tree(bitstring: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if bit == '0' && !current_node.left.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bit == '0' && current_node.left.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if bit == '1' && !current_node.right.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bit == '1' && current_node.right.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mr_huffy/decoded_bytes_from_bitstring_and_tree.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if !current_node.byte.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `current_node.byte.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/mr_huffy/mod.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if input_bytes.len() < 1 { return input_bytes.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/mr_huffy/mod.rs:79:8 [INFO] [stderr] | [INFO] [stderr] 79 | if encoded_input_bytes.len() < 1 { return encoded_input_bytes.clone(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `encoded_input_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mr_huffy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d2a4adc1dd0d3139bee62f71dbff63d51b3ab5ff59f662b47bc57a23b0a3e6fa"` [INFO] running `"docker" "rm" "-f" "d2a4adc1dd0d3139bee62f71dbff63d51b3ab5ff59f662b47bc57a23b0a3e6fa"` [INFO] [stdout] d2a4adc1dd0d3139bee62f71dbff63d51b3ab5ff59f662b47bc57a23b0a3e6fa