[INFO] updating cached repository ahal/AoC2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahal/AoC2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahal/AoC2018" "work/ex/clippy-test-run/sources/stable/gh/ahal/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahal/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahal/AoC2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahal/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahal/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8153d095c830100052db108a30721b3bd28700a9 [INFO] sha for GitHub repo ahal/AoC2018: 8153d095c830100052db108a30721b3bd28700a9 [INFO] validating manifest of ahal/AoC2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahal/AoC2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahal/AoC2018 [INFO] finished frobbing ahal/AoC2018 [INFO] frobbed toml for ahal/AoC2018 written to work/ex/clippy-test-run/sources/stable/gh/ahal/AoC2018/Cargo.toml [INFO] started frobbing ahal/AoC2018 [INFO] finished frobbing ahal/AoC2018 [INFO] frobbed toml for ahal/AoC2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahal/AoC2018/Cargo.toml [INFO] crate ahal/AoC2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahal/AoC2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahal/AoC2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d1689f686972864dd010e46d271e821dc50315729f2c1f413566c045593d916 [INFO] running `"docker" "start" "-a" "1d1689f686972864dd010e46d271e821dc50315729f2c1f413566c045593d916"` [INFO] [stderr] Checking aoc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | fn similar_chars(string_a: &String, string_b: &String) -> Vec [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | fn similar_chars(string_a: &String, string_b: &String) -> Vec [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | fn similar_chars(string_a: &String, string_b: &String) -> Vec [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | fn similar_chars(string_a: &String, string_b: &String) -> Vec [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "1d1689f686972864dd010e46d271e821dc50315729f2c1f413566c045593d916"` [INFO] running `"docker" "rm" "-f" "1d1689f686972864dd010e46d271e821dc50315729f2c1f413566c045593d916"` [INFO] [stdout] 1d1689f686972864dd010e46d271e821dc50315729f2c1f413566c045593d916