[INFO] updating cached repository afnanenayet/Enayet-Shell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/afnanenayet/Enayet-Shell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/afnanenayet/Enayet-Shell" "work/ex/clippy-test-run/sources/stable/gh/afnanenayet/Enayet-Shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/afnanenayet/Enayet-Shell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/afnanenayet/Enayet-Shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/afnanenayet/Enayet-Shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/afnanenayet/Enayet-Shell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6509126a05755ae6c64a9271379047ea079afd63 [INFO] sha for GitHub repo afnanenayet/Enayet-Shell: 6509126a05755ae6c64a9271379047ea079afd63 [INFO] validating manifest of afnanenayet/Enayet-Shell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of afnanenayet/Enayet-Shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing afnanenayet/Enayet-Shell [INFO] finished frobbing afnanenayet/Enayet-Shell [INFO] frobbed toml for afnanenayet/Enayet-Shell written to work/ex/clippy-test-run/sources/stable/gh/afnanenayet/Enayet-Shell/Cargo.toml [INFO] started frobbing afnanenayet/Enayet-Shell [INFO] finished frobbing afnanenayet/Enayet-Shell [INFO] frobbed toml for afnanenayet/Enayet-Shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/afnanenayet/Enayet-Shell/Cargo.toml [INFO] crate afnanenayet/Enayet-Shell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting afnanenayet/Enayet-Shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/afnanenayet/Enayet-Shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea02d31821723a715da0c9843cc1579eaad65c12596c32522d1ce08a06ff9ab1 [INFO] running `"docker" "start" "-a" "ea02d31821723a715da0c9843cc1579eaad65c12596c32522d1ce08a06ff9ab1"` [INFO] [stderr] Checking ensh v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DEFAULT_PATHS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DEFAULT_PATHS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const SHELL_PROMPT: &'static str = ">"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DEF_CONFIG_FNAME: &'static str = ".ensh_config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `DEFAULT_PATHS` [INFO] [stderr] --> src/parser/config.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | use consts::{DEF_CONFIG_FNAME, DEFAULT_PATHS}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let home_dir = home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | let home = home_dir(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DEFAULT_PATHS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DEFAULT_PATHS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const SHELL_PROMPT: &'static str = ">"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DEF_CONFIG_FNAME: &'static str = ".ensh_config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env::temp_dir` [INFO] [stderr] --> src/shell.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | use std::env::temp_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::parser::config::create_default_config` [INFO] [stderr] --> src/shell.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | use super::parser::config::create_default_config; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let home_dir = home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/parser/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | let home = home_dir(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output_str` [INFO] [stderr] --> src/cmd_dispatch.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let output_str = from_utf8(&output.stdout.as_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_output_str` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_err` [INFO] [stderr] --> src/interface.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn print_err(output: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_path` [INFO] [stderr] --> src/parser/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn verify_path(path: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `condense_path` [INFO] [stderr] --> src/parser/mod.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn condense_path(path: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_home_str` [INFO] [stderr] --> src/parser/mod.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | fn get_home_str() -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/shell.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | fn default() -> Shell { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_paths` [INFO] [stderr] --> src/shell.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn set_paths(&mut self, paths: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/config.rs:18:69 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn load_paths_from_config(config_path: Option<&str>, def_paths: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser/config.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | let config_path = config_path.unwrap_or(def_config_fp.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| def_config_fp.as_str())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/config.rs:61:58 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn create_default_config(file_path: &str, def_paths: &Vec) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/parser/config.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | file.write(line.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/parser/config.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | file.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/shell.rs:108:76 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn load_paths(&mut self, config_path: Option<&str>, default_paths: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd_dispatch.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | let tok_cmd = cmd.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd_dispatch.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | let tok_cmd = cmd.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ensh`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `output_str` [INFO] [stderr] --> src/cmd_dispatch.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let output_str = from_utf8(&output.stdout.as_slice()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_output_str` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shell` [INFO] [stderr] --> src/shell.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let shell = Shell::default(); [INFO] [stderr] | ^^^^^ help: consider using `_shell` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `shell` [INFO] [stderr] --> src/lib.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | let shell = init_shell(Some(config_fp)); [INFO] [stderr] | ^^^^^ help: consider using `_shell` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_path` [INFO] [stderr] --> src/parser/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn verify_path(path: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_paths` [INFO] [stderr] --> src/shell.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn set_paths(&mut self, paths: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/config.rs:18:69 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn load_paths_from_config(config_path: Option<&str>, def_paths: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser/config.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | let config_path = config_path.unwrap_or(def_config_fp.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| def_config_fp.as_str())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/config.rs:61:58 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn create_default_config(file_path: &str, def_paths: &Vec) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/parser/config.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | file.write(line.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/parser/config.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | file.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/shell.rs:108:76 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn load_paths(&mut self, config_path: Option<&str>, default_paths: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/shell.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | parser::config::create_default_config(&fp_str, &def_paths_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/shell.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | assert!(shell.paths.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!shell.paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd_dispatch.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | let tok_cmd = cmd.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd_dispatch.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | let tok_cmd = cmd.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | super::parser::config::create_default_config(config_fp, &config_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ensh`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ea02d31821723a715da0c9843cc1579eaad65c12596c32522d1ce08a06ff9ab1"` [INFO] running `"docker" "rm" "-f" "ea02d31821723a715da0c9843cc1579eaad65c12596c32522d1ce08a06ff9ab1"` [INFO] [stdout] ea02d31821723a715da0c9843cc1579eaad65c12596c32522d1ce08a06ff9ab1