[INFO] updating cached repository adwydman/calculator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/adwydman/calculator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/adwydman/calculator" "work/ex/clippy-test-run/sources/stable/gh/adwydman/calculator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adwydman/calculator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/adwydman/calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adwydman/calculator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adwydman/calculator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 226de8c00a18dbddc44d5ab4491032ae1847f4fc
[INFO] sha for GitHub repo adwydman/calculator: 226de8c00a18dbddc44d5ab4491032ae1847f4fc
[INFO] validating manifest of adwydman/calculator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of adwydman/calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing adwydman/calculator
[INFO] finished frobbing adwydman/calculator
[INFO] frobbed toml for adwydman/calculator written to work/ex/clippy-test-run/sources/stable/gh/adwydman/calculator/Cargo.toml
[INFO] started frobbing adwydman/calculator
[INFO] finished frobbing adwydman/calculator
[INFO] frobbed toml for adwydman/calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adwydman/calculator/Cargo.toml
[INFO] crate adwydman/calculator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting adwydman/calculator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adwydman/calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3637a9837fa7041ec7c8b00cd701776ef6b61320ea28ffe0d0a8e63084ba2187
[INFO] running `"docker" "start" "-a" "3637a9837fa7041ec7c8b00cd701776ef6b61320ea28ffe0d0a8e63084ba2187"`
[INFO] [stderr]     Checking hello_world v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     choice // the same as `return choice;`  - this is valid, as Rust supports expressive paradigm
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |       let choice = match choice.trim() {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 33 | |         "1" => Operation::Add,
[INFO] [stderr] 34 | |         "2" => Operation::Multiply,
[INFO] [stderr] 35 | |         "3" => Operation::Subtract,
[INFO] [stderr] 36 | |         "4" => Operation::Divide,
[INFO] [stderr] 37 | |         _ => Operation::NoneOp
[INFO] [stderr] 38 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     numbers // check `choice`
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let numbers = Input { first_number: first, second_number: second};
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     choice // the same as `return choice;`  - this is valid, as Rust supports expressive paradigm
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |       let choice = match choice.trim() {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 33 | |         "1" => Operation::Add,
[INFO] [stderr] 34 | |         "2" => Operation::Multiply,
[INFO] [stderr] 35 | |         "3" => Operation::Subtract,
[INFO] [stderr] 36 | |         "4" => Operation::Divide,
[INFO] [stderr] 37 | |         _ => Operation::NoneOp
[INFO] [stderr] 38 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:64:5
[INFO] [stderr]    |
[INFO] [stderr] 64 |     numbers // check `choice`
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let numbers = Input { first_number: first, second_number: second};
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.77s
[INFO] running `"docker" "inspect" "3637a9837fa7041ec7c8b00cd701776ef6b61320ea28ffe0d0a8e63084ba2187"`
[INFO] running `"docker" "rm" "-f" "3637a9837fa7041ec7c8b00cd701776ef6b61320ea28ffe0d0a8e63084ba2187"`
[INFO] [stdout] 3637a9837fa7041ec7c8b00cd701776ef6b61320ea28ffe0d0a8e63084ba2187