[INFO] updating cached repository adventofjuan/AdventOfCode2018-Day05
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/adventofjuan/AdventOfCode2018-Day05
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day05" "work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day05"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day05'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day05" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day05"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day05'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 64171911c5f808f9ee5e51961fad68ed9e904292
[INFO] sha for GitHub repo adventofjuan/AdventOfCode2018-Day05: 64171911c5f808f9ee5e51961fad68ed9e904292
[INFO] validating manifest of adventofjuan/AdventOfCode2018-Day05 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of adventofjuan/AdventOfCode2018-Day05 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing adventofjuan/AdventOfCode2018-Day05
[INFO] finished frobbing adventofjuan/AdventOfCode2018-Day05
[INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day05 written to work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day05/Cargo.toml
[INFO] started frobbing adventofjuan/AdventOfCode2018-Day05
[INFO] finished frobbing adventofjuan/AdventOfCode2018-Day05
[INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day05 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day05/Cargo.toml
[INFO] crate adventofjuan/AdventOfCode2018-Day05 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting adventofjuan/AdventOfCode2018-Day05 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day05:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 584d44d5f5a8c7d0437fcd92d52a0c0c72e51eeead4c1b718e5465609a117866
[INFO] running `"docker" "start" "-a" "584d44d5f5a8c7d0437fcd92d52a0c0c72e51eeead4c1b718e5465609a117866"`
[INFO] [stderr]     Checking advent05 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:17:20
[INFO] [stderr]    |
[INFO] [stderr] 17 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 18 | |                 if c != '\n' {
[INFO] [stderr] 19 | |                     new_string.push(c);
[INFO] [stderr] 20 | |                 }
[INFO] [stderr] 21 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |             } else if c != '\n' {
[INFO] [stderr] 18 |     new_string.push(c);
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 51 | |                 if c != '\n' {
[INFO] [stderr] 52 | |                     new_string.push(c);
[INFO] [stderr] 53 | |                 }
[INFO] [stderr] 54 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |             } else if c != '\n' {
[INFO] [stderr] 51 |     new_string.push(c);
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:6:17
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn part01(list: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn remove_char(list: &String, fc: char) -> String {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn react_full(list: &String) -> String {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:60:17
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn part02(list: &String) {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:17:20
[INFO] [stderr]    |
[INFO] [stderr] 17 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 18 | |                 if c != '\n' {
[INFO] [stderr] 19 | |                     new_string.push(c);
[INFO] [stderr] 20 | |                 }
[INFO] [stderr] 21 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 17 |             } else if c != '\n' {
[INFO] [stderr] 18 |     new_string.push(c);
[INFO] [stderr] 19 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 51 | |                 if c != '\n' {
[INFO] [stderr] 52 | |                     new_string.push(c);
[INFO] [stderr] 53 | |                 }
[INFO] [stderr] 54 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |             } else if c != '\n' {
[INFO] [stderr] 51 |     new_string.push(c);
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:6:17
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn part01(list: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn remove_char(list: &String, fc: char) -> String {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn react_full(list: &String) -> String {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:60:17
[INFO] [stderr]    |
[INFO] [stderr] 60 | fn part02(list: &String) {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.71s
[INFO] running `"docker" "inspect" "584d44d5f5a8c7d0437fcd92d52a0c0c72e51eeead4c1b718e5465609a117866"`
[INFO] running `"docker" "rm" "-f" "584d44d5f5a8c7d0437fcd92d52a0c0c72e51eeead4c1b718e5465609a117866"`
[INFO] [stdout] 584d44d5f5a8c7d0437fcd92d52a0c0c72e51eeead4c1b718e5465609a117866