[INFO] updating cached repository adudney/BL2_Unconverter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adudney/BL2_Unconverter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adudney/BL2_Unconverter" "work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Unconverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Unconverter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adudney/BL2_Unconverter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Unconverter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Unconverter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6fec2120bb404dbcf61c130d3a262500af5f6e8 [INFO] sha for GitHub repo adudney/BL2_Unconverter: e6fec2120bb404dbcf61c130d3a262500af5f6e8 [INFO] validating manifest of adudney/BL2_Unconverter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adudney/BL2_Unconverter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adudney/BL2_Unconverter [INFO] finished frobbing adudney/BL2_Unconverter [INFO] frobbed toml for adudney/BL2_Unconverter written to work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Unconverter/Cargo.toml [INFO] started frobbing adudney/BL2_Unconverter [INFO] finished frobbing adudney/BL2_Unconverter [INFO] frobbed toml for adudney/BL2_Unconverter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Unconverter/Cargo.toml [INFO] crate adudney/BL2_Unconverter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adudney/BL2_Unconverter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Unconverter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 876b580c6b4cceaac12cd8ee6c819092f849b107ecbbb6fe709a011d99661f71 [INFO] running `"docker" "start" "-a" "876b580c6b4cceaac12cd8ee6c819092f849b107ecbbb6fe709a011d99661f71"` [INFO] [stderr] Checking unconverter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match arg[0] { [INFO] [stderr] 14 | | "-f" => { // File [INFO] [stderr] 15 | | file = Some(File::open(arg[1]).unwrap()); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | _ => { [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let "-f" = arg[0] { // File [INFO] [stderr] 14 | file = Some(File::open(arg[1]).unwrap()); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if let None = file { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 22 | | return; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if file.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match arg[0] { [INFO] [stderr] 14 | | "-f" => { // File [INFO] [stderr] 15 | | file = Some(File::open(arg[1]).unwrap()); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | _ => { [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let "-f" = arg[0] { // File [INFO] [stderr] 14 | file = Some(File::open(arg[1]).unwrap()); [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if let None = file { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 22 | | return; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____- help: try this: `if file.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "876b580c6b4cceaac12cd8ee6c819092f849b107ecbbb6fe709a011d99661f71"` [INFO] running `"docker" "rm" "-f" "876b580c6b4cceaac12cd8ee6c819092f849b107ecbbb6fe709a011d99661f71"` [INFO] [stdout] 876b580c6b4cceaac12cd8ee6c819092f849b107ecbbb6fe709a011d99661f71